Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2020-01-15 | 1 | -0/+102 | |
| | ||||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2020-01-02 | 1 | -1/+1 | |
| | ||||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-12-27 | 1 | -3/+4 | |
| | ||||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-12-19 | 1 | -0/+65 | |
| | ||||||
* | Add latest changes from gitlab-org/gitlab@masterogolowinski-master-patch-80898 | GitLab Bot | 2019-12-16 | 2 | -2/+6 | |
| | ||||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-12-04 | 1 | -0/+48 | |
| | ||||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-12-01 | 1 | -0/+22 | |
| | ||||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-11-28 | 1 | -0/+48 | |
| | ||||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-11-25 | 1 | -0/+10 | |
| | ||||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-11-20 | 1 | -0/+39 | |
| | ||||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-11-07 | 1 | -0/+61 | |
| | ||||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-10-29 | 28 | -0/+56 | |
| | ||||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-10-18 | 3 | -0/+3 | |
| | ||||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-10-16 | 1 | -0/+80 | |
| | ||||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-10-03 | 1 | -0/+13 | |
| | ||||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-09-18 | 2 | -6/+6 | |
| | ||||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-09-13 | 2 | -18/+120 | |
| | ||||||
* | Add latest changes from gitlab-org/gitlab@master | GitLab Bot | 2019-09-13 | 2 | -0/+92 | |
| | ||||||
* | Add Scalability/FileUploads cop | Alessio Caiazza | 2019-09-10 | 1 | -0/+54 | |
| | | | | | This cop prevents you from using file in API, it points you to the development documentation about workhorse file acceleration. | |||||
* | Fix InjectEnterpriseEditionModule cop for qa/ | Yorick Peterse | 2019-08-28 | 1 | -0/+19 | |
| | | | | | | | This ensures the InjectEnterpriseEditionModule cop is able to detect the prepend patterns used in the qa/ directory. Previously it would not detect them as all EE QA modules reside in QA::EE, and not the top-level EE namespace. | |||||
* | Replace it_behaves_like with include_examplesadd-rubocop-check-for-be-success | Vitali Tatarintev | 2019-08-28 | 1 | -8/+8 | |
| | | | | | | Improve specs output readability by replacing `it_behaves_like` with `include_examples` in `BeSuccessMatcher` | |||||
* | Remove Rubocop::SpecHelper file | Vitali Tatarintev | 2019-08-28 | 1 | -3/+0 | |
| | ||||||
* | Inline shared examples for BeSuccessMatcher | Vitali Tatarintev | 2019-08-28 | 1 | -40/+31 | |
| | | | | | Former shared examples were used only once. Inlining them makes tests more clear. | |||||
* | Refactor BeSuccessMatcher specs for readability | Vitali Tatarintev | 2019-08-28 | 1 | -33/+32 | |
| | ||||||
* | Utilize Rubocop's Include for BeSuccessMatcher | Vitali Tatarintev | 2019-08-28 | 1 | -26/+8 | |
| | | | | | Use Rubocop's Include instead of manually checking the matcher in controllers specs. | |||||
* | Add support of not_to/to_not to BeSuccessMatcher | Vitali Tatarintev | 2019-08-28 | 1 | -2/+18 | |
| | | | | | | | | | | | | | | BeSuccessMatcher now supports following examples: ``` expect(response).to be_success expect(response).to_not be_success expect(response).not_to be_success is_expected.to be_success is_expected.to_not be_success is_expected.not_to be_success ``` | |||||
* | Refactor BeSuccessMatcher specs | Vitali Tatarintev | 2019-08-28 | 1 | -36/+25 | |
| | ||||||
* | Replace double quotes with single quotes | Vitali Tatarintev | 2019-08-28 | 1 | -9/+9 | |
| | ||||||
* | Enable frozen string literal | Vitali Tatarintev | 2019-08-28 | 1 | -0/+2 | |
| | ||||||
* | Autocorrect `be_success` to `be_successful` | Vitali Tatarintev | 2019-08-28 | 1 | -0/+10 | |
| | ||||||
* | Add Rubocop check to avoid using `be_success` | Vitali Tatarintev | 2019-08-28 | 1 | -0/+77 | |
| | | | | | | | | | | | Prevent using `be_success` call in controller specs to avoid getting following deprecation warning: ``` DEPRECATION WARNING: The success? predicate is deprecated and will be removed in Rails 6.0. Please use successful? as provided by Rack::Response::Helpers. ``` | |||||
* | Utilize RuboCop's Include/Exclude config | Peter Leitzen | 2019-08-26 | 3 | -46/+8 | |
| | | | | Stop checking the file location programmatically. | |||||
* | Adds cop to enforce string limits on migrations | Mayra Cabrera | 2019-08-23 | 1 | -0/+268 | |
| | | | | | | | This cop will analyze migrations that add columns with string, and report an offense if the string has no limit enforced Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/64505 | |||||
* | Add RSpec/TopLevelDescribePath cop | Sean McGivern | 2019-08-01 | 1 | -0/+67 | |
| | | | | | | | | The RSpec/FilePath cop checks that a spec file's path is correct, but only if the file describes a constant. We want to check, for any file with a top-level `describe`, whether the file path ends in `_spec.rb`. We don't care what comes before that; just that it will be executed by RSpec at all. | |||||
* | Extend cop for verifying injecting of EE modules | Yorick Peterse | 2019-07-30 | 1 | -42/+102 | |
| | | | | | | | | | This extends the InjectEnterpriseEditionModule RuboCop cop so that it verifies the following: 1. The line number the injection occurs on (as before). 2. The method used (e.g. prepend instead of prepend_if_ee). 3. The argument type passed when using the new module injection methods. | |||||
* | Change element_with_pattern cop to not use quotes | ddavison | 2019-07-10 | 1 | -2/+2 | |
| | | | | | | | Using quotes within string validations can be messy. Let's use a typical CSS selector for an unquoted attribute Update the cop spec to validate appropriate new message | |||||
* | Add a rubocop for Rails.logger | Mayra Cabrera | 2019-07-10 | 1 | -0/+42 | |
| | | | | | | Suggests to use a JSON structured log instead Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/54102 | |||||
* | Add a cop to ensure we authorize GraphQL types | Bob Van Landuyt | 2019-06-21 | 1 | -0/+66 | |
| | ||||||
* | Merge branch 'qa-extend-click-visit-actions' into 'master' | Dan Davison | 2019-05-28 | 1 | -1/+10 | |
|\ | | | | | | | | | | | | | Implement dynamic validation on QA Pages Closes gitlab-qa#280 See merge request gitlab-org/gitlab-ce!25704 | |||||
| * | Implement dynamic validation on QA Pages | ddavison | 2019-05-20 | 1 | -1/+10 | |
| | | | | | | | | | | | | Elements now have the ability to be required on pages or not Currently using the default wait mechanism Altered the ElementWithPattern Cop to fit new splat for init | |||||
* | | Link to issue in CodeReuse/ActiveRecord messagelink-to-issue-in-code-reuse-active-record-rubocop-rule | Luke Duncalfe | 2019-05-22 | 1 | -3/+3 | |
|/ | | | | | This provides the user with some context as to why certain ActiveRecord methods are blacklisted. | |||||
* | Add Rubocop rule to ban include ActionView::Context | Stan Hu | 2019-04-29 | 1 | -0/+45 | |
| | ||||||
* | Forbid the use of `#reload` and prefer `#reset`forbid-the-usage-of-reload | Kamil Trzciński | 2019-04-15 | 1 | -0/+60 | |
| | | | | | | | The `#reload` makes to load all objects into memory, and the main purpose of `#reload` is to drop the association cache. The `#reset` seems to solve exactly that case. | |||||
* | Properly handle `ee` migration specs | Heinrich Lee Yu | 2019-03-28 | 1 | -0/+18 | |
| | ||||||
* | Fix detecting nested EE constants in RuboCop | Yorick Peterse | 2019-01-16 | 1 | -0/+35 | |
| | | | | | | | | The InjectEnterpriseEditionModule cop would not detect certain nested EE constants such as `EE::Foo::Bar::Baz`. This could result in it not enforcing `prepend` being placed on the last line. This commit fixes this by just performing a string match on the line, instead of relying on AST matching. | |||||
* | Added Cop for injecting EE modules | Yorick Peterse | 2018-12-13 | 1 | -0/+133 | |
| | | | | | | | This Cop enforces the rule that injecting EE modules (using prepend, include, or extend) is done by placing the injection on the last line of a file, instead of somewhere in the middle. By placing these lines at the very end, merge conflicts will not happen. | |||||
* | Fix ActiveRecord::Migration deprecations | Yorick Peterse | 2018-12-12 | 3 | -10/+10 | |
| | | | | | Extending from ActiveRecord::Migration is deprecated, but was still used in a bunch of places. | |||||
* | Make add_reference cop accept a hash for :index | Toon Claes | 2018-11-27 | 1 | -2/+10 | |
| | | | | | | It might happen you want to make the reference column have a unique value, or you want to create partial indexes. So instead of only accepting a `true` value, also accept a hash of options. | |||||
* | Add cop prohibiting params argument in url_for47986-rubocop-safe-params | Jarka Košanová | 2018-11-22 | 1 | -0/+39 | |
| | ||||||
* | Add a new QA::ElementWithPattern cop | Rémy Coutable | 2018-10-15 | 2 | -0/+87 | |
| | | | | | | | This cop forbids the use of `element :foo, 'pattern'` and `element :bar, /pattern/` in QA files. Signed-off-by: Rémy Coutable <remy@rymai.me> |