Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | don't trigger project deletion hooks twice when removing a group | Gabriel Mazetto | 2018-08-26 | 1 | -0/+8 |
| | |||||
* | Fix: Project deletion may not log audit events during group deletion49796-project-deletion-may-not-log-audit-events-during-group-deletion | Valery Sizov | 2018-08-16 | 1 | -0/+11 |
| | |||||
* | Remove group todos when a users looses access | Jarka Kadlecová | 2018-08-02 | 1 | -2/+26 |
| | |||||
* | Replace 'Sidekiq::Testing.inline!' with 'perform_enqueued_jobs' | blackst0ne | 2018-07-23 | 1 | -1/+1 |
| | | | | | | | | | | `perform_enqueued_jobs` is a Sidekiq method. Using this method violates the Dependency inversion principle[0]. This commit replaces `perform_enqueued_jobs` with ActiveJob's abstract method `perform_enqueued_jobs` in specs. [0]: https://en.wikipedia.org/wiki/Dependency_inversion_principle | ||||
* | Resolve "Rename the `Master` role to `Maintainer`" Backend | Mark Chao | 2018-07-11 | 1 | -4/+4 |
| | |||||
* | Gitlab::Shell works on shard name, not path | Zeger-Jan van de Weg | 2018-04-25 | 1 | -8/+8 |
| | | | | | | | | | | | Direct disk access is done through Gitaly now, so the legacy path was deprecated. This path was used in Gitlab::Shell however. This required the refactoring in this commit. Added is the removal of direct path access on the project model, as that lookup wasn't needed anymore is most cases. Closes https://gitlab.com/gitlab-org/gitaly/issues/1111 | ||||
* | Resolve "Namespace factory is problematic" | Lin Jen-Shin | 2018-04-23 | 1 | -2/+5 |
| | |||||
* | Remove permanent redirects | Bob Van Landuyt | 2018-03-28 | 1 | -21/+21 |
| | | | | | Removes permanent redirects, this means that redirects will only be possible as long as the old route isn't taken by a new project/group. | ||||
* | Use hashed storage in the specs40744-hashed-storage-specs | Nick Thomas | 2018-02-07 | 1 | -3/+3 |
| | |||||
* | Validate User username only on Namespace, and bubble up appropriately | Douwe Maan | 2018-02-06 | 1 | -1/+1 |
| | |||||
* | 31885 - Ability to transfer a single group to another group | Mayra Cabrera | 2018-02-06 | 1 | -0/+414 |
| | |||||
* | Make Members with Owner and Master roles always able to create subgroups30473-allow-creation-of-subgroups-with-gitlab_default_can_create_group-set-to-false | Ruben Davila | 2017-09-07 | 1 | -5/+38 |
| | |||||
* | Refer to “Share with group lock” consistentlyimprove-share-locking-feature-for-subgroups | Michael Kozono | 2017-09-06 | 1 | -1/+1 |
| | |||||
* | Specify nested_groups specs | Michael Kozono | 2017-09-06 | 1 | -1/+1 |
| | |||||
* | Enforce share_with_group_lock rules | Michael Kozono | 2017-09-06 | 1 | -0/+34 |
| | | | | …in Groups::UpdateService instead of only in the browser. | ||||
* | Handle creating a nested group on MySQL correctlybvl-fix-mysql-bare-repository-importer | Bob Van Landuyt | 2017-08-25 | 1 | -26/+61 |
| | | | | | Since we don't support nested groups on MySQL, raise an error explaining that on import instead of trying anyway. | ||||
* | Add `:nested_groups` metadata to `Groups::NestedCreateService` specs | Robert Speicher | 2017-08-24 | 1 | -2/+2 |
| | |||||
* | Migrate creation of nested groups into a service | Bob Van Landuyt | 2017-08-23 | 1 | -0/+53 |
| | |||||
* | Add `:nested_groups` metadata to two subgroup-related specs | Robert Speicher | 2017-08-22 | 1 | -1/+1 |
| | | | | | | Prevents these from failing on MySQL. Closes #36811 and #36812. | ||||
* | Merge branch '35845-improve-subgroup-creation-permissions' into 'master' | Douwe Maan | 2017-08-22 | 1 | -1/+13 |
|\ | | | | | | | | | | | | | Improves subgroup creation permissions Closes #35845 See merge request !13418 | ||||
| * | Improves subgroup creation permissions35845-improve-subgroup-creation-permissions | Tiago Botelho | 2017-08-21 | 1 | -1/+13 |
| | | |||||
* | | Make sure repository's removal work for legacy and hashed storages28283-uuid-storage | Gabriel Mazetto | 2017-08-22 | 1 | -2/+24 |
|/ | |||||
* | Change all `:empty_project` to `:project`rs-empty_project-default | Robert Speicher | 2017-08-02 | 2 | -4/+4 |
| | |||||
* | Merge branch 'zj-delete-mm-team' into 'master' | Douwe Maan | 2017-07-28 | 1 | -0/+10 |
|\ | | | | | | | | | | | | | Remove Mattermost team with GitLab group Closes #30023 See merge request !11362 | ||||
| * | Remove Mattermost team with GitLab group | Z.J. van de Weg | 2017-07-28 | 1 | -0/+10 |
| | | | | | | | | | | | | | | When destroying a group, now an API call is made to the Mattermost server to request the deletion of the project. Actual team deletion on the Mattermost side happens async, so the runtime shouldn't increase by more than a second. | ||||
* | | Use described_class when possible | Rémy Coutable | 2017-07-27 | 1 | -1/+1 |
| | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
* | | Remove superfluous lib: true, type: redis, service: true, models: true, ↵ | Rémy Coutable | 2017-07-27 | 3 | -3/+3 |
|/ | | | | | | services: true, no_db: true, api: true Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
* | Defer project destroys within a namespace in ↵ | Stan Hu | 2017-06-29 | 1 | -20/+32 |
| | | | | | | | | | | | Groups::DestroyService#async_execute Group#destroy would actually hard-delete all associated projects even though the acts_as_paranoia gem is used, preventing Projects::DestroyService from doing any work. We first noticed this while trying to log all projects deletion to the Geo log. | ||||
* | Correct RSpec/SingleLineHook cop offenses | Robert Speicher | 2017-06-14 | 1 | -2/+6 |
| | |||||
* | add spec and changelogfix/orphan-notification-settings | James Lopez | 2017-04-19 | 1 | -0/+2 |
| | |||||
* | Merge branch 'jej-group-name-disclosure' into 'security' | Sean McGivern | 2017-03-29 | 1 | -0/+14 |
| | | | | | | Prevent private group disclosure via parent_id See merge request !2077 | ||||
* | Add a new `stub_mattermost_setting` stub helper to properly stub Mattermost ↵ | Rémy Coutable | 2017-03-28 | 1 | -1/+1 |
| | | | | | | settings Signed-off-by: Rémy Coutable <remy@rymai.me> | ||||
* | Use `:empty_project` where possible in service specs | Robert Speicher | 2017-03-27 | 2 | -4/+4 |
| | |||||
* | Merge branch 'master' into zj-create-mattermost-team | Z.J. van de Weg | 2017-03-02 | 1 | -0/+2 |
|\ | |||||
| * | Include nested group into destroy_service_specsh-async-delete-children | Dmitriy Zaporozhets | 2017-02-27 | 1 | -0/+2 |
| | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
* | | Improve UX | Z.J. van de Weg | 2017-03-02 | 1 | -6/+0 |
| | | |||||
* | | Fix tests | Z.J. van de Weg | 2017-02-24 | 1 | -1/+5 |
| | | |||||
* | | Merge branch 'master' into zj-create-mattermost-team | Z.J. van de Weg | 2017-02-20 | 1 | -3/+16 |
|\ \ | |/ | |||||
| * | Fix a number of race conditions that can occur during namespace deletionsh-namespace-cleanup-deleted-projects | Stan Hu | 2017-02-15 | 1 | -3/+16 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are two problems in the current implementation: 1. If a project is marked for deletion via the `pending_delete` flag and then the namespace was quickly deleted, it's possible that the namespace skips over that project and leaves that project in an orphaned state. 2. Before namespace deletion, the namespace attempts to clean up all the relevant storage paths. However, if all projects have been removed synchronously, then the namespace will not be able to clean anything. To prevent this, we should load the paths to be deleted before actually destroying projects. The specs were missing this second case due to a permission issue that caused project removal never to happen. | ||||
* | | Transactional mattermost team creation | Z.J. van de Weg | 2017-02-20 | 1 | -2/+9 |
| | | | | | | | | | | | | | | Before this commit, but still on this feature branch, the creation of mattermost teams where a background job. However, it was decided it was better that these happened as transaction so feedback could be displayed to the user. | ||||
* | | Add tests for Mattermost team creation | Z.J. van de Weg | 2017-02-16 | 1 | -4/+13 |
|/ | |||||
* | Fix inconsistent naming for services that delete things | dixpac | 2017-02-08 | 1 | -0/+98 |
| | | | | | | * Changed name of delete_user_service and worker to destroy * Move and change delete_group_service to Groups::DestroyService * Rename Notes::DeleteService to Notes::DestroyService | ||||
* | Use random group name to prevent conflicts | Douwe Maan | 2017-02-06 | 1 | -1/+1 |
| | |||||
* | Add nested groups support to the Groups::CreateService | Dmitriy Zaporozhets | 2016-12-26 | 1 | -4/+27 |
| | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com> | ||||
* | added more specs | James Lopez | 2016-12-21 | 1 | -2/+4 |
| | |||||
* | Fix error 500 renaming group. Also added specs and changelog. | James Lopez | 2016-12-20 | 1 | -7/+42 |
| | |||||
* | Update tests for the current_application_settings request store changes | DJ Mountney | 2016-05-27 | 1 | -1/+1 |
| | |||||
* | Enable RSpec/NotToNot cop and auto-correct offensesrs-rubocop-nottonot | Robert Speicher | 2016-05-24 | 1 | -1/+1 |
| | | | | Also removes the note from the development/testing.md guide | ||||
* | Fix specs | Douwe Maan | 2016-03-20 | 1 | -4/+7 |
| | |||||
* | Fix more specs | Douwe Maan | 2016-03-20 | 1 | -16/+14 |
| |