summaryrefslogtreecommitdiff
path: root/spec/services/issues
Commit message (Collapse)AuthorAgeFilesLines
* Enable the Layout/ExtraSpacing cop56392-enable-the-layout-extraspacing-copRémy Coutable2019-01-241-1/+1
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Remove caching of CSV file49231-import-issues-csvHeinrich Lee Yu2019-01-071-1/+1
| | | | Load whole file in memory to simplify code
* Improve email messagesHeinrich Lee Yu2019-01-071-7/+7
| | | | Also refactored cleanup view to use the same localized string
* Import CSV BackendHeinrich Lee Yu2019-01-071-0/+64
| | | | Process CSV uploads async using a worker then email results
* Delete confidential issue todos for guestsFelipe Artur2018-12-141-1/+1
| | | | | Fix leaking information of confidential issues on TODOs when user is downgraded to guest access.
* Extract code from Issues::MoveServicece-3777-promote-to-epicJarka Košanová2018-11-121-256/+12
| | | | | | | Extract code to make it easier reusable - introduce AttributesRewriter and ContentRewriter - support group entites when rewriting content - make Uploader copy_to working for Namespaces
* Add email for milestone changeChantal Rollison2018-11-021-2/+46
|
* Move issue related_branches to serviceFelipe Artur2018-10-041-0/+39
| | | | | Moves the related_branches method from Issue model to RelatedBranchesService
* Use ResourceLabelEvent for tracking label changesJan Provaznik2018-09-072-4/+16
|
* Only load issue notes once when getting related MRs43096-controller-projects-issuescontroller-referenced_merge_requests-json-executes-more-than-100-sql-queriesSean McGivern2018-08-211-0/+6
| | | | | | | As we always call both methods from the controller - and elsewhere we call the more general method - and one uses all notes and the other uses system notes, then we should just load the notes and their authors once, and filter on the Ruby side.
* Fix CI pipelines N+1 in Issues::ReferencedMergeRequestsServiceSean McGivern2018-08-211-0/+18
| | | | | | | | | Whether the preloading belongs in the service or the controller is arguable, here. As the service is only used for one controller action, it seems reasonable to put it in the service, but that is not a definitive answer. Adding the preloads for MR project routes here doesn't seem to work, perhaps because of https://github.com/rails/rails/issues/32140.
* Fix routes N+1 in Issues::ReferencedMergeRequestsService#executeSean McGivern2018-08-211-0/+13
| | | | | Sorting here needs the project routes to be loaded, including the namespace routes.
* Fix authors N+1 in Issues::ReferencedMergeRequestsServiceSean McGivern2018-08-211-1/+25
| | | | | | | | `#referenced_merge_requests` preloaded too many associations. Award emoji, for instance, are completely unnecessary here. `#closed_by_merge_requests` had the opposite problem: `#all_references` needs each item's author, and these weren't preloaded.
* Move Issue#{referenced,closed_by}_merge_requests to serviceSean McGivern2018-08-212-35/+72
| | | | | | | | These methods don't really need to be on the Issue model. Issue#related_branches can also be moved to a service, but we can do that in a separate commit. This commit does not change any behaviour; it just moves code around, renames the service, and refactors the specs.
* Merge branch 'issue_44821' into 'master'Sean McGivern2018-08-061-1/+1
|\ | | | | | | | | | | | | Retrieve merge request closing issues from database cache Closes #44821 See merge request gitlab-org/gitlab-ce!20911
| * Retrieve merge request closing issues from database cacheFelipe Artur2018-08-061-1/+1
| |
* | Delete todos when users loses target read permissionsJarka Kadlecová2018-07-301-0/+17
|/
* Resolve "Rename the `Master` role to `Maintainer`" BackendMark Chao2018-07-114-12/+12
|
* Updates from `rubocop -a`Lin Jen-Shin2018-07-091-2/+2
|
* Keep label on issue when movingChantal Rollison2018-06-271-3/+23
|
* Add a cop for `FinderMethods`bvl-finder-methods-copBob Van Landuyt2018-06-201-3/+1
| | | | | | | This notifies developers when calling `find(_by!)` chained on `execute`. And suggests using the methods from `FinderMethods`. These will perform the correct authorization checks on the resource when it is found.
* Resolve "Update `updated_at` on an issue/mr on every issue/mr changes"🙈 jacopo beschi 🙉2018-06-011-1/+7
|
* Improve specs and docsFelipe Artur2018-04-051-2/+4
|
* Merge branch 'issue_44551' into 'master'Sean McGivern2018-04-051-0/+31
|\ | | | | | | | | | | | | Fix 404 in group boards when moving issue between lists Closes #44551 See merge request gitlab-org/gitlab-ce!18064
| * Fix 404 in group boards when moving issue between listsissue_44551Felipe Artur2018-04-031-0/+31
| |
* | Merge branch '41967_issue_api_closed_by_info' into 'master'Sean McGivern2018-03-301-0/+4
|\ \ | |/ |/| | | | | Add closed by information to issue API See merge request gitlab-org/gitlab-ce!17042
| * added forign key and specshaseeb2018-02-281-0/+4
| |
* | Merge remote-tracking branch 'origin/master' into ↵object-storage-ee-to-ce-backportKamil Trzciński2018-02-282-0/+57
|\ \ | |/ | | | | object-storage-ee-to-ce-backport
| * Remember assignee when moving an issue41949-moveJan Provaznik2018-02-181-0/+22
| | | | | | | | Related to #41949
| * Merge branch '26466-natural-sort-mrs' into 'master'Sean McGivern2018-02-131-0/+35
| |\ | | | | | | | | | | | | | | | | | | Group MR numbers on issue show page by project and namespace Closes #26466 See merge request gitlab-org/gitlab-ce!8494
| | * Change issue show page to group MRs by projects and namespacesJeff Stubler2018-02-131-0/+35
| | | | | | | | | | | | Closes #26466.
* | | Merge commit '8af23def1d6' into object-storage-ee-to-ce-backportKamil Trzciński2018-02-283-6/+15
|\ \ \
| * | | Revert "Merge branch '3867-port-to-ce' into 'master'"Kamil Trzciński2018-02-281-2/+2
| |/ / | | | | | | | | | | | | This reverts commit 54a575f1bbba44573ab92dc58a4242f1ee734c5d, reversing changes made to c63af942e5baf7849a94fa99da8494bcba28e3f8.
| * | port of 594e6a0a625^..f74c90f68c6Micaël Bergeron2018-02-011-2/+2
| | |
| * | Make user/author use project.creator in most factoriesRémy Coutable2018-01-312-2/+3
| |/ | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
| * Execute system hooks after-commit when executing project hooksdm-project-system-hooks-in-transactionDouwe Maan2018-01-241-1/+3
| |
| * Fix bug where award emojis would be lost when moving issues between projectssh-fix-award-emoji-move-issuesStan Hu2018-01-101-3/+9
| | | | | | | | Closes #33423
* | Merge branch '4163-move-uploads-to-object-storage' into 'master'Sean McGivern2018-02-281-1/+1
|/ | | | | | | | Move uploads to object storage Closes #4163 See merge request gitlab-org/gitlab-ee!3867
* Merge branch '36782-replace-team-user-role-with-add_role-user-in-specs' into ↵Rémy Coutable2017-12-237-30/+30
|\ | | | | | | | | | | | | | | | | 'master' Resolve "Replace '.team << [user, role]' with 'add_role(user)' in specs" Closes #36782 See merge request gitlab-org/gitlab-ce!16069
| * Replace '.team << [user, role]' with 'add_role(user)' in specs36782-replace-team-user-role-with-add_role-user-in-specsblackst0ne2017-12-227-30/+30
| |
* | Execute project hooks and services after commit when moving an issuedm-issue-move-transaction-errorDouwe Maan2017-12-221-0/+12
|/
* Don't create todos for old issue assigneesJarka Kadlecova2017-10-091-0/+24
|
* Merge remote-tracking branch 'origin/master' into 18608-lock-issuesLuke "Jared" Bennett2017-09-203-2/+9
|\
| * Fix refreshing of issues/MR count cachesfix-counts-cachingYorick Peterse2017-09-193-2/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This ensures the open issues/MR count caches are refreshed properly when creating new issues or MRs. This MR also includes a change to the cache keys to ensure all caches are rebuilt on the fly. This particular problem was not caught in the test suite due to a null cache being used, resulting in all calls that would use a cache using the underlying data directly. In production the code would fail because a newly saved record returns an empty hash in #changes meaning checks such as `state_changed? || confidential_changed?` would return false for new rows, thus never updating the counters. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/38061
* | Create system notes for MR too, improve doc + clean up codeJarka Kadlecova2017-09-141-0/+7
| |
* | Support discussion locking in the backendJarka Kadlecova2017-09-141-1/+4
|/
* Merge branch 'master' of gitlab.com:gitlab-org/gitlab-ce into ↵Simon Knox2017-09-062-2/+22
|\ | | | | | | ee_issue_928_backport
| * Fix a spec failure dependent on load orderrs-fix-masterRobert Speicher2017-09-011-1/+1
| | | | | | | | | | | | We were incorrectly stubbing `Issues::MoveService#execute`. This only caused a failure when another spec caused it to be autoloaded -- `spec/controllers/projects/issues_controller_spec.rb` in this case.
| * Merge branch 'move-action' into 'master'Sean McGivern2017-09-011-0/+20
| |\ | | | | | | | | | | | | Merge request to address /move functionality. See merge request !13436
| | * /move project functionality. Squash commit.Manolis Mavrofidis2017-08-311-0/+20
| | | | | | | | | | | | | | | Update to add all issues to be updated. Added functionality, proper tests, documentation and changelog.