summaryrefslogtreecommitdiff
path: root/spec/services/issues
Commit message (Collapse)AuthorAgeFilesLines
* Native group milestonesFelipe Artur2017-07-072-11/+60
|
* Enable Style/DotPosition Rubocop :cop:Grzegorz Bizon2017-06-211-8/+8
|
* Rename "Slash commands" to "Quick actions"Eric Eastwood2017-06-151-2/+2
| | | | | | | | | | | | | Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/27070 Deprecate "chat commands" in favor of "slash commands" We looked for things like: - `slash commmand` - `slash_command` - `slash-command` - `SlashCommand`
* Correct RSpec/SingleLineHook cop offensesRobert Speicher2017-06-143-7/+23
|
* Only add a description change note when no tasks are updatedJared Deckard2017-06-121-5/+22
|
* Fix counters cache invalidation for Issues and Merge RequestsValery Sizov2017-05-262-0/+13
|
* [Spec optimization] Joining one-line 'it' blocksspec-joining-itValery Sizov2017-05-151-5/+9
|
* Move update_assignee_cache_counts to the serviceValery Sizov2017-05-122-0/+23
|
* Enable the Style/TrailingCommaInArguments copRémy Coutable2017-05-102-2/+2
| | | | | | Use the EnforcedStyleForMultiline: no_comma option. Signed-off-by: Rémy Coutable <remy@rymai.me>
* Merge branch 'blackst0ne/gitlab-ce-add_system_note_for_editing_issuable'Sean McGivern2017-05-051-0/+11
|\
| * Updated specsblackst0ne2017-05-051-0/+11
| |
* | Multiple issue assignee: fix for CE restrictionsValery Sizov2017-05-051-2/+2
| |
* | Backport of multiple_assignees_feature [ci skip]Valery Sizov2017-05-043-19/+128
|/
* Enable RSpec/FilePath copenable-spec-file-name-copSean McGivern2017-04-261-12/+12
| | | | | | - Ignore JS fixtures - Ignore qa directory - Rewrite concern specs to put concern name first
* Fix specsDouwe Maan2017-04-051-4/+2
|
* Add specsDouwe Maan2017-04-052-4/+4
|
* Add option to start a new discussion on an MRDouwe Maan2017-04-052-3/+3
|
* Create todos only for new mentionsJarka Kadlecova2017-03-291-1/+10
|
* Use `:empty_project` where possible in service specsRobert Speicher2017-03-273-4/+4
|
* Rename variableBob Van Landuyt2017-03-133-18/+18
| | | | | merge_request_for_resolving_discussions -> merge_request_to_resolve_discussions_of
* Make sure the for a merge request only gets executed once.Bob Van Landuyt2017-03-131-0/+19
|
* Correctly indent quotes in new issue descriptionBob Van Landuyt2017-03-131-4/+4
| | | | | | By using `>`-quote style instead of `>>>`. Also: Update documentation images.
* Move functionality for resolving discussions into a concernBob Van Landuyt2017-03-131-3/+12
|
* Always require MR-iid for resolving discussionsBob Van Landuyt2017-03-133-75/+38
| | | | | And deduplicate the finding of MR's & discussions. Now the searching is done in the service, istead of the controller & the API.
* Delegate a single discussion to a new issueBob Van Landuyt2017-03-133-36/+200
| | | | | | Delegate a discussion in a merge request into a new issue. The discussion wil be marked as resolved and a system note will be added linking to the newly created issue.
* Address review commentsValery Sizov2017-03-071-2/+2
|
* Satisfy rubocopValery Sizov2017-03-021-1/+1
|
* [Issue board sorting] SpecsValery Sizov2017-02-281-0/+16
|
* Spam check and reCAPTCHA improvements28093-snippet-and-issue-spam-check-on-editOswaldo Ferreira2017-02-211-10/+0
|
* fix issue creation from milestone doesn't assign the milestonewendy04022017-02-122-1/+11
|
* Use reCaptcha when an issue identified as spamJarka Kadlecova2017-02-071-0/+102
|
* Check if user can read issue before being assignedissue_22664Felipe Artur2016-12-272-0/+13
|
* Ensure issuable state changes only fire webhooks onceMark Fletcher2016-12-161-0/+5
| | | | | * Webhooks for close and reopen events now fired in respective services only * Prevents generic 'update' webhooks firing too
* Merge branch '23589-open-issue-for-mr' into 'master' Sean McGivern2016-12-062-0/+173
|\ | | | | | | | | Create an issue for all unresolved discussions in an MR See merge request !7180
| * Feature: delegate all open discussions to IssueBob Van Landuyt2016-12-052-0/+173
| | | | | | | | | | | | | | | | | | | | | | | | | | When a merge request can only be merged when all discussions are resolved. This feature allows to easily delegate those discussions to a new issue, while marking them as resolved in the merge request. The user is presented with a new issue, prepared with mentions of all unresolved discussions, including the first unresolved note of the discussion, time and link to the note. When the issue is created, the discussions in the merge request will get a system note directing the user to the newly created issue.
* | Add shorthand support to gitlab markdown referencesOswaldo Ferreira2016-12-021-2/+2
|/
* Only include EmailHelpers in mailer specs and specs using themrs-include-emailhelpersRobert Speicher2016-12-011-0/+2
|
* Rephrase some system notes to be compatible with new system note stylerephrase-system-notesDouwe Maan2016-11-243-18/+18
|
* Remove default value for `project` argument on subscribable concernDouglas Barbosa Alexandre2016-11-171-1/+1
|
* Process commits in a separate workerprocess-commits-using-sidekiqYorick Peterse2016-11-071-16/+33
| | | | | | | | | | | | | This moves the code used for processing commits from GitPushService to its own Sidekiq worker: ProcessCommitWorker. Using a Sidekiq worker allows us to process multiple commits in parallel. This in turn will lead to issues being closed faster and cross references being created faster. Furthermore by isolating this code into a separate class it's easier to test and maintain the code. The new worker also ensures it can efficiently check which issues can be closed, without having to run numerous SQL queries for every issue.
* Merge branch '23662-issue-move-user-reference-exception' into 'master' Douwe Maan2016-10-251-2/+12
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix `User#to_reference` ## What does this MR do? Fix the method signature of `User#to_reference` so that moving an issue with a user reference does not throw a "invalid number of arguments" exception. ## Why was this MR needed? 1. Changes in 8.13 require `Referable`s that don't have a project reference to accept two arguments - `from_project` and `target_project`. 2. `User#to_reference` was not changed to accept the `target_project` (even though it is not used). Moving an issue containing a user reference would throw a "invalid number of arguments" exception. 3. The regression was introduced in [c8b2b3f7](https://gitlab.com/gitlab-org/gitlab-ce/commit/c8b2b3f7c32db873f1bebce3e3b1847ea24d235f#91fabb7ad88bd2fde6fef1c100a719c00e503047_75_79), which expects all `Referable`s that don't respond to `:project` to have a `to_reference` method that takes two arguments. ## Does this MR meet the acceptance criteria? - Tests - [x] Added for this feature/bug - [ ] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? - Closes #23662 See merge request !7088
| * Fix `User#to_reference`23662-issue-move-user-reference-exceptionTimothy Andrew2016-10-251-2/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | 1. Changes in 8.13 require `Referable`s that don't have a project reference to accept two arguments - `from_project` and `target_project`. 2. `User#to_reference` was not changed to accept the `target_project` (even though it is not used). Moving an issue containing a user reference would throw a "invalid number of arguments" exception. Fixes #23662
* | Fix Rubocop offenses in issue move specsGrzegorz Bizon2016-10-241-3/+3
| |
* | Add spec in Issues::MoveService to fix label assignment regressionStan Hu2016-10-241-5/+26
|/
* Allow users to apply group labels on Issues/MRsDouglas Barbosa Alexandre2016-10-191-0/+21
|
* Fix permission for setting an issue's due dateRémy Coutable2016-09-282-41/+92
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Add bulk update support for merge requests listDmitriy Zaporozhets2016-09-081-282/+0
| | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* Scope hooks thal will run for confidential issuesDouglas Barbosa Alexandre2016-08-314-17/+49
|
* Update service specs to avoid instance variablesDouglas Barbosa Alexandre2016-08-313-40/+40
|
* Fix confidential issues should not be passed to WebhooksDouglas Barbosa Alexandre2016-08-314-22/+75
|