summaryrefslogtreecommitdiff
path: root/spec/services/issues
Commit message (Collapse)AuthorAgeFilesLines
* Add latest changes from gitlab-org/gitlab@12-4-stable-eeGitLab Bot2019-10-224-40/+74
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-09-171-1/+0
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-09-141-0/+243
|
* Add latest changes from gitlab-org/gitlab@masterGitLab Bot2019-09-131-0/+6
|
* Merge branch 'security-hide_merge_request_ids_on_emails' into 'master'GitLab Release Tools Bot2019-08-291-6/+34
|\ | | | | | | | | Prevent disclosure of merge request id via email See merge request gitlab/gitlabhq!3313
| * Prevent disclosure of merge request id via emailFelipe Artur2019-08-191-6/+34
| | | | | | | | | | Do not disclosure merge request id via email for unauthorized users when closing issues.
* | Improve system notes for Zoom links65427-improve-system-notes-for-zoom-linksJacopo2019-08-171-2/+2
|/ | | | | | | changes: @user a Zoom call was added to this issue into: @user added a Zoom call to this issue Same concept appleis for "removed"
* Merge branch ↵Robert Speicher2019-07-291-0/+9
|\ | | | | | | | | | | | | | | | | '63547-add-system-notes-for-when-a-zoom-call-was-added-removed-from-an-issue' into 'master' Resolve "Add system notes for when a zoom call was added/removed from an issue" Closes #63547 See merge request gitlab-org/gitlab-ce!30857
| * Add system notes for when a zoom call was added/removed from an issue63547-add-system-notes-for-when-a-zoom-call-was-added-removed-from-an-issueJacopo2019-07-291-0/+9
| | | | | | | | | | Add a zoom link added / removed system note when a zoom link is being added / removed to the issue description.
* | Remove code related to object hierarchy in MySQLremove-nested-groups-checksHeinrich Lee Yu2019-07-251-2/+2
| | | | | | | | | | These are not required because MySQL is not supported anymore
* | Prefer `flat_map` over `map` + `flatten` in specsPeter Leitzen2019-07-241-1/+1
|/ | | | | Although `flat_map` is equivalent to `map` + `flatten(1)` (note the level 1) we can apply this same refactoring to all cases.
* Skip spam check for task list updatesFelipe Artur2019-07-091-0/+16
| | | | Task list updates should not mark users action as spam on akismet.
* Add reorder action to Project IssuesControllerbw-issue-reorderBrett Walker2019-06-212-0/+104
| | | | to support manual sorting on the frontend
* Include MR information if possible when emailing notification of closing an ↵Michał Zając2019-05-161-5/+39
| | | | issue
* Add frozen_string_literal to spec/servicesfrozen_string_literal_spec_servicesThong Kuah2019-04-129-0/+18
| | | | Probably useful as we often move these files to "new" files.
* Fenced blockquotes to not change source line pos58717-checkbox-cannot-be-checked-if-a-blockquote-is-aboveBrett Walker2019-04-041-1/+3
| | | | | Replaces blockquote fences with \n, keeping the line numbering intact.
* add a uniq constraints on issues and mrs labelsAntoine Huret2019-04-012-0/+24
|
* Check issue milestone availabilityJarka Košanová2019-02-142-41/+41
| | | | | | | | | | Add project when creating milestone in specs We validate milestone is from the same project/parent group as issuable -> we need to set project in specs correctly Improve methods names and specs organization
* Enable fast task lists for merge requestsBrett Walker2019-02-071-70/+2
| | | | Allow single tasks to be updated quickly
* Added changelog and danger fixesBrett Walker2019-01-301-4/+4
|
* Specs for Issue::UpdateServiceBrett Walker2019-01-301-0/+70
|
* Enable the Layout/ExtraSpacing cop56392-enable-the-layout-extraspacing-copRémy Coutable2019-01-241-1/+1
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Remove caching of CSV file49231-import-issues-csvHeinrich Lee Yu2019-01-071-1/+1
| | | | Load whole file in memory to simplify code
* Improve email messagesHeinrich Lee Yu2019-01-071-7/+7
| | | | Also refactored cleanup view to use the same localized string
* Import CSV BackendHeinrich Lee Yu2019-01-071-0/+64
| | | | Process CSV uploads async using a worker then email results
* Delete confidential issue todos for guestsFelipe Artur2018-12-141-1/+1
| | | | | Fix leaking information of confidential issues on TODOs when user is downgraded to guest access.
* Extract code from Issues::MoveServicece-3777-promote-to-epicJarka Košanová2018-11-121-256/+12
| | | | | | | Extract code to make it easier reusable - introduce AttributesRewriter and ContentRewriter - support group entites when rewriting content - make Uploader copy_to working for Namespaces
* Add email for milestone changeChantal Rollison2018-11-021-2/+46
|
* Move issue related_branches to serviceFelipe Artur2018-10-041-0/+39
| | | | | Moves the related_branches method from Issue model to RelatedBranchesService
* Use ResourceLabelEvent for tracking label changesJan Provaznik2018-09-072-4/+16
|
* Only load issue notes once when getting related MRs43096-controller-projects-issuescontroller-referenced_merge_requests-json-executes-more-than-100-sql-queriesSean McGivern2018-08-211-0/+6
| | | | | | | As we always call both methods from the controller - and elsewhere we call the more general method - and one uses all notes and the other uses system notes, then we should just load the notes and their authors once, and filter on the Ruby side.
* Fix CI pipelines N+1 in Issues::ReferencedMergeRequestsServiceSean McGivern2018-08-211-0/+18
| | | | | | | | | Whether the preloading belongs in the service or the controller is arguable, here. As the service is only used for one controller action, it seems reasonable to put it in the service, but that is not a definitive answer. Adding the preloads for MR project routes here doesn't seem to work, perhaps because of https://github.com/rails/rails/issues/32140.
* Fix routes N+1 in Issues::ReferencedMergeRequestsService#executeSean McGivern2018-08-211-0/+13
| | | | | Sorting here needs the project routes to be loaded, including the namespace routes.
* Fix authors N+1 in Issues::ReferencedMergeRequestsServiceSean McGivern2018-08-211-1/+25
| | | | | | | | `#referenced_merge_requests` preloaded too many associations. Award emoji, for instance, are completely unnecessary here. `#closed_by_merge_requests` had the opposite problem: `#all_references` needs each item's author, and these weren't preloaded.
* Move Issue#{referenced,closed_by}_merge_requests to serviceSean McGivern2018-08-212-35/+72
| | | | | | | | These methods don't really need to be on the Issue model. Issue#related_branches can also be moved to a service, but we can do that in a separate commit. This commit does not change any behaviour; it just moves code around, renames the service, and refactors the specs.
* Merge branch 'issue_44821' into 'master'Sean McGivern2018-08-061-1/+1
|\ | | | | | | | | | | | | Retrieve merge request closing issues from database cache Closes #44821 See merge request gitlab-org/gitlab-ce!20911
| * Retrieve merge request closing issues from database cacheFelipe Artur2018-08-061-1/+1
| |
* | Delete todos when users loses target read permissionsJarka Kadlecová2018-07-301-0/+17
|/
* Resolve "Rename the `Master` role to `Maintainer`" BackendMark Chao2018-07-114-12/+12
|
* Updates from `rubocop -a`Lin Jen-Shin2018-07-091-2/+2
|
* Keep label on issue when movingChantal Rollison2018-06-271-3/+23
|
* Add a cop for `FinderMethods`bvl-finder-methods-copBob Van Landuyt2018-06-201-3/+1
| | | | | | | This notifies developers when calling `find(_by!)` chained on `execute`. And suggests using the methods from `FinderMethods`. These will perform the correct authorization checks on the resource when it is found.
* Resolve "Update `updated_at` on an issue/mr on every issue/mr changes"🙈 jacopo beschi 🙉2018-06-011-1/+7
|
* Improve specs and docsFelipe Artur2018-04-051-2/+4
|
* Merge branch 'issue_44551' into 'master'Sean McGivern2018-04-051-0/+31
|\ | | | | | | | | | | | | Fix 404 in group boards when moving issue between lists Closes #44551 See merge request gitlab-org/gitlab-ce!18064
| * Fix 404 in group boards when moving issue between listsissue_44551Felipe Artur2018-04-031-0/+31
| |
* | Merge branch '41967_issue_api_closed_by_info' into 'master'Sean McGivern2018-03-301-0/+4
|\ \ | |/ |/| | | | | Add closed by information to issue API See merge request gitlab-org/gitlab-ce!17042
| * added forign key and specshaseeb2018-02-281-0/+4
| |
* | Merge remote-tracking branch 'origin/master' into ↵object-storage-ee-to-ce-backportKamil Trzciński2018-02-282-0/+57
|\ \ | |/ | | | | object-storage-ee-to-ce-backport
| * Remember assignee when moving an issue41949-moveJan Provaznik2018-02-181-0/+22
| | | | | | | | Related to #41949