summaryrefslogtreecommitdiff
path: root/spec/services/notes
Commit message (Collapse)AuthorAgeFilesLines
* Move some quick actions feature specs to unit testsFelipe Artur2019-06-181-49/+98
| | | | | Move some feature specs for issues/merge requests quick actions to unit tests. They are taking too long to run on the pipelines.
* Add frozen_string_literal to spec/servicesfrozen_string_literal_spec_servicesThong Kuah2019-04-128-0/+16
| | | | Probably useful as we often move these files to "new" files.
* Merge branch 'port-6539-extract-ee-specific-code' into 'master'Robert Speicher2019-04-051-0/+1
|\ | | | | | | | | Extract EE specific files/lines for quick actions tests See merge request gitlab-org/gitlab-ce!26872
| * Extract EE specific files/lines for quick actions testsport-6539-extract-ee-specific-codeAlexandru Croitor2019-04-031-0/+1
| |
* | Remove reply_to_individual_notes feature flag58644-remove-reply_to_individual_notes-feature-flagHeinrich Lee Yu2019-04-032-58/+19
|/ | | | Also removes specs related to the flag
* Show commands applied message when promoting issuesFelipe Artur2019-03-042-12/+25
| | | | | Fix 'commands applied' messages not being shown when issue is promoted to epic using slash commands.
* Fix polling for transformed individual notes30299-fix-polling-for-transformed-notesHeinrich Lee Yu2019-02-131-1/+8
| | | | | Sets `updated_at` so that the transformed note is returned together with the new reply
* Add reply to notes to turn into discussionsHeinrich Lee Yu2019-02-062-0/+77
|
* Prevent comments by email when issue is lockedHeinrich Lee Yu2019-01-312-0/+13
| | | | | | | | | This changes the permission check so it uses the policy on Noteable instead of Project. This prevents bypassing of rules defined in Noteable for locked discussions and confidential issues. Also rechecks permissions when reply_to_discussion_id is provided since the discussion_id may be from a different noteable.
* Allow suggesting single line changes in diffsOswaldo Ferreira2018-12-131-0/+23
|
* Comment on any expanded diff line on MRsosw-comment-on-any-line-on-diffs-w-feature-flagOswaldo Ferreira2018-11-092-0/+84
|
* Revert "Merge branch 'osw-comment-on-any-line-on-diffs' into 'master'"osw-revert-comment-in-any-diff-lineOswaldo Ferreira2018-11-072-84/+0
| | | | | This reverts commit a82a595728d54bdc12e51dfcfb22e9eddc449143, reversing changes made to e7df959b8f99875edd246c7ac7779c3203e8755e.
* Merge branch 'osw-comment-on-any-line-on-diffs' into 'master'Douwe Maan2018-11-072-0/+84
|\ | | | | | | | | Comment on any expanded diff line on MRs See merge request gitlab-org/gitlab-ce!22398
| * Comment on any expanded diff line on MRsOswaldo Ferreira2018-11-062-0/+84
| |
* | Fix spec in EE which now trigger access to repositoryMark Chao2018-11-071-1/+1
|/
* Auto resolve new notes of resolved discussionsPaul Slaughter2018-09-241-0/+15
| | | | | | | | | | | | | | **Why?** The previous behavior had resolved discussions being unresolved when commented on. This was strange UX, especially since there is a separate button for "Comment & unresolve discussion". https://gitlab.com/gitlab-org/gitlab-ce/issues/24128 **Note:** - Also adds changelog
* Rename Commits::UpdateService to Commits::TagServicePeter Leitzen2018-08-101-2/+2
|
* Commit notes now support quick actionsPeter Leitzen2018-08-101-42/+4
|
* Convert use of any_instance as it does not work with prependMark Chao2018-08-071-1/+3
|
* Resolve "Rename the `Master` role to `Maintainer`" BackendMark Chao2018-07-114-13/+13
|
* Persist truncated note diffs on a new table45190-create-notes-diff-filesOswaldo Ferreira2018-05-241-0/+82
| | | | | We request Gitaly in a N+1 manner to build discussion diffs. Once the diffs are from different revisions, it's hard to make a single request to the service in order to build the whole response. With this change we solve this problem and simplify a lot fetching this piece of info.
* Merge request and commit discussions APIJan Provaznik2018-05-011-0/+23
|
* Support Markdown rendering using multiple projectsrendering-markdown-multiple-projectsYorick Peterse2018-04-111-10/+15
| | | | | | | | | | | | | | | | | | | This refactors the Markdown pipeline so it supports the rendering of multiple documents that may belong to different projects. An example of where this happens is when displaying the event feed of a group. In this case we retrieve events for all projects in the group. Previously we would group events per project and render these chunks separately, but this would result in many SQL queries being executed. By extending the Markdown pipeline to support this out of the box we can drastically reduce the number of SQL queries. To achieve this we introduce a new object to the pipeline: Banzai::RenderContext. This object simply wraps two other objects: an optional Project instance, and an optional User instance. On its own this wouldn't be very helpful, but a RenderContext can also be used to associate HTML documents with specific Project instances. This work is done in Banzai::ObjectRenderer and allows us to reuse as many queries (and results) as possible.
* Merge branch 'jej/mattermost-notification-confidentiality-10-6' into ↵Douwe Maan2018-04-051-0/+18
| | | | | | | | | | 'security-10-6' [10.6] Prevent notes on confidential issues from being sent to chat See merge request gitlab/gitlabhq!2366 # Conflicts: # app/helpers/services_helper.rb
* Fix quick actions for users who cannot update issues and MRs43334-reply-by-email-did-not-pick-up-unsubscribe-quick-actionSean McGivern2018-03-022-36/+45
| | | | | | There are several quick actions now that don't need this access - /todo and /unsubscribe for instance - but when these were first added, there weren't. Quick actions are now responsible for checking their own permissions.
* Replace '.team << [user, role]' with 'add_role(user)' in specs36782-replace-team-user-role-with-add_role-user-in-specsblackst0ne2017-12-224-10/+10
|
* Reset todo counters when the target is deleted40871-todo-notification-count-shows-notification-without-having-a-todoSean McGivern2017-12-181-3/+13
| | | | | | When the target is deleted, todos are destroyed, but we did not reset the todo cache for users with todos on the deleted target. This would only update after the next time the todo cache was updated for that user.
* Resolve "DashboardController#activity.json is slow due to SQL"Francisco Javier López2017-11-061-0/+31
|
* Change all `:empty_project` to `:project`rs-empty_project-defaultRobert Speicher2017-08-025-6/+6
|
* Use described_class when possibleRémy Coutable2017-07-271-1/+1
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Remove superfluous lib: true, type: redis, service: true, models: true, ↵Rémy Coutable2017-07-276-6/+6
| | | | | | services: true, no_db: true, api: true Signed-off-by: Rémy Coutable <remy@rymai.me>
* Rename "Slash commands" to "Quick actions"Eric Eastwood2017-06-151-6/+6
| | | | | | | | | | | | | Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/27070 Deprecate "chat commands" in favor of "slash commands" We looked for things like: - `slash commmand` - `slash_command` - `slash-command` - `SlashCommand`
* Correct RSpec/SingleLineHook cop offensesRobert Speicher2017-06-141-1/+3
|
* Update diff discussion position per discussion instead of per notedm-update-discussion-diff-positionDouwe Maan2017-05-311-193/+0
|
* Add system note with link to diff comparison when MR discussion becomes outdatedDouwe Maan2017-05-231-1/+19
|
* Merge branch 'mia_backort' into 'master' Jacob Schatz2017-05-051-2/+29
|\ | | | | | | | | Backport of Multiple Assignees feature See merge request !11089
| * Address static analyzer warningmia_backortValery Sizov2017-05-051-1/+1
| |
| * Multiple issue assignee: CE restriction for multiple assigneesValery Sizov2017-05-051-0/+27
| |
| * Backport of multiple_assignees_feature [ci skip]Valery Sizov2017-05-041-2/+2
| |
* | Support comments for personal snippetsJarka Kadlecova2017-05-051-1/+73
|/
* Don't use original_discussion_idDouwe Maan2017-04-051-1/+1
|
* Add specsDouwe Maan2017-04-052-5/+37
|
* Add option to start a new discussion on an MRDouwe Maan2017-04-052-0/+8
|
* Create todos only for new mentionsJarka Kadlecova2017-03-291-3/+13
|
* Use `:empty_project` where possible in service specsRobert Speicher2017-03-271-1/+1
|
* add /award slash commandmhasbini2017-02-281-39/+11
| | | | add /award slash command; Allow posting of just an emoji in comment
* Fix inconsistent naming for services that delete thingsdixpac2017-02-081-1/+1
| | | | | | * Changed name of delete_user_service and worker to destroy * Move and change delete_group_service to Groups::DestroyService * Rename Notes::DeleteService to Notes::DestroyService
* address commentsJarka Kadlecova2017-01-251-9/+9
|
* Support notes without projectJarka Kadlecova2017-01-181-4/+31
|
* Merge branch 'backport-time-tracking-ce' into 'master' Douwe Maan2017-01-181-0/+12
|\ | | | | | | | | Backport timetracking to CE See merge request !8195