summaryrefslogtreecommitdiff
path: root/spec/support/stub_env.rb
Commit message (Collapse)AuthorAgeFilesLines
* `current_application_settings` belongs on `Gitlab::CurrentSettings`Sean McGivern2017-08-311-0/+2
| | | | | | | | | | | | | | | | The initializers including this were doing so at the top level, so every object loaded after them had a `current_application_settings` method. However, if someone had rack-attack enabled (which was loaded before these initializers), it would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't have that method. To fix this: 1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need `Object.new.current_application_settings` to work. 2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it like that in several places. 3. Change the initializers to use that new form.
* Use a slightly cleaner approach to stub ENVrc/a-better-stub-envRémy Coutable2017-06-281-9/+27
| | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* Reset the state of StubENV's @env_already_stubbed after each spec runsh-unset-stubenvStan Hu2017-06-261-0/+8
| | | | | In certain combination of tests, @env_already_stubbed could be set to `true` even though it never ran for that specific test.
* Introduce "stub_env" test helper for safely stubbing environment variablesAdam Niedzielski2017-01-091-0/+7