| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a minimum interval to BackgroundMigrationWorker, ensuring
background migrations of the same class only run once every 5 minutes.
This prevents a thundering herd problem where scheduled migrations all
run at once due to their delays having been expired (e.g. as the result
of a queue being paused for a long time).
If a job was recently executed it's rescheduled with a delay that equals
the remaining time of the job's lease. This means that if the lease
expires in two minutes we only need to wait two minutes, instead of
five.
Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/41624
|
| | |
|
| |\
| |
| |
| |
| |
| |
| |
| |
| | |
'39246-fork-and-import-jobs-should-only-be-marked-as-failed-when-the-number-of-retries-was-exhausted' into 'master'
Fork and Import jobs only get marked as failed when the number of Sidekiq retries were exhausted
Closes #39246
See merge request gitlab-org/gitlab-ce!15844
|
| | |
| |
| |
| | |
retries were exhausted
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
Add button to run scheduled pipeline immediately
Closes #38741
See merge request gitlab-org/gitlab-ce!15700
|
| | | | |
|
| | |/
| |
| |
| | |
Closes #38741
|
| |\ \
| | |
| | |
| | |
| | | |
Use a dedicated queue for each Sidekiq worker
See merge request gitlab-org/gitlab-ce!15882
|
| | | |
| | |
| | |
| | | |
manually set their queue
|
| | |/ |
|
| |/ |
|
| | |
|
| |\
| |
| |
| |
| | |
Multiple artifacts
See merge request gitlab-org/gitlab-ce!14367
|
| | | |
|
| | |
| |
| |
| | |
This reverts commit 714082e65304ae2ec5c5400c59a68ab63e724aa9.
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Two things at ones, as there was no clean way to seperate the commit and
give me feedback from the tests.
But the model Artifact is now JobArtifact, and the table does not have a
type anymore, but the metadata is now its own model:
Ci::JobArtifactMetadata.
|
| | | |
|
| | | |
|
| |/
|
|
| |
Note the dependency on gitlab-shell v5.10.0
|
| |\
| |
| |
| | |
* master: (1794 commits)
|
| | |\
| | |
| | |
| | |
| | | |
Copy `KubernetesService` logic in `Clusters::Platforms::Kubernetes` to make it interchangeable. And implement a selector.
See merge request gitlab-org/gitlab-ce!15515
|
| | | | |
|
| | | |
| | |
| | |
| | | |
Platform::Kubernetes"
|
| | | | |
|
| | | | |
|
| | |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
'38962-automatically-run-a-pipeline-when-auto-devops-is-turned-on-in-project-settings' into 'master'
Add checkbox to automatically run a pipeline when Auto DevOps is turned on in project settings
Closes #38962
See merge request gitlab-org/gitlab-ce!15380
|
| | | |/
| | |
| | |
| | | |
Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/38962
|
| | |\ \
| | |/
| |/|
| | |
| | | |
Hashed storage attachments migration path
See merge request gitlab-org/gitlab-ce!15352
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | |/ |
|
| | | |
|
| | |
| |
| |
| | |
this is to try to debug #35914
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Prior to this MR there were two GitHub related importers:
* Github::Import: the main importer used for GitHub projects
* Gitlab::GithubImport: importer that's somewhat confusingly used for
importing Gitea projects (apparently they have a compatible API)
This MR renames the Gitea importer to Gitlab::LegacyGithubImport and
introduces a new GitHub importer in the Gitlab::GithubImport namespace.
This new GitHub importer uses Sidekiq for importing multiple resources
in parallel, though it also has the ability to import data sequentially
should this be necessary.
The new code is spread across the following directories:
* lib/gitlab/github_import: this directory contains most of the importer
code such as the classes used for importing resources.
* app/workers/gitlab/github_import: this directory contains the Sidekiq
workers, most of which simply use the code from the directory above.
* app/workers/concerns/gitlab/github_import: this directory provides a
few modules that are included in every GitHub importer worker.
== Stages
The import work is divided into separate stages, with each stage
importing a specific set of data. Stages will schedule the work that
needs to be performed, followed by scheduling a job for the
"AdvanceStageWorker" worker. This worker will periodically check if all
work is completed and schedule the next stage if this is the case. If
work is not yet completed this worker will reschedule itself.
Using this approach we don't have to block threads by calling `sleep()`,
as doing so for large projects could block the thread from doing any
work for many hours.
== Retrying Work
Workers will reschedule themselves whenever necessary. For example,
hitting the GitHub API's rate limit will result in jobs rescheduling
themselves. These jobs are not processed until the rate limit has been
reset.
== User Lookups
Part of the importing process involves looking up user details in the
GitHub API so we can map them to GitLab users. The old importer used
an in-memory cache, but this obviously doesn't work when the work is
spread across different threads.
The new importer uses a Redis cache and makes sure we only perform
API/database calls if absolutely necessary. Frequently used keys are
refreshed, and lookup misses are also cached; removing the need for
performing API/database calls if we know we don't have the data we're
looking for.
== Performance & Models
The new importer in various places uses raw INSERT statements (as
generated by `Gitlab::Database.bulk_insert`) instead of using Rails
models. This allows us to bypass any validations and callbacks,
drastically reducing the number of SQL queries and Gitaly RPC calls
necessary to import projects.
To ensure the code produces valid data the corresponding tests check if
the produced rows are valid according to the model validation rules.
|
| | |
| |
| |
| | |
name. Use ArgumentError
|
| | |\ |
|
| | | | |
|
| | |/ |
|
| | | |
|
| | |
| |
| |
| |
| |
| | |
Replaces all the explicit include metadata syntax in the specs (tag:
true) into the implicit one (:tag).
Added a cop to prevent future errors and handle autocorrection.
|
| |/ |
|
| |
|
|
|
| |
The helper creates a fork of a project with all provided attributes,
but skipping the creation of the repository on disk.
|
| |\
| |
| |
| | |
# Conflicts:
# db/schema.rb
|
| | | |
|
| | | |
|
| | | |
|
