summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Add limit of 128 characters to users name57493-add-limit-to-user-nameBrandon Labuschagne2019-04-052-0/+26
| | | | | Truncate existing users names which exceed 128 characters Include test for truncating users names
* Merge branch ↵Douglas Barbosa Alexandre2019-04-051-0/+34
|\ | | | | | | | | | | | | '9217-warn-on-git-fetch-over-ssh-if-the-secondary-is-lagging-the-primary' into 'master' Display console messages, if available See merge request gitlab-org/gitlab-ce!26692
| * Allow console messages be sent to gitlab-shell9217-warn-on-git-fetch-over-ssh-if-the-secondary-is-lagging-the-primaryAsh McKenzie2019-04-041-0/+34
| | | | | | | | Currently a no-op for CE
* | Merge branch ↵Clement Ho2019-04-041-0/+10
|\ \ | | | | | | | | | | | | | | | | | | '57319-hide-kubernetes-cluster-warning-if-project-has-cluster-related' into 'master' Resolve "Hide Kubernetes cluster warning if project has cluster related" See merge request gitlab-org/gitlab-ce!26749
| * | Hide kubernetes cluster warning when a cluster existsMike Greiling2019-04-041-0/+10
| | |
* | | Merge branch 'sh-fix-ref-name-caching' into 'master'Douglas Barbosa Alexandre2019-04-042-0/+4
|\ \ \ | | | | | | | | | | | | | | | | Fix and expand Gitaly FindCommit caching See merge request gitlab-org/gitlab-ce!27018
| * | | Fix and expand Gitaly FindCommit cachingsh-fix-ref-name-cachingStan Hu2019-04-042-0/+4
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26248 added support for deduplicating FindCommit requests using Gitaly ref name caching. However, not all endpoints were covered, and in one case the Gitaly wrapper wasn't actually surrounding the serialization step. We can safely cache ref names between FindCommit calls for #index and #show endpoints for merge requests and pipelines. This can significantly reduce the number of FindCommit requests.
* | | Merge branch '57602-create-cluster-validations' into 'master'Mike Greiling2019-04-043-3/+3
|\ \ \ | |/ / |/| | | | | | | | | | | | | | Display cluster form validation error messages inline Closes #57602 See merge request gitlab-org/gitlab-ce!26502
| * | Specify new validation message selectorEnrique Alcantara2019-04-033-3/+3
| | | | | | | | | | | | | | | Update QA selector to specify that API URL is a input type=url field
* | | Merge branch 'drop-usage-of-leagcy-artifacts' into 'master'Kamil Trzciński2019-04-041-0/+18
|\ \ \ | | | | | | | | | | | | | | | | Drop legacy artifacts usage as there are no leftovers See merge request gitlab-org/gitlab-ce!24294
| * | | Drop legacy artifacts usagedrop-usage-of-leagcy-artifactsShinya Maeda2019-04-041-0/+18
| | |/ | |/| | | | | | | | | | | | | Legacy artifacts have been correctly migrated to new place - ci_job_artifacts. Now it's time to remove the related code, but before that we should ensure it doesn't break anything by using feature flag.
* | | Merge branch '60057-fix-gitlab-schema-keyerror' into 'master'Douglas Barbosa Alexandre2019-04-041-2/+12
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Fix a KeyError in GitlabSchema Closes #60057 See merge request gitlab-org/gitlab-ce!27011
| * | | Fix a KeyError in GitlabSchemaNick Thomas2019-04-041-2/+12
| | | |
* | | | Renamed terminal_specification to channel_specificationFrancisco Javier López2019-04-044-11/+19
|/ / / | | | | | | | | | | | | | | | We're moving from using terminology related to terminals when we refer to Websockets connections in Workhorse. It's more appropiate a concept like channel.
* | | Allow reactive caching to be used in servicesReuben Pereira2019-04-041-0/+44
| | | | | | | | | | | | | | | | | | | | | | | | Add support for defining a reactive_cache_worker_finder function that will be used by the reactive_caching_worker to generate/initialize the calling object. This allows reactive caching to work with Services where the object cannot be obtained from DB but a new object can be initialized.
* | | Merge branch '57831-allow-graphql-scalar-fields-to-be-authorized' into 'master'Nick Thomas2019-04-042-31/+117
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Allow GraphQL Scalar-fields to be authorized Closes #57831 See merge request gitlab-org/gitlab-ce!26338
| * | | Use parent object when authorizing scalar typesBrett Walker2019-04-042-31/+117
| | | |
* | | | Merge branch '59995-ide-status-bar-vue-render-error' into 'master'Phil Hughes2019-04-042-56/+81
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix vue render error for IDE status bar Closes #59995 See merge request gitlab-org/gitlab-ce!26979
| * | | | Fix vue render error for IDE status barPaul Slaughter2019-04-042-56/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | **What?** A Vue warning that `ide_status_bar` sent a `Boolean` to a `String` property (`img-src). **What was the fix?** Previously, `latestPipeline` could be one of the following values: | | | |----------|--------| | `null` | The pipeline hasn't loaded yet | | `false` | The pipeline has loaded, but nothing was returned. | | `Object` | The piepline has loaded. | Giving a semantic meaning to different falsey values hurts maintainability. This commit fixes the above problem by removing the `false` value and introducing a `hasLoadedPipeline` state property.
* | | | | Allow to sort wiki pages by date and titleIgor2019-04-043-14/+172
| | | | | | | | | | | | | | | | | | | | | | | | | - Add controls for sorting by title and date - Execute Gitaly call which now accepts sorting params for wikis
* | | | | Merge branch '58405-basic-limiting-complexity-of-graphql-queries' into 'master'Rémy Coutable2019-04-044-0/+75
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Basic limiting complexity of GraphQL queries Closes #58405 See merge request gitlab-org/gitlab-ce!26629
| * | | | | Initial field and query complexity limits58405-basic-limiting-complexity-of-graphql-queriesBrett Walker2019-04-044-0/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It makes all Types::BaseField default to a complexity of 1. Queries themselves now have limited complexity, scaled to the type of user: no user, authenticated user, or an admin user.
* | | | | | Automatically set Prometheus step intervalPeter Leitzen2019-04-042-3/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By computing the step interval passed to the query_range Prometheus API call we improve the performance on the Prometheus server and GitLab by reducing the amount of data points sent back and prevent Prometheus from sending errors when requesting longer intervals.
* | | | | | Merge branch 'xanf/gitlab-ce-transfer-disables-js' into 'master'Sean McGivern2019-04-041-1/+1
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Failing group transfer disables expandable sections" Closes #45511 See merge request gitlab-org/gitlab-ce!26837
| * | | | | | Redirect to edit page on group transfer failurexanf/gitlab-ce-transfer-disables-jsIllya Klymov2019-04-031-1/+1
| | | | | | |
* | | | | | | Merge branch '59570-confidential-quick-action' into 'master'Sean McGivern2019-04-042-36/+34
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Extract confidential quick action spec to a shared example Closes #59570 See merge request gitlab-org/gitlab-ce!26913
| * | | | | | | Extract confidential quick action spec to a shared example59570-confidential-quick-actionAlexandru Croitor2019-04-042-36/+34
| | | | | | | |
* | | | | | | | Allow to use untrusted Regexp via feature flagKamil Trzciński2019-04-043-11/+150
| |_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This brings support for untrusted regexp for 'only:refs:' when enabled via feature flag: alllow_unsafe_ruby_regexp. This is by default disabled, and should not be used in production
* | | | | | | Consider array params on rendering MR list on dashboardIgor2019-04-043-2/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes the bug, when approver filter is provided, but dashboard asks to enter any filter
* | | | | | | Merge branch '60029-fix-broken-master' into 'master'Sean McGivern2019-04-042-2/+2
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix an order-dependent spec failure in spec/migrations/schedule_sync_issuables_state_id_spec.rb Closes #60029 See merge request gitlab-org/gitlab-ce!26997
| * | | | | | | Fix an order-dependent spec failure in ↵Nick Thomas2019-04-042-2/+2
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | spec/migrations/schedule_sync_issuables_state_id_spec.rb
* | | | | | | Add cr remarksGosia Ksionek2019-04-042-0/+131
| |_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Chnage method used in model to make it more efficient database-wise Add additional spec
* | | | | | Monitor GraphQL with PrometheusJan Provaznik2019-04-041-0/+33
| |_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Extends graphql's platform tracing class to observe duration of graphql methods. In graphql 1.8.11 is added prometheus class but it's not very useful for us because it uses prometheus_exporter to export results.
* | | | | Fixed test specsOswaldo Ferreira2019-04-0414-166/+572
| | | | | | | | | | | | | | | | | | | | | | | | | - added suggestions to mock data - fixed props to be not required
* | | | | Merge branch 'ignore-merge-when-merge-pipelines-is-stale-ce' into 'master'Kamil Trzciński2019-04-041-1/+6
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | Backport: Ignore merge if the status of the merge request pipeline is stale See merge request gitlab-org/gitlab-ce!26975
| * | | | Ignore merge if the status of the merge request pipeline is staleignore-merge-when-merge-pipelines-is-stale-ceShinya Maeda2019-04-041-1/+6
| | |/ / | |/| | | | | | | | | | | | | | | | | | Merge request pipeline is meant for ensuring target branch's pipeline green. We should not let maintainers merge a merge request if the head pipeline of the merge request doesn't fulfill the criteria.
* | | | Merge branch 'stop-signing-avatar-paths' into 'master'Kamil Trzciński2019-04-041-0/+9
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Speed up avatar URLs with object storage Closes #43065 See merge request gitlab-org/gitlab-ce!26858
| * | | | Speed up avatar URLs with object storageSean McGivern2019-04-041-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With object storage enabled, calling `#filename` on an upload does this: 1. Call the `#filename` method on the CarrierWave object. 2. Generate the URL for that object. 3. If the uploader isn't public, do so by generating an authenticated URL, including signing that request. That's all correct behaviour, but for the case where we use `#filename`, it's typically to generate a GitLab URL. That URL doesn't need to be signed because we do our own auth. Signing the URLs can be very expensive, especially in batch (say, we need to get the avatar URLs for 150 users in one request). It's all unnecessary work. If we used the `RecordsUploads` concern, we have already recorded a `path` in the database. That `path` is actually generated from CarrierWave's `#filename` at upload time, so we don't need to recompute it - we can just use it and strip off the prefix if it's available. On a sample users autocomplete URL, at least 10% of the time before this change went to signing URLs. After this change, we spend no time in URL signing, and still get the correct results.
* | | | | Merge branch 'dz-reserve-v2-root-path' into 'master'Grzegorz Bizon2019-04-041-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Add v2 to reserved top level routes See merge request gitlab-org/gitlab-ce!26540
| * | | | | Add v2 to reserved top level routesdz-reserve-v2-root-pathDmitriy Zaporozhets2019-04-041-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | | | | | Merge branch '54417-graphql-type-authorization' into 'master'Nick Thomas2019-04-048-76/+214
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | GraphQL Type authorization Closes #54417 See merge request gitlab-org/gitlab-ce!25724
| * | | | | | GraphQL Type authorizationLuke Duncalfe2019-04-038-76/+214
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Enables authorizations to be defined on GraphQL Types. module Types class ProjectType < BaseObject authorize :read_project end end If a field has authorizations defined on it, and the return type of the field also has authorizations defined on it. then all of the combined permissions in the authorizations will be checked and must pass. Connection fields are checked by "digging" to find the type class of the "node" field in the expected location of edges->node. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54417
* | | | | | | Filters branch and path labels for metricsRyan Cobb2019-04-041-0/+229
| | | | | | |
* | | | | | | Merge branch '59570-tag-quick-action' into 'master'Sean McGivern2019-04-042-22/+25
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move tag quick action spec to shared example Closes #59570 See merge request gitlab-org/gitlab-ce!26904
| * | | | | | | Move tag quick action spec to shared example59570-tag-quick-actionAlexandru Croitor2019-04-032-22/+25
| | | | | | | |
* | | | | | | | Merge branch '59570-merge-quick-action' into 'master'Sean McGivern2019-04-042-68/+49
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Extract merge quick action to a shared example Closes #59570 See merge request gitlab-org/gitlab-ce!26925
| * | | | | | | | Extract merge quick action to a shared example59570-merge-quick-actionAlexandru Croitor2019-04-032-68/+49
| | | | | | | | |
* | | | | | | | | Merge branch '24704-download-repository-path' into 'master'Kushal Pandya2019-04-046-18/+33
|\ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Download a folder from repository Closes #24704 See merge request gitlab-org/gitlab-ce!26532
| * | | | | | | | Make the dropdown match the designPatrick Bajao2019-04-024-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Regenerate locale.pot as well
| * | | | | | | | Download a folder from repositoryPatrick Bajao2019-04-022-13/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add `GetArchiveRequest` to git-archive params. Modifies `Git::Repository#archive_metadata` to append `path` to `ArchivePrefix` so it'll not hit the cache of repository archive when it already exists.