| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
We had similar code in a few places to redirect to the last page if
the given page number is out of range. This unifies the handling in a
new controller concern and adds usage of it in all snippet listings.
|
|
|
|
|
| |
- Avoid N+1 queries for authors and comment counts
- Avoid an additional snippet existence query
|
|\
| |
| |
| |
| |
| |
| |
| |
| | |
'reprazent/gitlab-ce-bvl-find-correct-variables-for-testing-translations' into 'master'
Build correct variables for testing translations
Closes #48110
See merge request gitlab-org/gitlab-ce!32871
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This makes sure we build the correct variables for testing
translations.
When translating, we could be specifying the variables in different
forms for each id:
- In the singular we could be using a `%{hash}` interpolation
- In the plural we could be using a `%d` interpolation
This changes the tests to accommodate for that: We now use the
variables used in the relevant translation id as the source for the
variables we mix in in specs.
|
|/
|
|
| |
filenames.
|
|
|
|
|
| |
This presenter will be used in an upcoming MR which adds
rendering of epic events on group activity page.
|
| |
|
|\
| |
| |
| |
| | |
Expose :protected field for ../tags/:tag_name API endpoint
See merge request gitlab-org/gitlab-ce!32790
|
| | |
|
| | |
|
| | |
|
|\ \
| | |
| | |
| | |
| | | |
Add caret icons to the monitoring dashboard
See merge request gitlab-org/gitlab-ce!32239
|
| | |
| | |
| | |
| | |
| | | |
The carets will function as a button that will allow the panels
from the monitoring dashboard to collapse and show panels
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Improve application settings API
Closes #58180
See merge request gitlab-org/gitlab-ce!31149
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
As in documentation.
Fixes: #58180.
Also remove the requirement between domain_blacklist_enabled and domain_blacklist.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Create HAML UI select a cloud provider to create a cluster.
- Add query param to :new cluster view to display a specific cluster
provider form depending on the value of the provider query param.
- Update unit tests and e2e tests to reflect these changes
|
| |/ /
|/| |
| | |
| | |
| | | |
Utilize `json_fields` to expose fields via
`Service#as_json(only: json_fields)`.
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
'9102-hide-dismissed-vulnerabilities-in-the-group-security-dashboard-backport' into 'master'
Add toggle to show/hide dismissed vulnerabilities (ports ee!15333)
See merge request gitlab-org/gitlab-ce!32413
|
| | | |
| | | |
| | | |
| | | | |
Backport of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/15333
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
ActiveModel::Serialization is simple in that it recursively calls
`as_json` on each object to serialize everything. However, for a model
like a Project, this can generate a query for every single association,
which can add up to tens of thousands of queries and lead to memory
bloat.
To improve this, we can do several things:
1. We use `tree:` and `preload:` to automatically generate
a list of all preloads that could be used to serialize
objects in bulk.
2. We observe that a single project has many issues, merge requests,
etc. Instead of serializing everything at once, which could lead to
database timeouts and high memory usage, we take each top-level
association and serialize the data in batches.
For example, we serialize the first 100 issues and preload all of
their associated events, notes, etc. before moving onto the next
batch. When we're done, we serialize merge requests in the same way.
We repeat this pattern for the remaining associations specified in
import_export.yml.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Lowering the limit when performing search from 1001 to 101.
This will allow us to speed this process.
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Add skeleton Pages internal API
See merge request gitlab-org/gitlab-ce!32732
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Basic `/internal/pages` endpoint that will be used for Pages virtual
domains internal API. The endpoint is currently behind feature flag and
provides authetication similar to how Workhorse is authenticating with
the GitLab.
|
| | | | | |
|
|\ \ \ \ \
| |_|_|/ /
|/| | | |
| | | | |
| | | | | |
Use delete_all for deleting events
See merge request gitlab-org/gitlab-ce!32751
|
| | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | | |
Because we don't have any destroy callbacks (or other logic
triggered on event destroy), there is no reason for deleting events
inefficiently one by one, instead we can use :delete_all.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
This change implements Application
Statistics API
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
Normalize import_export structure
See merge request gitlab-org/gitlab-ce!32704
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This brings a significant refactor to how
we handle `import_export.yml`, merge it with EE
and how we handle that for reader and saver.
This is meant to simplify the code, and remove
a ton of conditions to handle different models
of the structure.
This is also meant to prepare the structure
to extend it much easier, like adding `preload:`
or additional object types when needed.
This does not change the behavior of import/export,
rather unifies and simplifies the current implementation.
|
| | | |
| | | |
| | | |
| | | | |
Just replace RSA.new with PKey.read
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fix order-dependent spec failures with reCAPTCHA
Closes #67133
See merge request gitlab-org/gitlab-ce!32771
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
spec/controllers/registrations_controller_spec.rb polluted the test
environment by changing the Recaptcha configuration. We now stub the
controller's `verify_recaptcha` method instead of doing that.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/67133
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
accelerate wiki attachments
See merge request gitlab-org/gitlab-ce!32663
|
| | | | | | |
|
| |/ / / /
| | | | |
| | | | |
| | | | |
| | | | | |
Wiki attachments can be workhorse accelerated.
This commit is backward compatible with older workhorse
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Expose id field in the serializer in order
to store comments content in the localStorage
under the correct key
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix global state in registrations_controller_spec
See merge request gitlab-org/gitlab-ce!32712
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This spec would mess with global state used for captchas, but not reset
the state in all cases. This would then lead to the spec
spec/controllers/snippets_controller_spec.rb failing, but only on a fork
of gitlab-ee. To fix this we ensure the state is properly reset after
running the specs that change this state.
|
| |/ / / /
|/| | | |
| | | | |
| | | | | |
This reverts merge request !32571
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Log errors for failed pipeline creation in PostReceive
See merge request gitlab-org/gitlab-ce!32633
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
When a pipeline fails to create in `PostReceive`, the error is silently
discarded, making it difficult to understand why a pipeline was not
created. We now add a Sidekiq warning message for this. Adding a Sentry
exception when this happens would generate a lot of noise for invalid CI
files.
Relates to https://gitlab.com/gitlab-org/gitlab-ee/issues/14720
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
This class encapsulates our use of the Danger gem.
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Add projects parameter to IssuableFinder
Closes #67032 and gitlab-ee#10904
See merge request gitlab-org/gitlab-ce!32694
|
| | | | | | | |
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Enable Knative installation on group and instance level clusters
Closes #62667 and #62666
See merge request gitlab-org/gitlab-ce!32128
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
For installing applications on a project/group/instance cluster
|
| | |/ / / / /
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
- Show Knative install button on group/instance cluster pages
- Allow Knative to be installed on group/instance clusters
- Add feature specs for installing applications on group/instance
clusters
- Add changelog entry
- Update docs to reflect that Knative can now be installed on
group-level and instance-level clusters
|
| |_|_|/ / /
|/| | | | | |
|