summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Add facade which will always return nil in CEclusterable_cluster_environments_pathThong Kuah2019-09-031-0/+9
| | | | This method will be overridden in EE
* Add X-GitLab-NotificationReason header to note emailsadd-notification-reason-to-note-emailsSean McGivern2019-09-021-0/+4
| | | | | | The 'assigned' reason doesn't apply to notes, but the other two can ('mentioned' and 'own_activity'), so we can still use this for note emails.
* Update Mermaid to v8.2.6Stan Hu2019-09-021-1/+13
| | | | | | This fixes a regression where an underscore in labels no longer worked: https://github.com/knsv/mermaid/releases
* Handle :9090 and 0.0.0.0:9090 listen_address formatsReuben Pereira2019-09-021-1/+15
| | | | | | Prometheus listen_address can be in formats of :9090 and 0.0.0.0:9090. But before these can be used to connect a project to Prometheus, they have to converted into absolute URIs.
* Merge branch '65152-unfolded-lines-perf-improvement' into 'master'Douwe Maan2019-09-021-0/+14
|\ | | | | | | | | Support selective highlighting of lines See merge request gitlab-org/gitlab-ce!32514
| * Support selective highlighting of lines65152-unfolded-lines-perf-improvementPatrick Bajao2019-09-021-0/+14
| | | | | | | | | | | | | | | | | | | | Instead of highlighting all lines when not all of them are needed, only highlight from the beginning up to the specified limit. The `BlobPresenter#highlight` method has been updated to support `to` param. This param will be used to limit the content to be highlighted.
* | Merge branch '66803-fix-uploads-relative-link-filter' into 'master'Grzegorz Bizon2019-09-022-91/+36
|\ \ | | | | | | | | | | | | Fix permissions check in `RelativeLinkFilter` See merge request gitlab-org/gitlab-ce!32448
| * | Fix upload URLs in Markdown66803-fix-uploads-relative-link-filterHeinrich Lee Yu2019-09-022-91/+36
| |/ | | | | | | | | Fixes RelativeLinkFilter for users that don't have access to the project's repository
* | Fixing #65389Massimeddu Cireddu2019-09-021-3/+23
| | | | | | | | Wrong format on MS Teams integration push events with multi line commit messages
* | quick action label must be first in issue commentManeschi Romain2019-09-021-0/+17
| |
* | Rename shared examples according to our guidelines14756-move-shared-examplesRémy Coutable2019-09-022-0/+0
| | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | Merge branch 'fix-peek-on-puma' into 'master'Rémy Coutable2019-09-023-15/+15
|\ \ | | | | | | | | | | | | | | | | | | Fix Peek on Puma Closes #66528 See merge request gitlab-org/gitlab-ce!32213
| * | Make performance bar enabled checks consistentSean McGivern2019-08-283-15/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, we called the `peek_enabled?` method like so: prepend_before_action :set_peek_request_id, if: :peek_enabled? Now we don't have a `set_peek_request_id` method, so we don't need that line. However, the `peek_enabled?` part had a side-effect: it would also populate the request store cache for whether the performance bar was enabled for the current request or not. This commit makes that side-effect explicit, and replaces all uses of `peek_enabled?` with the more explicit `Gitlab::PerformanceBar.enabled_for_request?`. There is one spec that still sets `SafeRequestStore[:peek_enabled]` directly, because it is contrasting behaviour with and without a request store enabled. The upshot is: 1. We still set the value in one place. We make it more explicit that that's what we're doing. 2. Reading that value uses a consistent method so it's easier to find in future.
* | | Merge branch '50013-add-browser-platform-flags-sign-in-pages' into 'master'Filipa Lacerda2019-09-021-0/+8
|\ \ \ | | | | | | | | | | | | | | | | Add CSS & JS global flags to represent browser and platform on login pages See merge request gitlab-org/gitlab-ce!32521
| * | | Add browser and platform flagsKushal Pandya2019-09-021-0/+8
| | |/ | |/| | | | | | | | | | | | | - Adds CSS classes to represent browser & platform - Adds JS flags to `gl` object to represent browser & platform
* | | Merge branch '65304-add-pages-first-deployment-message' into 'master'Filipa Lacerda2019-09-021-0/+6
|\ \ \ | |/ / |/| | | | | | | | | | | | | | Resolve "Improve pages load wait time experience" Closes #65304 See merge request gitlab-org/gitlab-ce!32122
| * | Add warning about Pages initial deployment delay65304-add-pages-first-deployment-messageNathan Friend2019-08-301-0/+6
| | | | | | | | | | | | | | | | | | This commit adds a warning message that is always displayed that informs users that their GitLab Pages sites will take a bit of time before they can be accessed after being deployed for the first time.
* | | Merge branch 'sh-fix-ci-lint-500-error' into 'master'Ash McKenzie2019-09-021-0/+6
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Fix 500 error in CI lint when included templates are an array Closes #66605 See merge request gitlab-org/gitlab-ce!32232
| * | | Fix 500 error in CI lint when included templates are an arraysh-fix-ci-lint-500-errorStan Hu2019-08-311-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously the following syntax would fail in the linter with an error 500: ``` include: template: - License-Management.gitlab-ci.yml - Dependency-Scanning.gitlab-ci.yml - SAST.gitlab-ci.yml ``` Now the error will call out specifically that the value is not a string. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66605
* | | | Merge branch '46686-move-k8s-services-out-of-gcp-namespace' into 'master'66783-usage-ping-for-slack-integrationsThong Kuah2019-09-016-16/+16
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Move generic k8s services out of GCP namespace See merge request gitlab-org/gitlab-ce!32310
| * | | | Move generic k8s services out of GCP namespace46686-move-k8s-services-out-of-gcp-namespaceTiger2019-08-286-16/+16
| | | | | | | | | | | | | | | | | | | | | | | | | These services aren't specific to GCP, and will be used for AWS as part of https://gitlab.com/gitlab-org/gitlab-ce/issues/46686
* | | | | Merge branch ↵Nick Thomas2019-09-011-50/+18
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '66139-remove-kubernetes_namespace_per_environment-feature-flag' into 'master' Remove :kubernetes_namespace_per_environment feature flag See merge request gitlab-org/gitlab-ce!32140
| * | | | | Remove :kubernetes_namespace_per_environment feature flag66139-remove-kubernetes_namespace_per_environment-feature-flagTiger2019-08-301-50/+18
| | | | | | | | | | | | | | | | | | | | | | | | Feature flag has been defaulting to `true` since 12.2
* | | | | | Merge branch 'improve-chatops-help' into 'master'Nick Thomas2019-09-014-7/+10
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve chatops help output See merge request gitlab-org/gitlab-ce!32208
| * | | | | | Improve chatops help outputimprove-chatops-helpYorick Peterse2019-08-294-7/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This improves the output produced when running an unknown command, running the "help" command, and when trying to run a command you are not allowed to run. The new help output includes links to the project of the chatops integration, and a link to the chatops documentation.
* | | | | | | Merge branch 'refactor/showStagedIcon' into 'master'Paul Slaughter2019-09-011-4/+2
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor showStagedIcon property's behavior to match its name Closes #66071 See merge request gitlab-org/gitlab-ce!32333
| * | | | | | | Refactor showStagedIcon property's behavior to match its nameArun Kumar Mohan2019-08-301-4/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, the `showStagedIcon` property was doing the opposite of what its name suggested. It was rendering the staged icon when `showStagedIcon` was `false` and rendering the regular icon when it was `true`.
* | | | | | | | Merge branch 'remove-ignorable-column-concern' into 'master'Michael Kozono2019-08-301-44/+0
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove dependency on IgnorableColumn concern Closes #66746 See merge request gitlab-org/gitlab-ce!32427
| * | | | | | | | Remove dependency on IgnorableColumn concerndineshpanda2019-08-301-44/+0
| | | | | | | | |
* | | | | | | | | Creates Feature Flag for job logFilipa Lacerda2019-08-306-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Updates frontend code and specs to allow for the new feature flag
* | | | | | | | | Limit access request email to 10 most recently active owners/maintainersManoj MJ2019-08-307-34/+217
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change limits the number of emails for new access requests notifications to 10 most recently active owners/maintainers
* | | | | | | | | Fix for #56295, https://gitlab.com/gitlab-org/gitlab-ce/issues/56295.Jesse Hall2019-08-302-0/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | All avatars now visible in commit trailers.
* | | | | | | | | Merge branch 'fix-nil-deployable-exception-on-job-controller-show' into 'master'Grzegorz Bizon2019-08-302-0/+17
|\ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix users cannot access job detail page when deployable does not exist Closes #65216 See merge request gitlab-org/gitlab-ce!32247
| * | | | | | | | Fix deployable nil exception on job controllerfix-nil-deployable-exception-on-job-controller-showShinya Maeda2019-08-302-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When deployable is nil, we gracefully take care of the case.
* | | | | | | | | Fix for histogram corruption in SidekiqAndrew Newdigate2019-08-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a bug in which sidekiq histograms contain invalid labels. See https://gitlab.com/gitlab-com/gl-infra/infrastructure/issues/7729 for more details.
* | | | | | | | | Install cert-manager v0.9.1James Fargher2019-08-301-7/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This does not support upgrading from earlier versions
* | | | | | | | | Merge branch 'ab-routable-two-step-search' into 'master'Jan Provaznik2019-08-301-1/+19
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Perform two-step Routable lookup by path See merge request gitlab-org/gitlab-ce!32272
| * | | | | | | | | Perform two-step Routable lookup by pathAndreas Brandl2019-08-301-1/+19
| | |_|_|_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In order to lookup a Project or Namespace by path, we prefer an exact match (case-sensitive) but in absence of that, we'd also take a case-insensitive match. The case-insensitive matching with preference for the exact match is a bit more involved in SQL as the exact lookup. Yet, the majority of cases will be an exact match. The thinking here is that we can optimize the lookup by performing an exact match first and only if there is no result, we perform the case-insensitive lookup. Data for GitLab.com: * We have about 15M records in routes table * About 2,500 routes exist where there's more than one record with the same `lower(path)` It is possible for a user to craft requests that would always trigger the 2-step search (e.g. we have a route for `/foo/bar`, the request is always for `/FOO/bar`). In this case, the change at hand is not beneficial as it would run an additional query. However, based on the data, it is highly likely that the vast majority of requests can be satisfied with an exact match only. The context for this change is https://gitlab.com/gitlab-org/gitlab-ce/issues/64590#note_208156463.
* | | | | | | | | Rename epic column state to state_idFelipe Artur2019-08-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rename epic column state to state_id to be consistent with issues and merge requests
* | | | | | | | | Improve search result labelsMarkus Koller2019-08-3018-181/+212
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Use "results" instead of "blobs", "wiki blobs", "snippet blobs" - Use "comments" instead of "notes" - Use correct pluralization - Don't add "1 - 10 of" if there's only one page
* | | | | | | | | Merge branch 'nfriend-add-anchor-tag-to-release-block' into 'master'Kushal Pandya2019-08-301-0/+4
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add `id` attribute to release blocks See merge request gitlab-org/gitlab-ce!32360
| * | | | | | | | | Add id to release blocknfriend-add-anchor-tag-to-release-blockNathan Friend2019-08-281-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit adds an id attribute to release blocks to allow them to be targeted as anchor links.
* | | | | | | | | | Merge branch 'ce-13479-rename-atmtwps-to-mtwps' into 'master'Paul Slaughter2019-08-301-2/+2
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CE backport for gitlab-org/gitlab-ee!15535: Resolve "Rename `ATMTWPS` to `MTWPS` in code" See merge request gitlab-org/gitlab-ce!32112
| * | | | | | | | | | Rename ATMTWPS to MTWPS (CE)ce-13479-rename-atmtwps-to-mtwpsNathan Friend2019-08-221-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit does a find-and-replace from ATMTWPS -> MTWPS.
* | | | | | | | | | | Resolve "Use "moved" instead of "closed" in issue references"Juliette de Rancourt2019-08-301-0/+8
| |_|/ / / / / / / / |/| | | | | | | | |
* | | | | | | | | | URL-encode file links in find fileJan Beckmann2019-08-301-0/+77
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/62055
* | | | | | | | | | Allow be_url to specify the typeAlex Kalderimis2019-08-302-6/+37
| |_|/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows the be_url matcher to be more specific. By default, it only matches HTTP and HTTPS URIs.
* | | | | | | | | Merge branch 'master' of dev.gitlab.org:gitlab/gitlabhqRobert Speicher2019-08-2946-218/+1917
|\ \ \ \ \ \ \ \ \
| * \ \ \ \ \ \ \ \ Merge branch 'security-enable-image-proxy' into 'master'GitLab Release Tools Bot2019-08-2911-1/+324
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use image proxy to mitigate stealing ip addresses Closes #2812 See merge request gitlab/gitlabhq!2926
| | * | | | | | | | | Fix failing spec due to changes UpdateServiceBrett Walker2019-08-231-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | for ApplicationSettings