summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch ↵Douwe Maan2017-01-141-3/+0
|\ | | | | | | | | | | | | | | | | | | '25018-gitlab-checks-changeaccess-looks-for-user-permissions-that-don-t-exist' into 'master' Resolve "`Gitlab::Checks::ChangeAccess` looks for user permissions that don't exist" Closes #25018 See merge request !8551
| * Remove useless permission checks in Gitlab::Checks::ChangeAccess25018-gitlab-checks-changeaccess-looks-for-user-permissions-that-don-t-existRémy Coutable2017-01-121-3/+0
| | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | Merge branch '26587-metrics-middleware-endpoint-is-nil' into 'master' Yorick Peterse2017-01-141-0/+11
|\ \ | | | | | | | | | | | | | | | | | | Resolve "Metrics middleware: endpoint is nil" Closes #26587 See merge request !8544
| * | Check for env[Grape::Env::GRAPE_ROUTING_ARGS] instead of endpoint.route26587-metrics-middleware-endpoint-is-nilRémy Coutable2017-01-121-0/+11
| |/ | | | | | | | | | | | | `endpoint.route` is calling `env[Grape::Env::GRAPE_ROUTING_ARGS][:route_info]` but `env[Grape::Env::GRAPE_ROUTING_ARGS]` is `nil` in the case of a 405 response Signed-off-by: Rémy Coutable <remy@rymai.me>
* | Merge branch 'fix-build-sort-order' into 'master' Robert Speicher2017-01-131-0/+19
|\ \ | | | | | | | | | | | | | | | | | | Resolve "Sort order for pipeline build lists doesn't properly handle numbers" Closes #25428 See merge request !8277
| * | revise sortable_name test formattingMike Greiling2017-01-131-4/+1
| | |
| * | prefer unit test on model over view testfix-build-sort-orderMike Greiling2017-01-022-35/+22
| | |
| * | add tests for natural sorting of build namesMike Greiling2017-01-021-0/+35
| | |
* | | Merge branch 'fix-single-team-specs' into 'master' Robert Speicher2017-01-131-3/+82
|\ \ \ | | | | | | | | | | | | | | | | Improve single mattermost team select disabled state See merge request !8276
| * | | Improve disabled state selectfix-single-team-specsLuke "Jared" Bennett2017-01-131-3/+82
| | | | | | | | | | | | | | | | Add tests
* | | | Merge branch 'fix/merge-separate-build-spec-files' into 'master' Robert Speicher2017-01-132-1341/+1275
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Merge separate build spec files into one in correct location Closes #24579 See merge request !8564
| * | | | Fix Rubocop offense in build specsfix/merge-separate-build-spec-filesGrzegorz Bizon2017-01-131-1/+0
| | | | |
| * | | | Remove empty build spec file from invalid locationGrzegorz Bizon2017-01-131-6/+0
| | | | |
| * | | | Merge build specs into file that has valid locationGrzegorz Bizon2017-01-132-1335/+1276
| | | | |
* | | | | Merge branch 'fix/serialized-commit-path' into 'master' Rémy Coutable2017-01-131-0/+2
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update commit entity to point to valid commit page Closes #26624 See merge request !8558
| * | | | | Update commit entity to point to valid commit pageGrzegorz Bizon2017-01-131-0/+2
| |/ / / /
* | | | | Merge branch 'env-var-in-redis-config' into 'master' Rémy Coutable2017-01-132-1/+17
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | Allow to use ENV variables in redis config See merge request !8073
| * | | | Allow to use ENV variables in redis configSemyon Pupkov2017-01-132-1/+17
| | | | |
* | | | | Only escape the 'No Milestone' paramfix-ruby21-milestone-api-specs-2Sean McGivern2017-01-132-4/+6
| | | | | | | | | | | | | | | | | | | | This is less invasive than the parent commit.
* | | | | Fix milestone API specs in Ruby 2.1fix-ruby21-milestone-api-specsSean McGivern2017-01-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ruby 2.3: ``` URI.parse('http://foo/bar?baz quux') => #<URI::HTTP http://foo/bar?baz%20quux> ``` Ruby 2.1: ``` URI.parse('http://foo/bar?baz quux') URI::InvalidURIError: bad URI(is not URI?): http://foo/bar?baz quux ```
* | | | | Merge branch '23194-fix-no-milestone-option-for-projects-endpoint' into ↵Sean McGivern2017-01-131-3/+77
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'master' Fixes the incoherent filtering by milestone in `/projects/:id/issues` and `/groups/:id/issues` endpoints Closes #23194 See merge request !8457
| * | | | API: Implement project issues iid param with IssuesFinder and add tests23194-fix-no-milestone-option-for-projects-endpointDavid Eisner2017-01-121-3/+77
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Use IssuesFinder for the /issues API resouce - Tests for iid filter in project issues API resource - Tests for No Milestone filter in issues API resources The "No Milestone" case was not previously tested, and the `/issues` resource did not support the the `milestone` parameter. - Return issues where all labels match from the issues and project issues API resources, like the group issues resource already does. See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6825#note_17474533 Signed-off-by: Rémy Coutable <remy@rymai.me>
* | | | | Merge branch 'move-dashboard-help-spinach-to-rspec' into 'master' Rémy Coutable2017-01-131-0/+17
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Move dashboard help spinach test to rspec See merge request !8436
| * | | | | Move dashboard help spinach test to rspecSemyon Pupkov2017-01-041-0/+17
| | | | | | | | | | | | | | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
* | | | | | Merge branch 'move-dashboard-group-spinach-to-rspec' into 'master' Rémy Coutable2017-01-131-0/+20
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move dashboard group spinach test to rspec See merge request !8434
| * | | | | | Move dashboard group spinach test to rspecSemyon Pupkov2017-01-041-0/+20
| |/ / / / / | | | | | | | | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
* | | | | | Merge branch 'move-dashboard-archived-projects-spinach-to-rspec' into 'master' Rémy Coutable2017-01-132-0/+32
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move dashboard archived projects spinach tests to rspec See merge request !8431
| * | | | | | Move dashboard archived projects spinach tests to rspecSemyon Pupkov2017-01-042-0/+32
| |/ / / / / | | | | | | | | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
* | | | | | Merge branch 'move-dashboard-activetab-spinach-to-rspec' into 'master' Rémy Coutable2017-01-131-0/+46
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move dashboard active tab spinach test to rspec See merge request !8423
| * | | | | | Move dashboard active tab spinach test to rspecSemyon Pupkov2017-01-031-0/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
* | | | | | | Merge branch 'remove-double-let' into 'master' Rémy Coutable2017-01-131-1/+0
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove duplicate let in cycle_analytics_spec See merge request !8422
| * | | | | | | Remove duplicate let in cycle_analytics_specSemyon Pupkov2017-01-031-1/+0
| |/ / / / / /
* | | | | | | Merge branch 'move-admin-users-spinach-tests-to-rspec' into 'master' Rémy Coutable2017-01-131-32/+141
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | Move admin users spinach tests to rspec See merge request !8395
| * | | | | | Tiny refactoring example in admin users feature specSemyon Pupkov2017-01-021-9/+9
| | | | | | |
| * | | | | | Move admin users spinach tests to rspecSemyon Pupkov2017-01-021-23/+132
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/issues/23036
* | | | | | | Merge branch '24185-legacy-ci-status-reactive-cache' into 'security'Robert Speicher2017-01-125-146/+308
| |_|_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use ReactiveCaching to update external CI status asynchronously See https://dev.gitlab.org/gitlab/gitlabhq/merge_requests/2055
* | | | | | fixes the issueTiago Botelho2017-01-121-1/+1
| | | | | |
* | | | | | Merge branch 'use-configured-git' into 'master' Douwe Maan2017-01-121-5/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use configured git rather thans system git See merge request !8460
| * | | | | | Use configured git rather than system gituse-configured-gitRobert Schilling2017-01-051-5/+5
| | | | | | |
* | | | | | | Merge branch 'zj-unadressable-url-variables' into 'master' Douwe Maan2017-01-122-17/+13
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Do not check for valid url for .gitlab-ci.yml Closes #22970 See merge request !8451
| * | | | | | | Do not check for valid url for .gitlab-ci.ymlZ.J. van de Weg2017-01-052-17/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Until this commit, GitLab would check if the URL in your .gitlab-ci.yml would be valid and adressable. However, this approach is rather limited. To begin, the URL couldn't be http://example:$PORT/my-project, as the PORT value would be interpolated after checking if the URL was valid, which its not. Also this gem will limit the amount of protocols allowed. This commit doesn't check, at all, if the URL is valid. This is now the responsablilty of the user. In my opion this is right, as the user ultimately benefits from a correct URL, but also, its impossible to cover all cases.
* | | | | | | | Merge branch 'fill-authorized-projects' into 'master' Douwe Maan2017-01-121-0/+18
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fill missing authorized projects rows Closes #26194 See merge request !8476
| * | | | | | | | Fill missing authorized projects rowsfill-authorized-projectsYorick Peterse2017-01-111-0/+18
| | |_|_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This ensures that the project_authorizations rows exist for all users for which this data has not yet been populated. Fixes #26194
* | | | | | | | Merge branch 'search-bar-first-iteration' into 'master' Jacob Schatz2017-01-1220-284/+2363
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Search bar first iteration Closes #21747 See merge request !7345
| * | | | | | | | Fix rubocopsearch-bar-first-iterationClement Ho2017-01-111-11/+11
| | | | | | | | |
| * | | | | | | | Backend reviewClement Ho2017-01-117-13/+192
| | | | | | | | |
| * | | | | | | | Fix specsClement Ho2017-01-092-5/+6
| | | | | | | | |
| * | | | | | | | Refactor addWordToInputClement Ho2017-01-091-33/+24
| | | | | | | | |
| * | | | | | | | Fix various styles for rubocopLin Jen-Shin2017-01-092-6/+6
| | | | | | | | |
| * | | | | | | | Fix specsClement Ho2017-01-094-60/+34
| | | | | | | | |
View Lorry Controller Status