| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |\ |
|
| | |\
| | |
| | |
| | |
| | | |
Remove old migration specs that violate FactoriesInMigrationSpecs
See merge request gitlab-org/gitlab-ce!30280
|
| | | |
| | |
| | |
| | |
| | | |
This removes old migrations that violate the
FactoriesinMigrationSpecs cop
|
| | |\ \
| | | |
| | | |
| | | |
| | | | |
Add Redis call details in Peek performance bar
See merge request gitlab-org/gitlab-ce!30191
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Since Redis timings appear to be increasing in production, this change
makes it easier to see what exactly which queries are being called and
where.
This is done by prepending modules in peek-redis to store the call
details.
This commit redact values for all SET commands (e.g. HMSET, GETSET,
etc.).
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add released_at field to releases API
Add released_at column to releases table
Return releases to the API sorted by released_at
|
| | | | |
| | | |
| | | |
| | | | |
- all commits squashed to make danger review happy
|
| | | | | |
|
| | |\ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Fix order-dependent Gitaly specs failing
Closes #64006
See merge request gitlab-org/gitlab-ce!30282
|
| | | |/ /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If `spec/tasks/gitlab/cleanup_rake_spec.rb` preceded any of the Gitaly
request specs, it would import the `cleanup.rake` and the global
function `limit`. For some reason, the Protobuf implementation would use
the global function instead of the getter method. For example:
```
def limit
puts "hi"
end
req = Gitaly::WikiGetAllPagesRequest.new
req.send(:limit)
hi
=> nil
```
To fix this problem, access the field value using the [] operator
instead.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64006
|
| | |\ \ \
| | |/ /
| |/| |
| | | |
| | | | |
Don't let logged out user do manual order
See merge request gitlab-org/gitlab-ce!30264
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Add a check for logged out user in the manual order
so that they don't see an flash message when they try to
reorder issues.
|
| | | | | |
|
| | | |/
| |/|
| | |
| | |
| | |
| | | |
Fetches user based on the value of 'rack.attack.match_discriminator'
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/62756
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| | |
This new attribute is optional and used when set instead of the default
format `gitlab+deploy-token-#{id}`.
Empty usernames will be saved as null in the database.
Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/50228.
|
| | |\
| | |
| | |
| | |
| | |
| | |
| | | |
Use title and description fields for issue trackers
Closes #63690
See merge request gitlab-org/gitlab-ce!30096
|
| | | |
| | |
| | |
| | |
| | | |
- instead of using properties
- backward compatibility has to be kept for now
|
| | |\ \
| | | |
| | | |
| | | |
| | | | |
Cache Flipper persisted names directly to local memory storage
See merge request gitlab-org/gitlab-ce!30265
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Now that application settings are no longer dominating network traffic,
we see that the Feature#persisted_names is using a significant amount of
CPU and network bandwidth for Redis. Move this cache into the
thread-local memory storage to reduce Redis overhead.
|
| | |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- Add two new ActiveRecord models:
- RootNamespaceStoragestatistics will persist root namespace statistics
- NamespaceAggregationSchedule will save information when a new update
to the namespace statistics needs to be scheduled
- Inject into UpdateProjectStatistics concern a new callback that will
call an async job to insert a new row onto NamespaceAggregationSchedule
table
- When a new row is inserted a new job is scheduled. This job will
update call an specific service to update the statistics and after that
it will delete thee aggregated scheduled row
- The RefresherServices makes heavy use of arel to build composable
queries to update Namespace::RootStorageStatistics attributes.
- Add an extra worker to traverse pending rows on
NAmespace::AggregationSchedule table and schedule a worker for each one
of this rows.
- Add an extra worker to traverse pending rows on
NAmespace::AggregationSchedule table and schedule a worker for each one
of this rows
|
| | |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Squash old migrations
Closes #59177
See merge request gitlab-org/gitlab-ce!30226
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
On the assumption that a background migration whose specs need a schema
older than 2018 is obsoleted by this migration squash, we can remove
both specs and code for those that fail to run in CI as a result of the
schema at that date no longer existing.
This is true for all but the MigrateStageStatus background migration,
which is also used from the MigrateBuildStage background migration.
|
| | | | |
| | | |
| | | |
| | | | |
Since the migrations are gone, we don't need these specs either
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Includes changes to the Vue container registry component to support
the display of an empty message and error message when invalid
characters are found in the group, project or branch name.
repositories/index.html.haml has been changed to remove the content
and place into Vue component.
|
| | | | |
| | | |
| | | |
| | | | |
- JupyterHub must not be available (installed or updated)
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If an entry has been removed from the tree and later, during the same
session, a user is trying to add a new item with the same name/path we
should allow for that as long as the original entry is marked with
`deleted`.
|
| | |\ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Add a memory cache local to the thread to reduce Redis load
Closes #63977
See merge request gitlab-org/gitlab-ce!30233
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The introduction of the in-memory cache for application settings had a
side effect of making it harder to invalidate changes when the settings
occur. We now bypass the cache because it's possible the admin enabled
the usage ping, and we don't want to annoy the user again if they
already set the value.
To avoid causing significant load on the system, we add an extra check
to ensure the user is an admin. and we don't want to annoy the user
again if they already set the value. This is a bit of hack, but the
alternative would be to put in a more complex cache invalidation
step. Since this call only gets called in the uncommon situation where
the user is an admin and the only user in the instance, this shouldn't
cause too much load on the system.
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The /admin panel will now always return an uncached
application setting to ensure it always has the most
current info.
|
| | | | | | |
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Loading `ApplicationSetting` from Redis was responsible for at least 50%
of the CPU load of the Redis cluster on GitLab.com. Since these values
generally don't change very much, we can load this from the database and
cache it in memory, skipping Redis altogther. We use
`ActiveSupport::Cache::MemoryStore` as a drop-in replacement for
`RedisCacheStore` even though we probably don't need synchronized access
within `Thread.current`.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63977
|
| | |\ \ \ \
| | |_|/ /
| |/| | |
| | | | |
| | | | | |
Don't show image diff note on text file
See merge request gitlab-org/gitlab-ce!30221
|
| | | | | | |
|
| | |\ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Tidy spec for API::ProjectClusters
See merge request gitlab-org/gitlab-ce!30154
|
| | | | | | | |
|
| | |\ \ \ \ \
| | |_|_|/ /
| |/| | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Hid re-named entries in subfolders
Closes #63984
See merge request gitlab-org/gitlab-ce!30242
|
| | | | | | | |
|
| | |\ \ \ \ \
| | |/ / / /
| |/| | | |
| | | | | |
| | | | | | |
Add new onboarding to flipper A/B testing
See merge request gitlab-org/gitlab-ce!30125
|
| | | |/ / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
OnboardingExperimentHelpers take care of
determining if the current_user should or should
not see the new onboarding feature.
|
| | |\ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
CE backport for "Show design boards at previous versions in GraphQL"
See merge request gitlab-org/gitlab-ce!30151
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
EE MR https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14292
https://gitlab.com/gitlab-org/gitlab-ee/issues/9491
|
| | |\ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Resolve "Pipeline actions cause full refresh"
Closes #63590
See merge request gitlab-org/gitlab-ce!30190
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
The pipelines table was showing the loading icon
after the user cancelled or retried a pipeline.
This fixes that so the pipeline updates without
removing the table from the DOM.
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
- enabled uninstallation
- give it a specific uninstall message
- ajust specs
|
| | |\ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Fetch branches divergence graph data through API call
Closes #46139
See merge request gitlab-org/gitlab-ce!30068
|
| | | | |_|_|/ /
| | |/| | | |
| | | | | | |
| | | | | | | |
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/46139
|
| | |\ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Test schema_version_check directly
Closes #63913
See merge request gitlab-org/gitlab-ce!30209
|
| | | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Testing via db:migrate causes side-effects like setting
ActiveRecord::Base.configurations and also it runs schema dump into
db/schema.rb. Rather than keep up, we test schema_version_check directly
|
| | |\ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Fix attachments using the wrong URLs in e-mails
Closes #63910
See merge request gitlab-org/gitlab-ce!30197
|
