summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Don't use bang method when there is no safe methodReuben Pereira2019-07-121-2/+2
| | | | https://github.com/rubocop-hq/ruby-style-guide#dangerous-method-bang
* Split and prepend CurrentBoardEntityWinnie Hellmann2019-07-122-2/+30
| | | | (cherry picked from commit 1e8bdd01bff96122fe80c51fa8f024f18675b58b)
* Merge branch 'sh-audit-event-json-log-format-from-and-to' into 'master'James Lopez2019-07-121-4/+28
|\ | | | | | | | | Format `from` and `to` fields in JSON audit log See merge request gitlab-org/gitlab-ce!30333
| * Format `from` and `to` fields in JSON audit logsh-audit-event-json-log-format-from-and-toStan Hu2019-07-111-4/+28
| | | | | | | | | | | | | | | | To make it possible to index the `from` and `to` fields with Elasticsearch and other tools, we need the types to be the same. Currently they are a mix of boolean and string values. Part of https://gitlab.com/gitlab-org/gitlab-ee/issues/12599
* | Merge branch 'qa-dd-data-qa-selector-replacement' into 'master'Mark Lapierre2019-07-121-2/+2
|\ \ | | | | | | | | | | | | Introduce data-qa-selector to supplant .qa-class See merge request gitlab-org/gitlab-ce!28906
| * | Change element_with_pattern cop to not use quotesddavison2019-07-101-2/+2
| | | | | | | | | | | | | | | | | | | | | Using quotes within string validations can be messy. Let's use a typical CSS selector for an unquoted attribute Update the cop spec to validate appropriate new message
* | | Merge branch '64403-remove-setimmediate-polyfill' into 'master'Clement Ho2019-07-112-3/+2
|\ \ \ | |_|/ |/| | | | | | | | Remove setImmediate polyfill from production assets See merge request gitlab-org/gitlab-ce!30591
| * | Update setImmediate use in karma specs64403-remove-setimmediate-polyfillMike Greiling2019-07-112-1/+3
| | |
| * | Remove use of setTimeout in karma specsMike Greiling2019-07-111-4/+1
| | |
* | | Merge branch '35757-move-issues-in-boards-pderichs' into 'master'Jan Provaznik2019-07-112-0/+281
|\ \ \ | | | | | | | | | | | | | | | | Add endpoint to move issues in boards See merge request gitlab-org/gitlab-ce!30216
| * | | Add endpoint to move multiple issues35757-move-issues-in-boards-pderichsPatrick Derichs2019-07-112-0/+281
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add specs for new endpoint to move multiple issues. Add changelog entry Just check the first issue for the ability to move / update Add specs for exceeding limits and malformed requests Changed name of shared examples Change title of changelog entry Use %i instead of %w Check permission to update issue on project instead of board Use admin_issue permission to check for issue move ability Changed variable name to avoid shadow issue_params method Rename route to bulk_move Change route definition Check permissions for each issue Combine methods for parameters permit check Remove extra context Change description of context Check param for type Array Add unit tests to MoveService Use before_action for permission check Use set instead of let! Use let's instead of set
* | | | Merge branch '63667-hashed-storage-migration-count-correctly' into 'master'Douglas Barbosa Alexandre2019-07-112-8/+72
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Display the amount for Hashed Storage migration/rollback correctly Closes #63667 See merge request gitlab-org/gitlab-ce!29996
| * | | | Display the amount for Hashed Storage migration/rollback correctly63667-hashed-storage-migration-count-correctlyGabriel Mazetto2019-07-101-8/+26
| | | | | | | | | | | | | | | | | | | | | | | | | Rake script considers the specified range, if present, to calculate the affected amount of projects correctly.
| * | | | Added the `abort_execution` matcherGabriel Mazetto2019-07-101-0/+46
| | | | |
* | | | | Merge branch '64161-gitlab-fqdn' into 'master'Grzegorz Bizon2019-07-111-0/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add CI variable to provide GitLab FQDN Closes #64161 See merge request gitlab-org/gitlab-ce!30417
| * | | | | Add CI variable to provide GitLab FQDNBalasankar "Balu" C2019-07-101-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Balasankar "Balu" C <balasankar@gitlab.com>
* | | | | | Merge branch 'registry-fix-multi-delete-modal' into 'master'Kushal Pandya2019-07-112-2/+2
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Set unique modal IDs See merge request gitlab-org/gitlab-ce!30532
| * | | | | | Set unique modal IDsregistry-fix-multi-delete-modalPaul Gascou-Vaillancourt2019-07-092-2/+2
| | | | | | |
* | | | | | | Merge branch 'fix-issue-trackers-spec' into 'master'Thong Kuah2019-07-117-12/+36
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure all specs run properly See merge request gitlab-org/gitlab-ce!30367
| * | | | | | | Make sure all specs run properlyJarka Košanová2019-07-117-12/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - handling properties needs to be skipped when creating test records in order to test the legacy data
* | | | | | | | Give Knative serving permissions to service accountHordur Freyr Yngvason2019-07-116-1/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | GitLab uses a kubernetes service account to perform deployments. For serverless deployments to work as expected with externally created clusters with their own knative installations (e.g. via Cloud Run), this account requires additional permissions in the serving.knative.dev API group.
* | | | | | | | Bring buttons style up to design specScott Hampton2019-07-111-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a CSS effort only. Fixes the padding of the buttons to be `8px 12px` (including border) so that the button height is 32px. Also adjusts the border width for all buttons when the state is `hover`, `focus`, or `active to be 2px thick instead of 1px thick. This is accomplished through an inset box-shadow as not to increase the size of the button. Fixes some colors for primary and tertiary buttons.
* | | | | | | | Merge branch 'better-merge-train-exlusive-lock-ce' into 'master'Kamil Trzciński2019-07-111-0/+147
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CE Port: Fix race condition on merge train with better exclusive lock See merge request gitlab-org/gitlab-ce!30352
| * | | | | | | | Efficient merge train locksbetter-merge-train-exlusive-lock-ceShinya Maeda2019-07-111-0/+147
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Efficient merge train locks with Sequential Process helper.
* | | | | | | | | Merge branch 'banzai-avoid-redis-if-db-cache' into 'master'Douwe Maan2019-07-117-29/+145
|\ \ \ \ \ \ \ \ \ | |_|_|_|_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | Banzai - avoid redis if attr is in DB cache See merge request gitlab-org/gitlab-ce!30334
| * | | | | | | | Banzai - avoid redis if attr is in DB cachebanzai-avoid-redis-if-db-cacheMario de la Ossa2019-07-107-29/+145
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When cache_collection_render runs we end up reading and writing things to redis even if we already have the rendered field cached in the DB. This commit avoids using redis at all whenever we have the field already rendered in the DB cache.
* | | | | | | | | Merge branch 'bvl-link-phab-users' into 'master'James Lopez2019-07-119-16/+334
|\ \ \ \ \ \ \ \ \ | |_|/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fetch users from Phabricator + link to issues Closes #60565 See merge request gitlab-org/gitlab-ce!30321
| * | | | | | | | Fetch users from Phabricator to link to issuesBob Van Landuyt2019-07-109-16/+334
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We fetch the users from Phabricator based on their Phabricator ID. If a user with the same username exists and is a member of the project, we set them as assignee or author. When a user is applicable, we also cache it in Redis so we don't have to perform the request again for the same phid.
* | | | | | | | | Merge branch '62088-search-back' into 'master'Mike Greiling2019-07-112-0/+84
|\ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed back navigation for projects filter Closes #62088 See merge request gitlab-org/gitlab-ce!30373
| * | | | | | | | Fixed back navigation for projects filter62088-search-backDenys Mishunov2019-07-052-0/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Filterable list now sends request to filter the projects list explicitly with `json` extension to avoid breakage when navigating back from a project to the filtered project's list.
* | | | | | | | | Merge branch 'sh-bump-rspec-versions' into 'master'Mayra Cabrera2019-07-104-8/+11
|\ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | Upgrade rspec-rails to 3.8.2 and dependencies See merge request gitlab-org/gitlab-ce!28378
| * | | | | | | | Upgrade rspec-rails to 3.8.2 and dependenciessh-bump-rspec-versionsDouglas Barbosa Alexandre2019-07-104-8/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This brings the rspec-core version in line with the Gitaly changes and introduces Rails 5.1/5.2 improvements. Full CHANGELOG: https://github.com/rspec/rspec-rails/blob/master/Changelog.md
* | | | | | | | | Add support for additional panel typesJose Ivan Vargas2019-07-104-6/+104
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This introduces the single stat chart component aside from the area chart component
* | | | | | | | | Merge branch 'fix_simple_format_undefined' into 'master'Robert Speicher2019-07-101-1/+72
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix `simple_format` undefined error #60179 Closes #60179 See merge request gitlab-org/gitlab-ce!30366
| * | | | | | | | | Fix undefined method `simple_format for MarkupHelper:ModuleVasiliy Yakliushin2019-07-071-1/+72
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `simple_format` is not defined in ActionView::Helpers::TagHelper, but it is actually located in ActionView::Helpers::TextHelper. The solution is to include the correct helper. I've also added tests for `#markup_unsafe` because they were missing.
* | | | | | | | | | Add a rubocop for Rails.loggerMayra Cabrera2019-07-101-0/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Suggests to use a JSON structured log instead Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/54102
* | | | | | | | | | Merge branch ↵Stan Hu2019-07-101-9/+56
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'backstage/gb/improve-performance-environment-statuses-endpoint' into 'master' Improve performance of fetching environments statuses Closes #62589 See merge request gitlab-org/gitlab-ce!30560
| * | | | | | | | | | Resolve Gitaly N+1 for CI/CD environments statusesGrzegorz Bizon2019-07-101-2/+2
| | | | | | | | | | |
| * | | | | | | | | | Add additional test case for Gitaly N+1 for diff filesGrzegorz Bizon2019-07-101-36/+65
| | | | | | | | | | |
| * | | | | | | | | | Add a test for `ci_environments_status` Gitaly N+1Grzegorz Bizon2019-07-101-16/+34
| | | | | | | | | | |
* | | | | | | | | | | Remove deleteNote from notes serviceWinnie Hellmann2019-07-101-11/+9
| |_|_|_|_|_|_|_|_|/ |/| | | | | | | | |
* | | | | | | | | | Add routing spec for deploy_tokens controllerDmitriy Zaporozhets2019-07-101-0/+6
| |_|/ / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
* | | | | | | | | Merge branch '63044-cluster-health-group-refactor' into 'master'Douglas Barbosa Alexandre2019-07-102-19/+18
|\ \ \ \ \ \ \ \ \ | |_|_|_|_|_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor common_metrics importer into a more extensible pattern Closes #63044 See merge request gitlab-org/gitlab-ce!30012
| * | | | | | | | Remove unnecessary let in spec63044-cluster-health-group-refactorRyan Cobb2019-07-091-6/+3
| | | | | | | | |
| * | | | | | | | Rename Gitlab::Importers moduleRyan Cobb2019-07-092-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In order to avoid confusion between Gitlab::Importers module and other like named modules, this renamed it to Gitlab::DatabaseImporters.
| * | | | | | | | Remove CommonMetricsImporter patchRyan Cobb2019-07-092-18/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove CommonMetricsImporter patch and change all references to CommonMetrics::Importer. Move specs into their appropriate folders. Also cleans up some common_metric importer namespacing.
| * | | | | | | | Move importers to lib folderRyan Cobb2019-07-091-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This moves our metric importers into the lib folder. This will allow them to be autoloaded instead of having to explicitly require them.
| * | | | | | | | Refactor common metrics importerRyan Cobb2019-07-091-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This refactors common metrics importer for two reasons. 1. To create a new pattern that can be followed by future importers that will minimize dependency collision and 2. To allow EE to more easily extend dependencies.
* | | | | | | | | Merge branch 'prepare-cycle-analytics-for-group-level' into 'master'Douglas Barbosa Alexandre2019-07-1010-13/+19
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prepare cycle analytics for group level See merge request gitlab-org/gitlab-ce!30356
| * | | | | | | | | Add newline before subjectprepare-cycle-analytics-for-group-levelMałgorzata Ksionek2019-07-106-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix rubocop offences