summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Revert "DB change, migratoin and changelog"Lee Tickett2019-09-033-19/+23
| | | | This reverts commit af5242ecb682189c5d8276e1ab1ffe5ce844f2e5.
* Revert "DB change, migratoin and changelog"Lee Tickett2019-09-031-3/+3
| | | | This reverts commit af5242ecb682189c5d8276e1ab1ffe5ce844f2e5.
* Merge branch '13988-add-rails-helpers' into 'master'Stan Hu2019-09-033-7/+16
|\ | | | | | | | | | | | | Add new RailsHelpers module for specs Closes #66688 See merge request gitlab-org/gitlab-ce!32309
| * Use new RailsHelpers module13988-add-rails-helpersAsh McKenzie2019-08-282-7/+9
| |
| * Add new RailsHelpers module for specsAsh McKenzie2019-08-281-0/+7
| |
* | Uses spec_helper instead of rails_helperMayra Cabrera2019-09-031-1/+1
| | | | | | | | | | spec/rails_helper.rb was removed on 1068ec2e9201af3de1fc5ebe9c8d9f7953c89b51
* | Merge branch '62591-fix-milestone-due-date-today-wording' into 'master'Nick Thomas2019-09-031-0/+22
|\ \ | | | | | | | | | | | | | | | | | | Fix wording on milestone due date today Closes #62591 See merge request gitlab-org/gitlab-ce!32096
| * | Fix wording on milestone due date today62591-fix-milestone-due-date-today-wordingAlexandru Croitor2019-09-031-0/+22
| | | | | | | | | | | | | | | Fix wording on milestone due date, to show today instead of hours ago or remaining, when milestone is due today.
* | | Merge branch '66741-remove-spec-rails_helper-rb' into 'master'Grzegorz Bizon2019-09-03239-239/+237
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Remove spec/rails_helper.rb Closes #66741 See merge request gitlab-org/gitlab-ce!32380
| * | | Replace rails_helper.rb with spec_helper.rb66741-remove-spec-rails_helper-rbAsh McKenzie2019-08-30239-239/+237
| | | | | | | | | | | | | | | | | | | | rails_helper.rb's only logic was to require spec_helper.rb.
* | | | Merge branch 'ab-routable-nplus1' into 'master'Stan Hu2019-09-031-0/+7
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Preload routes information in Routable See merge request gitlab-org/gitlab-ce!32352
| * | | | Preload routes informationab-routable-nplus1Andreas Brandl2019-09-031-0/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a high frequency N+1 issue: `RoutableActions#find_routable!` is used across many controllers to retrieve e.g. the Project or Namespace by path. The `#find_routable!` method calls `#ensure_canonical_path` which in turn retrieves `#full_path` from the given Routable. This in turn triggers a lookup on `routes`, leading to a high frequency of these queries: ```sql SELECT "routes".* FROM "routes" WHERE "routes"."source_id" = $1 AND "routes"."source_type" = $2 LIMIT $3 ``` This is unnecessary as we already join `routes` in `Routable#find_by_full_path` anyways.
* | | | | Merge branch '66454-utils-parser' into 'master'Kushal Pandya2019-09-031-0/+60
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Creates utility parser for the job log See merge request gitlab-org/gitlab-ce!32555
| * | | | | Creates utils for the job log66454-utils-parserFilipa Lacerda2019-09-031-0/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | With the new job log json format we need a parser on the frontend
* | | | | | Merge branch 'mh/jest-fail-unmocked-requests' into 'master'Kushal Pandya2019-09-034-8/+21
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | | | | | | | | | | | | | Make unmocked requests fail in Jest again See merge request gitlab-org/gitlab-ce!31863
| * | | | | Fix test false passes on unmocked requestsmh/jest-fail-unmocked-requestsMartin Hanzel2019-08-304-8/+21
| | | | | |
* | | | | | Merge branch 'clusterable_cluster_environments_path' into 'master'Jan Provaznik2019-09-031-0/+9
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | | | | | | | | | | | | | Add #environments_cluster_path which will always return nil in CE See merge request gitlab-org/gitlab-ce!32527
| * | | | | Add facade which will always return nil in CEclusterable_cluster_environments_pathThong Kuah2019-09-031-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | This method will be overridden in EE
* | | | | | Merge branch 'winh-quarantine-dashboard_spec' into 'master'Tim Zallmann2019-09-031-1/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Quarantine flaky dashboard_spec.js See merge request gitlab-org/gitlab-ce!32574
| * | | | | | Quarantine flaky dashboard_spec.jswinh-quarantine-dashboard_specWinnie Hellmann2019-09-031-1/+3
| | | | | | |
* | | | | | | Added relationships between Release and MilestoneEtienne Baqué2019-09-0310-0/+216
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Modified schema via migrations. Added one-to-one relationship between the two models. Added changelog file
* | | | | | | Merge branch 'add-pipeline-type-key-in-pipeline-entity' into 'master'Kamil Trzciński2019-09-035-2/+144
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Expose `name` and `merge_request_event_type` in serialized json and predefined variables See merge request gitlab-org/gitlab-ce!32323
| * | | | | | | Add pipeline.type key to PipelineEntityadd-pipeline-type-key-in-pipeline-entityShinya Maeda2019-09-035-2/+144
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit adds pipeline.type key to PipelineEntity. This key will be used in MR widget in the next iteration.
* | | | | | | | Skip set_repo_refs to speed up the testsIgor2019-09-031-1/+0
| | | | | | | |
* | | | | | | | Make flash notifications stickyFatih Acet2019-09-031-11/+1
| |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | This commit also unifies layout structure and remove no_container flag
* | | | | | | Merge branch 'change-role-system-hook' into 'master'Rémy Coutable2019-09-032-2/+31
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add system hooks for project/group membership updates Closes gitlab-ee#12252 See merge request gitlab-org/gitlab-ce!32371
| * | | | | | Add system hooks for project/group membership updatesBrandon Williams2019-09-022-2/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When updating group and project members, new system hooks `user_update_for_group` and `user_update_for_team` will be executed. Fixes https://gitlab.com/gitlab-org/gitlab-ee/issues/12252
* | | | | | | Stub DetectRepositoryLanguagesWorker for all testsIgor2019-09-033-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It performs an expensive operation, but isn't required in most of tests
* | | | | | | Merge branch 'an-use-labkit-correlation-id' into 'master'Ash McKenzie2019-09-031-1/+1
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove all references to Gitlab::CorrelationId See merge request gitlab-org/gitlab-ce!32228
| * | | | | | | Remove all references to Gitlab::CorrelationIdan-use-labkit-correlation-idAndrew Newdigate2019-08-261-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This class has been replaced with Labkit::Correlation::CorrelationId
* | | | | | | | If user can push to docker then it can delete tooGiorgenes Gelatti2019-09-032-7/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Extends the permission of $CI_REGISTRY_USER to allow them to delete tags in addition to just pushing. https://gitlab.com/gitlab-org/gitlab-ce/issues/40096
* | | | | | | | Merge branch '66393-proposal-remove-area-chart-in-favor-of-time-series' into ↵66914-security-dashboard-component-replace-main-tag-with-article-tagTim Zallmann2019-09-021-265/+0
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'master' Remove area chart in favor of time series Closes #66393 See merge request gitlab-org/gitlab-ce!32129
| * | | | | | | Remove area.vue component66393-proposal-remove-area-chart-in-favor-of-time-seriesMiguel Rincon2019-08-241-265/+0
| | | | | | | |
* | | | | | | | Add X-GitLab-NotificationReason header to note emailsadd-notification-reason-to-note-emailsSean McGivern2019-09-021-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The 'assigned' reason doesn't apply to notes, but the other two can ('mentioned' and 'own_activity'), so we can still use this for note emails.
* | | | | | | | Update Mermaid to v8.2.6Stan Hu2019-09-021-1/+13
| |_|_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a regression where an underscore in labels no longer worked: https://github.com/knsv/mermaid/releases
* | | | | | | Handle :9090 and 0.0.0.0:9090 listen_address formatsReuben Pereira2019-09-021-1/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prometheus listen_address can be in formats of :9090 and 0.0.0.0:9090. But before these can be used to connect a project to Prometheus, they have to converted into absolute URIs.
* | | | | | | Merge branch '65152-unfolded-lines-perf-improvement' into 'master'Douwe Maan2019-09-021-0/+14
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Support selective highlighting of lines See merge request gitlab-org/gitlab-ce!32514
| * | | | | | | Support selective highlighting of lines65152-unfolded-lines-perf-improvementPatrick Bajao2019-09-021-0/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of highlighting all lines when not all of them are needed, only highlight from the beginning up to the specified limit. The `BlobPresenter#highlight` method has been updated to support `to` param. This param will be used to limit the content to be highlighted.
* | | | | | | | Merge branch '66803-fix-uploads-relative-link-filter' into 'master'Grzegorz Bizon2019-09-022-91/+36
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix permissions check in `RelativeLinkFilter` See merge request gitlab-org/gitlab-ce!32448
| * | | | | | | | Fix upload URLs in Markdown66803-fix-uploads-relative-link-filterHeinrich Lee Yu2019-09-022-91/+36
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes RelativeLinkFilter for users that don't have access to the project's repository
* | | | | | | | Fixing #65389Massimeddu Cireddu2019-09-021-3/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Wrong format on MS Teams integration push events with multi line commit messages
* | | | | | | | quick action label must be first in issue commentManeschi Romain2019-09-021-0/+17
| | | | | | | |
* | | | | | | | Rename shared examples according to our guidelines14756-move-shared-examplesRémy Coutable2019-09-022-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | | | | | | | Merge branch 'fix-peek-on-puma' into 'master'Rémy Coutable2019-09-023-15/+15
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix Peek on Puma Closes #66528 See merge request gitlab-org/gitlab-ce!32213
| * | | | | | | | Make performance bar enabled checks consistentSean McGivern2019-08-283-15/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, we called the `peek_enabled?` method like so: prepend_before_action :set_peek_request_id, if: :peek_enabled? Now we don't have a `set_peek_request_id` method, so we don't need that line. However, the `peek_enabled?` part had a side-effect: it would also populate the request store cache for whether the performance bar was enabled for the current request or not. This commit makes that side-effect explicit, and replaces all uses of `peek_enabled?` with the more explicit `Gitlab::PerformanceBar.enabled_for_request?`. There is one spec that still sets `SafeRequestStore[:peek_enabled]` directly, because it is contrasting behaviour with and without a request store enabled. The upshot is: 1. We still set the value in one place. We make it more explicit that that's what we're doing. 2. Reading that value uses a consistent method so it's easier to find in future.
* | | | | | | | | Merge branch '50013-add-browser-platform-flags-sign-in-pages' into 'master'Filipa Lacerda2019-09-021-0/+8
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add CSS & JS global flags to represent browser and platform on login pages See merge request gitlab-org/gitlab-ce!32521
| * | | | | | | | | Add browser and platform flagsKushal Pandya2019-09-021-0/+8
| | |/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Adds CSS classes to represent browser & platform - Adds JS flags to `gl` object to represent browser & platform
* | | | | | | | | Merge branch '65304-add-pages-first-deployment-message' into 'master'Filipa Lacerda2019-09-021-0/+6
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Improve pages load wait time experience" Closes #65304 See merge request gitlab-org/gitlab-ce!32122
| * | | | | | | | Add warning about Pages initial deployment delay65304-add-pages-first-deployment-messageNathan Friend2019-08-301-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit adds a warning message that is always displayed that informs users that their GitLab Pages sites will take a bit of time before they can be accessed after being deployed for the first time.
* | | | | | | | | Merge branch 'sh-fix-ci-lint-500-error' into 'master'Ash McKenzie2019-09-021-0/+6
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix 500 error in CI lint when included templates are an array Closes #66605 See merge request gitlab-org/gitlab-ce!32232