summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Add feature spec for search with spacefe-fix-merge-url-params-with-plusminghuan lei2019-08-191-5/+25
|
* Fix mergeUrlParams handling of `+`Paul Slaughter2019-08-191-0/+6
| | | | | | **What was the issue?** If a param value had `+`, it would be encoded as a literal `+` instead of a space.
* Clean Sidekiq metrics from multiproc dir on startAleksei Lipniagov2019-08-191-0/+51
| | | | | | | After moving the multiproc dir cleanup into `config.ru`:`warmup`, we stopped cleaning Sidekiq metrics dir which is not correct. This MR intended to fix that. More details: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31668
* Add warning when LE certificate can't be obtained64630-add-warning-to-pages-domains-that-obtaining-deploying-ssl-certificates-through-let-s-encrypt-can-take-some-timeVladimir Shushlin2019-08-192-4/+70
| | | | * Refactor some tests as well
* Move cycle analytics stages templates to vueEzekiel Kigbo2019-08-191-0/+177
| | | | | | | | | | The existing stage list items are rendered in haml, migrating them to vuejs for future work. Fix alignment of median value Test for stage_nav_item.vue
* Fix pipelines not always being created after a pushsh-fix-pipelines-not-being-createdStan Hu2019-08-171-0/+16
| | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31741 introduced a regression where not all the right parameters would be passed into `Ci::CreatePipelineService`. We fix this by breaking out the pipeline parameters and reusing a method from `Gitlab::DataBuilder::Push`. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66196
* UI for disabling group/project email notificationBrett Walker2019-08-178-0/+137
| | | | | | - Adds UI to configure in group and project settings - Removes notification configuration for users when disabled at group or project level
* Merge branch 'legacy-attachments-migrate-fix' into 'master'Michael Kozono2019-08-163-4/+360
|\ | | | | | | | | Migrate legacy uploads rake tasks See merge request gitlab-org/gitlab-ce!29409
| * Add rake tasks for migrating leacy uploadslegacy-attachments-migrate-fixJarka Košanová2019-08-163-4/+360
| | | | | | | | | | - move uploads created by AttachmentUploader - handle also files created for legacy_diff_notes
* | Merge branch '66023-starrers-count-do-not-match-after-searching' into 'master'Stan Hu2019-08-161-40/+112
|\ \ | | | | | | | | | | | | Fix starrers counts after searching See merge request gitlab-org/gitlab-ce!31823
| * | Fix starrers counters after searchingDouglas Barbosa Alexandre2019-08-151-40/+112
| | |
* | | Merge branch 'dm-process-commit-worker-n+1' into 'master'Stan Hu2019-08-162-50/+60
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Look up upstream commits once before queuing ProcessCommitWorkers Closes #65464 See merge request gitlab-org/gitlab-ce!31871
| * | | Look up upstream commits once before queuing ProcessCommitWorkersDouwe Maan2019-08-162-50/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of checking if a commit already exists in the upstream project in its ProcessCommitWorker and bailing out if it does, we check the existence of all commits in bulk in Git::BranchHooksService, so that we can skip scheduling ProcessCommitWorker jobs for those commits that already exist upstream entirely.
* | | | Expire project caches once per push instead of once per refStan Hu2019-08-165-12/+144
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously `ProjectCacheWorker` would be scheduled once per ref, which would generate unnecessary I/O and load on Sidekiq, especially if many tags or branches were pushed at once. `ProjectCacheWorker` would expire three items: 1. Repository size: This only needs to be updated once per push. 2. Commit count: This only needs to be updated if the default branch is updated. 3. Project method caches: This only needs to be updated if the default branch changes, but only if certain files change (e.g. README, CHANGELOG, etc.). Because the third item requires looking at the actual changes in the commit deltas, we schedule one `ProjectCacheWorker` to handle the first two cases, and schedule a separate `ProjectCacheWorker` for the third case if it is needed. As a result, this brings down the number of `ProjectCacheWorker` jobs from N to 2. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52046
* | | | Remove Security Dashboard feature flagrossfuhrman2019-08-161-5/+0
| | | | | | | | | | | | | | | | This removes the group_overview_security_dashboard feature flag
* | | | Add clipboard button to metric chart dropdownTristan Read2019-08-162-2/+86
| | | | | | | | | | | | | | | | | | | | Adds a clipboard button to the metrics dashboard, that allows copying a link to an individual chart.
* | | | Merge branch 'mc/feature/pipeline-tracking-config-ce' into 'master'Kamil Trzciński2019-08-165-7/+40
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add `needs:` CI config option CE Closes gitlab-ee#12334 See merge request gitlab-org/gitlab-ce!31346
| * | | | Port changes from EEmc/feature/pipeline-tracking-config-ceMatija Čupić2019-08-045-7/+40
| | | | | | | | | | | | | | | | | | | | | | | | | Ports changes from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/12343
* | | | | Merge branch 'fix/commits-api-empty-refname' into 'master'Nick Thomas2019-08-161-0/+6
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fix handling of empty ref_name parameter string in commits api Closes #64745 See merge request gitlab-org/gitlab-ce!31687
| * | | | | remove encoding comment created by emacs ruby-modeArmin Hohenegger2019-08-131-1/+0
| | | | | |
| * | | | | add a test for empty ref_name to api commits specArmin Hohenegger2019-08-131-0/+7
| | | | | |
* | | | | | Merge branch '56130-deployment-date' into 'master'Grzegorz Bizon2019-08-162-0/+6
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Expose finished_at for the Deployment entity See merge request gitlab-org/gitlab-ce!31808
| * | | | | | Add finished_at to the internal API Deployment entity56130-deployment-dateKrasimir Angelov2019-08-152-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/56130.
* | | | | | | Merge branch ↵Grzegorz Bizon2019-08-165-29/+256
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '47003-user-onboarding-replace-current-email-confirmation-flow-with-a-soft-email-confirmation-flow' into 'master' Soft email confirmation flow Closes #47003 See merge request gitlab-org/gitlab-ce!31245
| * | | | | | | Fix invite specAlex Buijs2019-08-081-14/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The invitation flow changed a bit, because now there is no more need to sign in after confirming. When signing up with a different email address, the user will see the invitation page straight after signing up when redirected, without needing to sign in.
| * | | | | | | Add some feature specsAlex Buijs2019-08-081-0/+35
| | | | | | | |
| * | | | | | | Don't redirect to the Almost there pageAlex Buijs2019-08-082-15/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't redirect to the Almost there page after registration and after resending confirmation instructions
| * | | | | | | Add ConfirmEmailWarning concernAlex Buijs2019-08-081-0/+98
| | | | | | | |
* | | | | | | | Merge branch 'dm-fix-quarantined-spec' into 'master'Nick Thomas2019-08-161-5/+2
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix quarantined spec by waiting for requests Closes #65329 See merge request gitlab-org/gitlab-ce!31862
| * | | | | | | | Fix quarantined spec by waiting for requestsdm-fix-quarantined-specDouwe Maan2019-08-151-5/+2
| | |_|_|_|/ / / | |/| | | | | |
* | | | | | | | Rewrite changed_file_icon_spec in JestPaul Slaughter2019-08-162-63/+123
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Uses vue-test-utils - More complete coverage with parameterized tests
* | | | | | | | Add feature specs for multiple group issue boardsFelipe Artur2019-08-162-0/+159
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add feature specs for multiple issue boards for groups
* | | | | | | | Merge branch 'fe-add-unbinds-to-discussion-keyboard-navigator' into 'master'Kushal Pandya2019-08-161-0/+27
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add key unbinds to DiscussionKeyboardNavigator See merge request gitlab-org/gitlab-ce!31857
| * | | | | | | | Add key unbinds to DiscussionKeyboardNavigatorfe-add-unbinds-to-discussion-keyboard-navigatorPaul Slaughter2019-08-151-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also adds comment to explain why this works on the diff-tab when it's only used in `notes-app`. https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30144#note_204066538
* | | | | | | | | Merge branch '24705-multi-selection-for-delete-on-registry-page' into 'master'Thong Kuah2019-08-154-33/+196
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Multi selection for delete on registry page" Closes #24705 See merge request gitlab-org/gitlab-ce!30837
| * | | | | | | | | Adjustments to event removal and modal descriptionNick Kipling2019-07-301-0/+1
| | | | | | | | | |
| * | | | | | | | | Reworked how deletion works with multi vs singleNick Kipling2019-07-301-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Single deletion no longer requires a prop Modal description is now generated on demand Added dedicated functions for deleting Updated tests to match new function naming Updated css class name to be more specific
| * | | | | | | | | Applying feedback changesNick Kipling2019-07-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Updated table registry to remove singleItemToBeDeleted Renamed usages of idx to index Tidied and simplified css styling Added clarification comment to test regex Updated pot file
| * | | | | | | | | Updated select all to be more explicitNick Kipling2019-07-301-11/+8
| | | | | | | | | |
| * | | | | | | | | Updating with suggestions as per reviewNick Kipling2019-07-301-30/+53
| | | | | | | | | |
| * | | | | | | | | Updating table_registry testsNick Kipling2019-07-301-6/+12
| | | | | | | | | |
| * | | | | | | | | Support bulk registry tag deleteGiorgenes Gelatti2019-07-301-0/+33
| | | | | | | | | |
| * | | | | | | | | Implement multi select deletion for container registryNick Kipling2019-07-303-17/+119
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added checkboxes to each image row Added delete selected images button Changed row delete button to appear on row hover Changed confirmation modal message Changed delete logic to support multi Added tests for multi select Updated pot file Updated rspec test for new functionality
* | | | | | | | | | Support query parameters in metrics embedsSarah Yasonik2019-08-153-10/+61
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/issues/62971 Adds support for embedding specific charts from the metrics dashboard. Expected parameters are dashboard, title, group, and y_label.
* | | | | | | | | | Squash project templates on updateHordur Freyr Yngvason2019-08-152-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As per https://gitlab.com/gitlab-org/gitlab-ce/issues/46043, project templates should be squashed before updating, so that repositories created from these templates don't include the full history of the backing repository.
* | | | | | | | | | Merge branch 'sh-fix-discussions-spec' into 'master'Mayra Cabrera2019-08-151-3/+5
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix failing N+1 spec in spec/requests/api/discussions_spec.rb See merge request gitlab-org/gitlab-ce!31865
| * | | | | | | | | | Fix failing N+1 spec in spec/requests/api/discussions_spec.rbStan Hu2019-08-151-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This test was failing in EE because the API helper `get()` creates a personal access token each time it's run. We can avoid that by pre-creating a personal access token and passing it each time.
* | | | | | | | | | | Migrations for Cycle Analytics backendAdam Hegyi2019-08-153-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change lays the foundation for customizable cycle analytics stages. The main reason for the change is to extract the event definitions to separate objects (start_event, end_event) so that it could be easily customized later on.
* | | | | | | | | | | Only read rebase status from the modelNick Thomas2019-08-152-40/+1
|/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior to 12.1, rebase status was looked up directly from Gitaly. In https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14417 , a DB column was added to track the status instead. However, we couldn't stop looking at the gitaly status immediately, since some rebases may been running across the upgrade. Now that we're in 12.3, it is safe to remove the direct-to-gitaly lookup. This also happens to fix a 500 error that is seen when viewing an MR for a fork where the source project has been removed. We still look at the Gitaly status in the service, just in case Gitaly and Sidekiq get out of sync - I assume this is possible, and it's a relatively cheap check. Since we atomically check and set `merge_requests.rebase_jid`, we should never enqueue two `RebaseWorker` jobs in parallel.
* | | | | | | | | | Removes db/fixtures from database filesMayra Cabrera2019-08-151-4/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will avoid Danger to suggest a database review for files inside db/fixtures