summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
...
| | | * | | | | | | | Simplify implementation of build artifacts browser (refactoring)Grzegorz Bizon2016-01-142-58/+10
| | | | | | | | | | |
| | | * | | | | | | | Change format of artifacts metadata from text to binary 0.0.1Grzegorz Bizon2016-01-142-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This changes the format of metadata to handle paths, that may contain whitespace characters, new line characters and non-UTF-8 characters. Now those paths along with metadata in JSON format are stored as length-prefixed strings (uint32 prefix). Metadata file has a custom format: 1. First string field is metadata version field (string) 2. Second string field is metadata errors field (JSON strong) 3. All subsequent fields is pair of path (string) and path metadata in JSON format. Path's metadata contains all fields that where possible to extract from ZIP archive like date of modification, CRC, compressed size, uncompressed size and comment.
| | | * | | | | | | | Update build specs for artifacts browser supportGrzegorz Bizon2016-01-141-12/+11
| | | | | | | | | | |
| | | * | | | | | | | Show file size in artifacts browser using metadataGrzegorz Bizon2016-01-141-1/+1
| | | | | | | | | | |
| | | * | | | | | | | Add method that checks if path exists in `StringPath`Grzegorz Bizon2016-01-141-0/+13
| | | | | | | | | | |
| | | * | | | | | | | Render 404 when artifacts path is invalidGrzegorz Bizon2016-01-141-2/+4
| | | | | | | | | | |
| | | * | | | | | | | Do not depend on universe when checking parent in `StringPath`Grzegorz Bizon2016-01-141-1/+16
| | | | | | | | | | |
| | | * | | | | | | | Extract artifacts metadata implementation to separate classGrzegorz Bizon2016-01-141-0/+76
| | | | | | | | | | |
| | | * | | | | | | | Improve path sanitization in `StringPath`Grzegorz Bizon2016-01-141-1/+0
| | | | | | | | | | |
| | | * | | | | | | | Parse artifacts metadata stored in JSON formatGrzegorz Bizon2016-01-141-0/+16
| | | | | | | | | | |
| | | * | | | | | | | Update artifacts metadata fixtureGrzegorz Bizon2016-01-141-0/+0
| | | | | | | | | | |
| | | * | | | | | | | Add artifacts metadata uploader filedGrzegorz Bizon2016-01-141-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Artifacts metadata field will be used to store a filename of gzipped file containing metadata definition for given artifacts archive.
| | | * | | | | | | | Update artifacts download specsGrzegorz Bizon2016-01-141-2/+6
| | | | | | | | | | |
| | | * | | | | | | | Add method that checks if artifacts browser is supportedGrzegorz Bizon2016-01-141-0/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is needed because of backward compatibility. Previously artifacts archive had `.tar.gz` format, but artifacts browser requires ZIP format now.
| | | * | | | | | | | Update specs for CI Build, add `artifacts?` methodGrzegorz Bizon2016-01-141-26/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `artifacts?` method checks if artifacts archive is available.
| | | * | | | | | | | Rename method that returns url to CI build artifacts downloadGrzegorz Bizon2016-01-141-2/+2
| | | | | | | | | | |
| | | * | | | | | | | Seed db with CI build artifacts using a zip archiveGrzegorz Bizon2016-01-142-0/+0
| | | | | | | | | | |
| | | * | | | | | | | Fix rubocop offenses in `StringPath` specsGrzegorz Bizon2016-01-141-11/+19
| | | | | | | | | | |
| | | * | | | | | | | Add support for parent directories in `StringPath`Grzegorz Bizon2016-01-141-4/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This support is not completed though, as parent directory that is first in collection returned by `directories!` is not iterable yet.
| | | * | | | | | | | Add support for root path for `StringPath`Grzegorz Bizon2016-01-141-1/+23
| | | | | | | | | | |
| | | * | | | | | | | Add implementation of remaining methods in `StringPath`Grzegorz Bizon2016-01-141-10/+43
| | | | | | | | | | |
| | | * | | | | | | | Improve `StringPath` specs (DRY)Grzegorz Bizon2016-01-141-10/+19
| | | | | | | | | | |
| | | * | | | | | | | Add `parent` iteration implementation to `StringPath`Grzegorz Bizon2016-01-141-1/+10
| | | | | | | | | | |
| | | * | | | | | | | Add new methods to StringPathGrzegorz Bizon2016-01-141-1/+32
| | | | | | | | | | |
| | | * | | | | | | | Add implementation of StringPath classGrzegorz Bizon2016-01-141-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `StringPath` class is something similar to Ruby's `Pathname` class, but does not involve any IO operations. `StringPath` objects require passing string representation of path, and array of paths that represents universe to constructor to be intantiated.
| | | * | | | | | | | Add CI build artifacts tarball as a spec fixtureGrzegorz Bizon2016-01-141-0/+0
| | | | | | | | | | |
| * | | | | | | | | | Merge branch 'master' into ci/api-triggersTomasz Maczukin2016-01-142-0/+204
| |\ \ \ \ \ \ \ \ \ \ | | |/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: Fix version Improve the consistency of commit titles, branch names, tag names, issue/MR titles, on their respective project pages Update CHANGELOG [ci skip] Add some cosmetic changes to variables API documentation [ci skip] Modify builds API documentation style [ci skip] Modify :ci_variable factory Add 'Build' prefix to Variables entry name in API docs index Fix some typos Add some fixes after review Remove blank line Update ./doc/api Change :variable_id to :key as resource ID in API Fix a typo in method description Add create feature to variables API Add missing 'not_found' checks in variables API Add delete feature to variables API Add update feature for variables API Add features for list and show details of variables in API Conflicts: doc/api/README.md lib/api/entities.rb
| | * | | | | | | | | Merge branch 'master' into ci/api-variablesDouwe Maan2016-01-1412-75/+377
| | |\ \ \ \ \ \ \ \ \ | | | |/ / / / / / / /
| | * | | | | | | | | Merge branch '8-4-stable' into ci/api-variablesTomasz Maczukin2016-01-1368-675/+1454
| | |\ \ \ \ \ \ \ \ \ | | | | |_|_|_|_|_|_|/ | | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * 8-4-stable: (285 commits) Add Changelog entry for build traces data integrity fix Update doc_styleguide.md [ci skip] Added hint that you can search users by name, username, or email. Add changelog Version 8.4.0.rc1 Randomize metrics sample intervals Make the metrics sampler interval configurable Don't automatically require awesome_print Disable colorization if STDOUT is not a tty Block the reported user before destroying the record changes `$quote-gray` to `$secondary-text` makes message plural for multiple MRs and removes from loop. Duh. Prepare Installation and Update docs for 8.4 RC1 Mention channel/key bug in irkerd docs Revert "Remove the `:coffee` and `:coffeescript` Haml filters" gets merge request discussion working again adds back in discussion.haml.html for issues commenting and closing/reopening properly. removing last chunk of MR ajax changes, rest will be in another MR reverting more MR ajax files, will appear in different commit reverting MR ajax changes, which will be in a different MR ...
| | * | | | | | | | | Modify :ci_variable factoryTomasz Maczukin2016-01-132-7/+4
| | | | | | | | | | |
| | * | | | | | | | | Change :variable_id to :key as resource ID in APITomasz Maczukin2016-01-071-27/+15
| | | | | | | | | | |
| | * | | | | | | | | Add create feature to variables APITomasz Maczukin2015-12-312-1/+39
| | | | | | | | | | |
| | * | | | | | | | | Add missing 'not_found' checks in variables APITomasz Maczukin2015-12-311-0/+18
| | | | | | | | | | |
| | * | | | | | | | | Add delete feature to variables APITomasz Maczukin2015-12-311-1/+28
| | | | | | | | | | |
| | * | | | | | | | | Add update feature for variables APITomasz Maczukin2015-12-311-8/+44
| | | | | | | | | | |
| | * | | | | | | | | Add features for list and show details of variables in APITomasz Maczukin2015-12-312-0/+100
| | | | | | | | | | |
| * | | | | | | | | | Merge branch 'master' into ci/api-triggersTomasz Maczukin2016-01-1412-75/+377
| |\ \ \ \ \ \ \ \ \ \ | | | |_|/ / / / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * master: (32 commits) Fix specs and rubocop warnings fixed LDAP activation on login to use new ldap_blocked state Fix Admin/Users view to position buttons without spacing magic Update to Go 1.5.3 Fix the undefinded variable error in Project's safe_import_url method Fix misaligned edit button in milestone collection partial Update button styles for Milestones#show Ensure the API doesn't return notes that the current user shouldn't see Add spec for Note#cross_reference_not_visible_for? Remove (invalid) timestamp formatting Move `BroadcastMessage#status` to a helper since it's presentational Update CHANGELOG Broadcast Messages can now be edited Update Broadcast Message features Update BroadcastMessage model Update broadcast_message helper Simplify BroadcastMessage factory Simplify broadcast message JS Remove alert_type attribute from BroadcastMessage Move broadcast message form to a partial ...
| | * | | | | | | | | Merge branch 'feature/ldap-sync-edgecases' into 'master' Douwe Maan2016-01-147-51/+173
| | |\ \ \ \ \ \ \ \ \ | | | |_|_|_|/ / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | LDAP Sync blocked user edgecases Allow GitLab admins to block otherwise valid GitLab LDAP users (https://gitlab.com/gitlab-org/gitlab-ce/issues/3462) Based on the discussion on the original issue, we are going to differentiate "normal" block operations to the ldap automatic ones in order to make some decisions when its one or the other. Expected behavior: - [x] "ldap_blocked" users respond to both `blocked?` and `ldap_blocked?` - [x] "ldap_blocked" users can't be unblocked by the Admin UI - [x] "ldap_blocked" users can't be unblocked by the API - [x] Block operations that are originated from LDAP synchronization will flag user as "ldap_blocked" - [x] Only "ldap_blocked" users will be automatically unblocked by LDAP synchronization - [x] When LDAP identity is removed, we should convert `ldap_blocked` into `blocked` Mockup for the Admin UI with both "ldap_blocked" and normal "blocked" users: ![image](/uploads/4f56fc17b73cb2c9e2a154a22e7ad291/image.png) There will be another MR for the EE version. See merge request !2242
| | | * | | | | | | | fixed LDAP activation on login to use new ldap_blocked statefeature/ldap-sync-edgecasesGabriel Mazetto2016-01-141-3/+2
| | | | | | | | | | |
| | | * | | | | | | | Codestyle changesGabriel Mazetto2016-01-121-2/+2
| | | | | | | | | | |
| | | * | | | | | | | Code style fixes and some code simplifiedGabriel Mazetto2016-01-081-1/+1
| | | | | | | | | | |
| | | * | | | | | | | Repair ldap_blocked state when no ldap identity exist anymoreGabriel Mazetto2016-01-083-0/+87
| | | | | | | | | | |
| | | * | | | | | | | LDAP synchronization block/unblock new statesGabriel Mazetto2016-01-081-20/+14
| | | | | | | | | | |
| | | * | | | | | | | Prevent ldap_blocked users from being blocked/unblocked by the APIGabriel Mazetto2016-01-081-5/+18
| | | | | | | | | | |
| | | * | | | | | | | Prevent ldap_blocked users from being unblocked by the Admin UIGabriel Mazetto2016-01-081-9/+26
| | | | | | | | | | |
| | | * | | | | | | | Add ldap_blocked as new state to users state machineGabriel Mazetto2016-01-081-16/+28
| | | | | | | | | | |
| | * | | | | | | | | Merge branch 'fix/private-references' into 'master' Douwe Maan2016-01-142-0/+76
| | |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Show referenced MRs & Issues only when the current viewer can access them This addresses both issues identified in #6066. ## The private MR by user `remy2` with a note referencing to a public issue ![Screen_Shot_2016-01-12_at_16.45.02](/uploads/c245ec2c1fdea1f9ba05183c24e142d9/Screen_Shot_2016-01-12_at_16.45.02.png) --- ## The public issue viewed by user `remy` **who doesn't have access to `remy2/private-project`** before the fix ![Screen_Shot_2016-01-12_at_18.14.50](/uploads/8db5580e803f5bddd6cb935233c579a0/Screen_Shot_2016-01-12_at_18.14.50.png) --- ## The public issue viewed by user `remy` **who doesn't have access to `remy2/private-project`** with the fix ![Screen_Shot_2016-01-13_at_12.02.32](/uploads/cb199f7b78191fba486a11412412e307/Screen_Shot_2016-01-13_at_12.02.32.png) --- ## The public issue viewed by user `remy2` with the fix (no change) ![Screen_Shot_2016-01-13_at_11.54.06](/uploads/ddece590d69f597a95559beddcd36660/Screen_Shot_2016-01-13_at_11.54.06.png) See merge request !2405
| | | * | | | | | | | | Fix specs and rubocop warningsfix/private-referencesRémy Coutable2016-01-142-7/+8
| | | | | | | | | | | |
| | | * | | | | | | | | Merge branch 'master' of https://gitlab.com/gitlab-org/gitlab-ce into ↵Rémy Coutable2016-01-138-39/+84
| | | |\ \ \ \ \ \ \ \ \ | | | | | |_|/ / / / / / | | | | |/| | | | | | | | | | | | | | | | | | | fix/private-references
| | | * | | | | | | | | Ensure the API doesn't return notes that the current user shouldn't seeRémy Coutable2016-01-131-0/+51
| | | | | | | | | | | |