summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
...
| | * | | | | Cache Flipper persisted names directly to local memory storagesh-cache-flipper-names-memory-cacheStan Hu2019-07-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that application settings are no longer dominating network traffic, we see that the Feature#persisted_names is using a significant amount of CPU and network bandwidth for Redis. Move this cache into the thread-local memory storage to reduce Redis overhead.
| * | | | | | Includes logic to persist namespace statisticsMayra Cabrera2019-07-029-4/+502
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Add two new ActiveRecord models: - RootNamespaceStoragestatistics will persist root namespace statistics - NamespaceAggregationSchedule will save information when a new update to the namespace statistics needs to be scheduled - Inject into UpdateProjectStatistics concern a new callback that will call an async job to insert a new row onto NamespaceAggregationSchedule table - When a new row is inserted a new job is scheduled. This job will update call an specific service to update the statistics and after that it will delete thee aggregated scheduled row - The RefresherServices makes heavy use of arel to build composable queries to update Namespace::RootStorageStatistics attributes. - Add an extra worker to traverse pending rows on NAmespace::AggregationSchedule table and schedule a worker for each one of this rows. - Add an extra worker to traverse pending rows on NAmespace::AggregationSchedule table and schedule a worker for each one of this rows
| * | | | | Merge branch '59177-squash-old-migrations' into 'master'harish-and-cindy-ssl-check-rake-taskharish-and-cindy-ldap-sync-rake-tasksDmitriy Zaporozhets2019-07-0253-3828/+0
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Squash old migrations Closes #59177 See merge request gitlab-org/gitlab-ce!30226
| | * | | | | Remove background migrations for old schemasNick Thomas2019-07-027-880/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On the assumption that a background migration whose specs need a schema older than 2018 is obsoleted by this migration squash, we can remove both specs and code for those that fail to run in CI as a result of the schema at that date no longer existing. This is true for all but the MigrateStageStatus background migration, which is also used from the MigrateBuildStage background migration.
| | * | | | | Remove migration specs from 201[4567]Nick Thomas2019-07-0246-2948/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Since the migrations are gone, we don't need these specs either
| * | | | | | Registry component now includes error messagesNick Kipling2019-07-022-5/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Includes changes to the Vue container registry component to support the display of an empty message and error message when invalid characters are found in the group, project or branch name. repositories/index.html.haml has been changed to remove the content and place into Vue component.
| * | | | | | Enables ingress for uninstallationJoão Cunha2019-07-022-15/+24
| | |_|/ / / | |/| | | | | | | | | | | | | | | | - JupyterHub must not be available (installed or updated)
| * | | | | Allow adding new entries to existing pathDenys Mishunov2019-07-024-11/+139
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If an entry has been removed from the tree and later, during the same session, a user is trying to add a new item with the same name/path we should allow for that as long as the original entry is marked with `deleted`.
| * | | | | Merge branch 'sh-add-thread-memory-cache' into 'master'Rémy Coutable2019-07-025-45/+55
| |\ \ \ \ \ | | |_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a memory cache local to the thread to reduce Redis load Closes #63977 See merge request gitlab-org/gitlab-ce!30233
| | * | | | Fix failing spec/models/user_spec.rbStan Hu2019-07-021-1/+1
| | | | | |
| | * | | | Use an uncached application setting for usage ping checksStan Hu2019-07-021-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The introduction of the in-memory cache for application settings had a side effect of making it harder to invalidate changes when the settings occur. We now bypass the cache because it's possible the admin enabled the usage ping, and we don't want to annoy the user again if they already set the value. To avoid causing significant load on the system, we add an extra check to ensure the user is an admin. and we don't want to annoy the user again if they already set the value. This is a bit of hack, but the alternative would be to put in a more complex cache invalidation step. Since this call only gets called in the uncommon situation where the user is an admin and the only user in the instance, this shouldn't cause too much load on the system.
| | * | | | Fix broken specs due to cached application settingsStan Hu2019-07-012-39/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The /admin panel will now always return an uncached application setting to ensure it always has the most current info.
| | * | | | Fix specs in spec/models/concerns/cacheable_attributes_spec.rbStan Hu2019-07-011-4/+5
| | | | | |
| | * | | | Add a memory cache local to the thread to reduce Redis loadStan Hu2019-07-011-0/+2
| | | |_|/ | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Loading `ApplicationSetting` from Redis was responsible for at least 50% of the CPU load of the Redis cluster on GitLab.com. Since these values generally don't change very much, we can load this from the database and cache it in memory, skipping Redis altogther. We use `ActiveSupport::Cache::MemoryStore` as a drop-in replacement for `RedisCacheStore` even though we probably don't need synchronized access within `Thread.current`. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63977
| * | | | Merge branch '58808-fix-image-diff-on-text' into 'master'James Lopez2019-07-021-0/+33
| |\ \ \ \ | | |_|/ / | |/| | | | | | | | | | | | | Don't show image diff note on text file See merge request gitlab-org/gitlab-ce!30221
| | * | | Don't show image diff note on text file58808-fix-image-diff-on-textPatrick Bajao2019-07-011-0/+33
| | | | |
| * | | | Merge branch 'project-cluster-spec-improvements' into 'master'Jan Provaznik2019-07-022-44/+19
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Tidy spec for API::ProjectClusters See merge request gitlab-org/gitlab-ce!30154
| | * | | | Tidy spec for API::ProjectClustersproject-cluster-spec-improvementsDylan Griffith2019-07-022-44/+19
| | | | | |
| * | | | | Merge branch '63984-rename-in-folder' into 'master'Kushal Pandya2019-07-021-0/+13
| |\ \ \ \ \ | | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Hid re-named entries in subfolders Closes #63984 See merge request gitlab-org/gitlab-ce!30242
| | * | | | Hid re-named entries in subfolders63984-rename-in-folderDenys Mishunov2019-07-021-0/+13
| | | | | |
| * | | | | Merge branch '82-add-new-onboarding-to-flipper-a-b-testing' into 'master'Nick Thomas2019-07-011-0/+38
| |\ \ \ \ \ | | |/ / / / | |/| | | | | | | | | | | | | | | | Add new onboarding to flipper A/B testing See merge request gitlab-org/gitlab-ce!30125
| | * | | | Add new OnboardingExperimentHelper modulesAsh McKenzie2019-06-281-0/+38
| | |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | OnboardingExperimentHelpers take care of determining if the current_user should or should not see the new onboarding feature.
| * | | | Merge branch '9491-graphql-view-design-board-at-version-ce' into 'master'Nick Thomas2019-07-011-0/+44
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | CE backport for "Show design boards at previous versions in GraphQL" See merge request gitlab-org/gitlab-ce!30151
| | * | | | CE backport for changes in EE MR 142929491-graphql-view-design-board-at-version-ceLuke Duncalfe2019-06-281-0/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | EE MR https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/14292 https://gitlab.com/gitlab-org/gitlab-ee/issues/9491
| * | | | | Merge branch '63590-pipeline-actions-cause-full-refresh' into 'master'Phil Hughes2019-07-011-6/+2
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Pipeline actions cause full refresh" Closes #63590 See merge request gitlab-org/gitlab-ce!30190
| | * | | | | Fix pipelines table update after action63590-pipeline-actions-cause-full-refreshshampton2019-06-281-6/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The pipelines table was showing the loading icon after the user cancelled or retried a pipeline. This fixes that so the pipeline updates without removing the table from the DOM.
| * | | | | | Allow JupyterHub to be uninstalledJoão Cunha2019-07-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - enabled uninstallation - give it a specific uninstall message - ajust specs
| * | | | | | Merge branch 'divergence-graph-api-call' into 'master'Filipa Lacerda2019-07-011-0/+32
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fetch branches divergence graph data through API call Closes #46139 See merge request gitlab-org/gitlab-ce!30068
| | * | | | | | Fetch branch diverging counts from APIPhil Hughes2019-07-011-0/+32
| | | |_|_|/ / | | |/| | | | | | | | | | | | | | | | | | Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/46139
| * | | | | | Merge branch 'test_schema_version_check_directly' into 'master'Robert Speicher2019-07-011-7/+5
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Test schema_version_check directly Closes #63913 See merge request gitlab-org/gitlab-ce!30209
| | * | | | | | Test schema_version_check directlytest_schema_version_check_directlyThong Kuah2019-07-011-7/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Testing via db:migrate causes side-effects like setting ActiveRecord::Base.configurations and also it runs schema dump into db/schema.rb. Rather than keep up, we test schema_version_check directly
| * | | | | | | Merge branch 'sh-fix-issue-63910' into 'master'Sean McGivern2019-07-011-0/+37
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix attachments using the wrong URLs in e-mails Closes #63910 See merge request gitlab-org/gitlab-ce!30197
| | * | | | | | | Fix attachments using the wrong URLs in e-mailssh-fix-issue-63910Stan Hu2019-06-281-0/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29889, only the project context were set for the Markdown renderer. For a note on an issuable, the group context was set to `nil` because `note.noteable.try(:group)` attempted to get the issuable's group, which doesn't exist. To make group notifications work, now both the project and group context are set. The context gets passed to `RelativeLinkFilter`, which previously assumed that it wasn't possible to have both a group and a project in the Markdown context. However, if a group were defined, it would take precedence, and the URL rendered for uploads would be `/group/-/uploads` instead of `/group/project/uploads/`. This led to 404s in e-mails. However, now that we have both project and group in the context, we render the Markdown giving priority to the project context if is set. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/63910
| * | | | | | | | Revert "Include subgroups in shared_projects"Fabian Schneider2019-07-011-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 4bed2daef935bb4097988e0eff4830fc13a23c37.
| * | | | | | | | Merge branch '63863-fix-groups-in-email-subject' into 'master'Sean McGivern2019-07-012-20/+9
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove group in notification email subject Closes #63863 See merge request gitlab-org/gitlab-ce!30214
| | * | | | | | | | Remove group in notification email subjectHeinrich Lee Yu2019-07-012-20/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts to previous behavior where we have the group only when we don't have a project
| * | | | | | | | | Merge branch '58583-confidential-mr-branch-backend' into 'master'Rémy Coutable2019-07-014-99/+253
| |\ \ \ \ \ \ \ \ \ | | |_|_|_|_|_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Support creating an MR/branch on a fork from an issue See merge request gitlab-org/gitlab-ce!29831
| | * | | | | | | | Check if user can `update_issue` on projectPatrick Bajao2019-07-011-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If user can update an issue under the specified confidential issue project, should be able to find the project.
| | * | | | | | | | Fix issues when creating system notes58583-confidential-mr-branch-backendPatrick Bajao2019-06-293-11/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When `confidential_issue_project_id` is set and the issue is under that project, create the a note about branch creation in that project. If not, do nothing. When creating `new_merge_request` system note, set the project where the MR will be referenced from so it'll be linked to when the MR is created in another project.
| | * | | | | | | | Support branch creation from confidential issuePatrick Bajao2019-06-293-132/+158
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Accept a `confidential_issue_project_id` param which will be used for the system note target. This also includes some refactoring on the spec to use shared examples.
| | * | | | | | | | Support creating an MR on a fork from an issuePatrick Bajao2019-06-291-82/+194
| | | | | | | | | |
| * | | | | | | | | Merge branch 'zj-circuit-breaker-removal-part-deux' into 'master'Bob Van Landuyt2019-07-011-20/+0
| |\ \ \ \ \ \ \ \ \ | | |_|_|_|_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove ignored circuit_breaker columns See merge request gitlab-org/gitlab-ce!30159
| | * | | | | | | | Remove ignored circuit_breaker columnsZeger-Jan van de Weg2019-06-281-20/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The circuit breaker itself got removed a while ago, when that happened some parts got left behind. Using grep old stale settings and validations were found and are now removed.
| * | | | | | | | | Merge branch 'id-stale-branches' into 'master'Grzegorz Bizon2019-07-014-42/+84
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add endpoint for fetching diverging commit counts See merge request gitlab-org/gitlab-ce!29802
| | * | | | | | | | | Add endpoint for fetching diverging commit countsid-stale-branchesIgor Drozdov2019-06-284-42/+84
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Extract diverging_commit_counts into a service class
| * | | | | | | | | | Merge branch 'tc-rake-orphan-artifacts' into 'master'Dmitriy Zaporozhets2019-07-013-0/+163
| |\ \ \ \ \ \ \ \ \ \ | | |_|_|_|/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add rake task to clean orphan artifact files See merge request gitlab-org/gitlab-ce!29681
| | * | | | | | | | | Add rake task to clean orphan artifact filestc-rake-orphan-artifactsToon Claes2019-06-283-0/+163
| | | |/ / / / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds the rake task rake gitlab:cleanup:orphan_job_artifact_files. This rake task cleans all orphan job artifact files it can find on disk. It performs a search on the complete folder of all artifacts on disk. Then it filters out all the job artifact ID for which it could not find a record with matching ID in the database. For these, the file is deleted from disk.
| * | | | | | | | | Merge branch '45120-fix-ide-editor-to-update-size-on-show-change' into 'master'Phil Hughes2019-07-011-7/+56
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix IDE editor to update dimensions on show change Closes #45120 See merge request gitlab-org/gitlab-ce!30135
| | * | | | | | | | | Fix IDE editor to update dimensions on show change45120-fix-ide-editor-to-update-size-on-show-changePaul Slaughter2019-06-281-7/+56
| | | | | | | | | | |
| * | | | | | | | | | Merge branch 'add-clusters-to-deployment' into 'master'Lin Jen-Shin2019-07-014-22/+80
| |\ \ \ \ \ \ \ \ \ \ | | |_|_|_|_|_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add clusters association to deployment See merge request gitlab-org/gitlab-ce!29960
View Lorry Controller Status