summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Use a path for the related merge requests endpointsh-fix-related-merge-requests-pathStan Hu2019-05-071-0/+34
| | | | | | | | | | Hosts using a non-standard configuration may have a different hostname/port/scheme than what may be configured on the GitLab server. While expose_url should generate a proper URL, there are cases where it may not work. Since we don't need the full URL, we can use the relative path. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/61280
* Merge branch 'show-disabled-mirrors' into 'master'Nick Thomas2019-05-072-0/+28
|\ | | | | | | | | CE Show disabled project repo mirrors See merge request gitlab-org/gitlab-ce!27326
| * Show disabled project repo mirrorsshow-disabled-mirrorsLuke Bennett2019-05-072-0/+28
| | | | | | | | | | Show disabled mirrors with a badge so that they can be deleted by project owners.
* | Add improvements to the global search processFrancisco Javier López2019-05-075-38/+80
| | | | | | | | | | | | | | Removed the conditions added to Project.with_feature_available_for_user, and moved to the IssuableFinder. Now, we ensure that, in the projects retrieved in the Finder, the user has enough access for the feature.
* | Merge branch 'bvl-fix-ordering-mysql' into 'master'Sean McGivern2019-05-071-5/+5
|\ \ | | | | | | | | | | | | | | | | | | Set created_at and updated_at for sorting specs Closes #61541 See merge request gitlab-org/gitlab-ce!28173
| * | Set created_at and updated_at for sorting specsBob Van Landuyt2019-05-071-5/+5
| | | | | | | | | | | | | | | This makes sure that the results are predictable and the same on both Postgres and MySQL
* | | Merge branch 'sh-cleanup-import-export' into 'master'James Lopez2019-05-071-0/+32
|\ \ \ | |/ / |/| | | | | | | | | | | | | | Clean up CarrierWave's import/export files Closes #60656 See merge request gitlab-org/gitlab-ce!27487
| * | Clean up CarrierWave's import/export filesStan Hu2019-05-071-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Unlike uploads that have been uploaded with Tempfile, the project import/export archives are stored in a temporary cache directory and remain there if: 1. Object storage is enabled 2. `move_to_store` is set to `true`. CarrierWave will leave these files there until disk space runs out or a clean step is run manually. If `move_to_store` is set to `false`, CarrierWave will remove the files after storing them. However, unlike a local file, with object storage, the file is still copied, so setting `move_to_store` to `true` doesn't buy us anything. To ensure files are cleaned up, we can just inherit from the GitlabUploader implementation of `move_to_store`, which returns `true` if it's a local file, `false` otherwise. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60656
* | | Merge branch 'winh-separate-frontend-fixtures' into 'master'Phil Hughes2019-05-075-6/+13
|\ \ \ | |/ / |/| | | | | | | | Generate EE-specific JavaScript fixtures into ee/ directory (CE-backport) See merge request gitlab-org/gitlab-ce!28032
| * | Load EE fixtures from ee/ directory in Jestwinh-separate-frontend-fixturesWinnie Hellmann2019-05-022-4/+7
| | | | | | | | | | | | (cherry picked from commit 2917a28a885922a03f2026ddbb2680bc2b6e5d50)
| * | Load EE fixtures from ee/ directory in KarmaWinnie Hellmann2019-05-021-1/+3
| | | | | | | | | | | | (cherry picked from commit 7cde57bf7367bce130a2e7f149c8dafd362de3f8)
| * | Generate EE frontend fixtures into ee/ directoryWinnie Hellmann2019-05-021-1/+1
| | | | | | | | | | | | (cherry picked from commit d4ce3c720ecb52f2a9153133bbd47fa358c5d7b6)
| * | Ignore PDF and balsamiq fixture filesWinnie Hellmann2019-05-021-0/+2
| | | | | | | | | | | | (cherry picked from commit 1b33828811897b6a3f8a38044cc0839b87098d1f)
* | | Merge branch 'allow-replying-to-individual-notes-from-api' into 'master'James Lopez2019-05-072-8/+20
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Allow replying to an individual note in the API Closes #61392 See merge request gitlab-org/gitlab-ce!28120
| * | | Allow replying to an individual note in the APIallow-replying-to-individual-notes-from-apiSean McGivern2019-05-062-8/+20
| | | | | | | | | | | | | | | | | | | | | | | | If you can do this in the UI, you should be able to do it in the API. If a discussion is not a single note discussion, or it is replyable, you can reply to it.
* | | | Merge branch 'strip-attr-cron-in-pipeline-schedule' into 'master'Grzegorz Bizon2019-05-071-0/+9
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Strip whitespace for PipelineSchedule#cron See merge request gitlab-org/gitlab-ce!27990
| * | | | Strip whitespace for PipelineSchedule#cronstrip-attr-cron-in-pipeline-scheduleFabio Pitino2019-05-021-0/+9
| | | | |
* | | | | Merge branch 'instance_level_clusters' into 'master'Bob Van Landuyt2019-05-0712-23/+846
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Instance level k8s clusters See merge request gitlab-org/gitlab-ce!27196
| * | | | | Remove duplicate clusterable presenter methodinstance_level_clustersJames Fargher2019-05-072-12/+0
| | | | | |
| * | | | | Change specs to match gitlab code standardsJames Fargher2019-05-072-10/+12
| | | | | |
| * | | | | Stop using `go` function in clusters controller specsJames Fargher2019-05-071-54/+54
| | | | | |
| * | | | | Check instance cluster feature at policy levelJames Fargher2019-05-073-5/+64
| | | | | | | | | | | | | | | | | | | | | | | | Try to simplify feature flag checks by using policies
| * | | | | Allow projects to use instance level clustersJames Fargher2019-05-073-8/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There are two cluster hierarchies one for the deployment platform and one for controllers. The main difference is that deployment platforms do not check user permissions and only return the first match.
| * | | | | Instance level kubernetes clusters adminJames Fargher2019-05-077-3/+753
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instance level clusters were already mostly supported, this change adds admin area controllers for cluster CRUD
* | | | | | Merge branch 'sh-fix-activerecord-patch-mark2' into 'master'Stan Hu2019-05-072-10/+32
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Additional fix to handle NULL lock_version See merge request gitlab-org/gitlab-ce!28153
| * | | | | | Additional fix to handle NULL lock_versionsh-fix-activerecord-patch-mark2Stan Hu2019-05-062-10/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the UI sends a string value for lock_version (e.g. "0"), then the previous monkey patch did not properly handle that properly. This commit casts the value to an integer to determine whether to look for NULL lock_versions. For merge requests, GitLab sends a POST request to `namespace/project/merge_requests/:iid` with the `merge_request[lock_version]` parameter with a string `0`. The string value comes from the form field, which explains why https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28145 wasn't sufficient.
* | | | | | | Merge branch '56992-add-filtering-to-project-dashboard-fe' into 'master'Kushal Pandya2019-05-073-0/+235
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolve "Add filtering to project dashboard [FE]" Closes #56992 See merge request gitlab-org/gitlab-ce!25231
| * | | | | | | Added blank lines to meet style guideEzekiel Kigbo2019-05-063-51/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Un-nest title variable output Update spec test names Rename sort_value_most_stars -> sort_value_stars_desc Rename sorted_by_stars -> sorted_by_stars_desc Renname sort_value_most_stars_asc -> sort_value_stars_asc Invert feature check, assign feature condition to a variable Inline conditional nav bar rendering Invert conditional label Added follow up task Fix filters returning 0 projects show the wrong view Move click action out of test expectation Use proper variable name for project in before block Rename projects_sort_admin_options_hash Renamed projects_sort_admin_options_has to old_projects_sort_options_hash as its not only used on the admin screen Fix extra whitespace errors Stub project_list_filter_bar in the projects_helper specs Added follow up task for `show_projects?` Removed url test expectations
| * | | | | | | Update project list specsEzekiel Kigbo2019-05-062-0/+239
| | |_|_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add tests to ensure search only executes with a button click or enter, sort by Name, Last updated, Created date and Stars and tests for Visibility filter
* | | | | | | Merge branch 'fix-schedule-head-pipeline-update-method' into 'master'Ash McKenzie2019-05-071-12/+22
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix update head pipeline process of Pipelines for merge requests See merge request gitlab-org/gitlab-ce!28057
| * | | | | | | Fix schedule head pipeline updatefix-schedule-head-pipeline-update-methodShinya Maeda2019-05-061-12/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, schedule head pipeline update method which executed after pipeline creation does not take into account of merge reqeust pipelines. We should use dedicated `all_merge_requests` method in this case.
* | | | | | | | Merge branch 'member-access-granted-leave-email-fe' into 'master'Fatih Acet2019-05-064-4/+48
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CE Add leave link to access_granted email See merge request gitlab-org/gitlab-ce!27892
| * | | | | | | | Add leave link to access_granted emailmember-access-granted-leave-email-feLuke Bennett2019-05-034-4/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allows users to leave a project/group that they have been added to. Add function to leave a namespace by url param If the `leave` param is present on a project/group show page, click the leave link.
* | | | | | | | | Resolve "Support Prometheus for group-level clusters"Peter Leitzen2019-05-061-1/+1
| |_|_|/ / / / / |/| | | | | | |
* | | | | | | | GraphQL - Add extra complexity for resolversJan Provaznik2019-05-065-0/+64
| |_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a field is a resolver, its complexity is automatically increased. By default we add extra points for sort and search arguments (which will be common for various resolvers). For specific resolvers we add field-specific complexity, e.g. for Issues complexity is increased if we filter issues by `labelName` (because then SQL query is more complex). We may want to tune these values in future depending on real-life results. Complexity is also dependent on the number of loaded nodes, but only if we don't search by specific ID(s). Also added complexity is limited (by default only twice more than child complexity) - the reason is that although it's more complex to process more items, the complexity increase is not linear (there is not so much difference between loading 10, 20 or 100 records from DB).
* | | | | | | Fix editing issues and MRs with NULL lock_versionSean McGivern2019-05-062-0/+24
| | | | | | |
* | | | | | | Fix issuables state_id nil when importing projects from GitHubFelipe Artur2019-05-064-0/+63
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Issues and merge requests imported from GitHub are having state_id set to null. This fixes the GitHub project importer and schedule migrations to fix state_id.
* | | | | | | Merge branch 'ce-11194-fix-approvals-groups-all-available' into 'master'Fatih Acet2019-05-061-0/+4
|\ \ \ \ \ \ \ | |_|_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | Add close_select2 method to select2_helper See merge request gitlab-org/gitlab-ce!27981
| * | | | | | Add close_select2 method to select2_helperce-11194-fix-approvals-groups-all-availablePaul Slaughter2019-05-011-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | **Why?** This is needed to create a feature test for: https://gitlab.com/gitlab-org/gitlab-ee/issues/11194
* | | | | | | Show health graphs on group-levelPeter Leitzen2019-05-063-1/+13
| |_|_|/ / / |/| | | | | | | | | | | | | | | | | Tweak cluster helper and refactor its specs.
* | | | | | Destroy repo mirrors instead of disabling themLuke Bennett2019-05-061-0/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is important to destroy data related to repo mirrors when they are disabled. Use `_destroy` nested attribute instead of `enabled` for push mirrors. Call `remove_import_data` after saving a project if its pull mirror is disabled.
* | | | | | Implement support for CI variables of type fileKrasimir Angelov2019-05-0614-18/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add env_var and file as supported types for CI variables. Variables of type file expose to users existing gitlab-runner behaviour - save variable value into a temp file and set the path to this file in an ENV var named after the variable key. Resolves https://gitlab.com/gitlab-org/gitlab-ce/issues/46806.
* | | | | | Fix uploading of LFS tracked file through UIPatrick Bajao2019-05-061-0/+19
| | | | | |
* | | | | | Merge branch '30093-apply-bfg-object-map-to-database' into 'master'Douwe Maan2019-05-065-103/+204
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove cleaned up OIDs from database and cache Closes #30093 See merge request gitlab-org/gitlab-ce!26555
| * | | | | | Remove cleaned up OIDs from database and cacheNick Thomas2019-05-065-103/+204
| | | | | | |
* | | | | | | Merge branch ↵Filipa Lacerda2019-05-063-50/+56
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '58105-pipeline-author-and-commit-author-too-close-together-in-pipeline-list' into 'master' Improve pipelines table spacing, add triggerer column Closes #38802 and #58105 See merge request gitlab-org/gitlab-ce!26136
| * | | | | | | Separate tests for triggerer componentmfluharty2019-05-033-50/+56
| | |/ / / / / | |/| | | | |
* | | | | | | Merge branch 'jc-disconnect-git-alternates-client' into 'master'Stan Hu2019-05-063-3/+72
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add client methods for DisconnectGitAlternates rpc See merge request gitlab-org/gitlab-ce!27938
| * | | | | | | Add client methods for DisconnectGitAlternates rpcjc-disconnect-git-alternates-clientJohn Cai2019-05-033-3/+72
| | |_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | DisconnectGitAlternates is a Gitaly RPC that will delete a repository's objects/info/alternates file. This commit adds client support for that RPC.
* | | | | | | Merge branch 'fix-merge-request-pipeline-exist-method' into 'master'Bob Van Landuyt2019-05-068-25/+25
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | Fix duplicate merge request pipelines created by Sidekiq worker retry See merge request gitlab-org/gitlab-ce!26643