summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Avoid excessive recursive calls with Rugged TreeEntriessh-fix-rugged-tree-entriesStan Hu2019-03-311-1/+1
| | | | | | | | | | The Rugged implementation was recursively scanning the repository to create `flat_path` because the post-process step was being called from with a loop. For large repositories, this was significantly slowing things down. Break the call to `rugged_populate_flat_path` out of this loop to make this work efficiently. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/59759
* Don't try to set any ACL on uploaded objectsBastian Blank2019-03-301-1/+1
| | | | | | | | Set ACL of uploaded objects to not-public (fog-aws) or no ACL at all (fog-google). Value is ignored by other supported backends (fog-aliyun, fog-openstack, fog-rackspace) This allows uploads to GCS with ACL support disabled.
* Merge branch 'sh-fix-failing-spec-on-first-da' into 'master'James Lopez2019-03-301-1/+1
|\ | | | | | | | | | | | | Fix failing spec in spec/features/users/login_spec.rb Closes #59731 See merge request gitlab-org/gitlab-ce!26787
| * Fix failing spec in spec/features/users/login_spec.rbStan Hu2019-03-291-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | This spec would start to fail on the first of the month because the generated text would have a zero-padded day (e.g. 01 vs 1), whereas the expected text check used an unpadded day via the `-d` parameter in strftime (https://apidock.com/ruby/Date/strftime). To fix this, we use use the `d` parameter to pad zeros. This spec was introduced recently in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25731. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/59731
* | Renames Cluster#managed? to provided_by_user?Mayra Cabrera2019-03-294-1/+113
| | | | | | | | | | | | This will allow to user the term managed? on https://gitlab.com/gitlab-org/gitlab-ce/issues/56557. Managed? will be used to distinct clusters that are automatically managed by GitLab
* | Merge branch 'winh-jest-html-fixtures' into 'master'Clement Ho2019-03-294-10/+47
|\ \ | |/ |/| | | | | | | | | Add helpers for HTML fixtures to Jest Closes #57998 See merge request gitlab-org/gitlab-ce!26739
| * Add Karma-style fixture helpers to Jestwinh-jest-html-fixturesWinnie Hellmann2019-03-293-2/+17
| |
| * Add helpers for HTML fixtures to JestWinnie Hellmann2019-03-291-6/+20
| |
| * Add workaround for innerText in JestWinnie Hellmann2019-03-291-0/+9
| |
| * Move abuse_reports_spec.js to JestWinnie Hellmann2019-03-291-2/+2
| |
* | Handle missing keys in sentry api responseReuben Pereira2019-03-293-17/+120
| | | | | | | | | | | | - Do not raise error when there are missing non-essential keys in sentry api response. - Add specs for to check for missing keys behavior.
* | Merge branch '50199-quick-actions-refactor' into 'master'Sean McGivern2019-03-2941-459/+2396
|\ \ | | | | | | | | | | | | | | | | | | Extend quick actions dsl Closes #50199 See merge request gitlab-org/gitlab-ce!26095
| * | Extend quick actions dsl50199-quick-actions-refactorAlexandru Croitor2019-03-2941-459/+2396
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Extend quick actions dsl to allow specifying model types to which given quick action applies * Rename issuable attribute to noteable in interpret_service.rb * Refactor and reorder quick action specs * Create a shared example spec for each quick action to be used for issue, merge request and commit specs. https://gitlab.com/gitlab-org/gitlab-ce/issues/50199
* | | Merge branch '59462-applicatonsettings-not-tolerant-of-missing-db-columns' ↵Stan Hu2019-03-291-3/+12
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | into 'master' Use a Gitlab::FakeApplicationSettings when migrations are pending Closes #59462 See merge request gitlab-org/gitlab-ce!26601
| * | | Apply suggestion to spec/lib/gitlab/current_settings_spec.rb59462-applicatonsettings-not-tolerant-of-missing-db-columnsLin Jen-Shin2019-03-281-1/+1
| | | |
| * | | Use a Gitlab::FakeApplicationSettings when migrations are pendingRémy Coutable2019-03-261-2/+11
| | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | | | Merge branch 'winh-jest-vue-tips' into 'master'Tim Zallmann2019-03-291-0/+3
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Disable Vue tips when running Jest See merge request gitlab-org/gitlab-ce!26717
| * | | | Disable Vue tips when running Jestwinh-jest-vue-tipsWinnie Hellmann2019-03-281-0/+3
| | |_|/ | |/| |
* | | | Merge branch 'persist-fulll-ref-path-for-mr-pipelines' into 'master'Kamil Trzciński2019-03-2910-18/+294
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use merge request HEAD ref for detached merge request pipelines Closes #58454 See merge request gitlab-org/gitlab-ce!25504
| * | | | Create detached merge request pipelinespersist-fulll-ref-path-for-mr-pipelinesShinya Maeda2019-03-2910-18/+294
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | By using `refs/merge-requests/:iid/head` ok ok Improve naming nicely Add nice tests add nice tests fix some more revert
* | | | | Merge branch 'refactor/ce_stubbed_worker' into 'master'Douwe Maan2019-03-297-76/+49
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor subbed_worker calls Closes #58484 See merge request gitlab-org/gitlab-ce!26708
| * | | | | Refactor subbed_worker callsrefactor/ce_stubbed_workerJoão Cunha2019-03-287-76/+49
| | |/ / / | |/| | | | | | | | | | | | | | | | | | - Creates a support/helper file and moves all the duplication defs into it
* | | | | Merge branch 'sh-fix-gitaly-find-commit-caching' into 'master'Kamil Trzciński2019-03-293-0/+27
|\ \ \ \ \ | |_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | Allow ref name caching CommitService#find_commit Closes #57083 See merge request gitlab-org/gitlab-ce!26248
| * | | | Allow ref name caching CommitService#find_commitStan Hu2019-03-273-0/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For a given merge request, it's quite common to see duplicate FindCommit Gitaly requests because the Gitaly CommitService caches the request by the commit SHA, not by the ref name. However, most of the duplicate requests use the ref name, so the cache is never actually used in practice. This leads to unnecessary requests that slow performance. This commit allows certain callers to bypass the ref name to OID conversion in the cache. We don't do this by default because it's possible the tip of the branch changes during the commit, which would cause the caller to get stale data. This commit also forces the Ci::Pipeline to use the full ref name so that caching can work for merge requests. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57083
* | | | | Merge branch 'winh-jest-gon' into 'master'Filipa Lacerda2019-03-291-0/+6
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Set gon.ee in Jest Closes #59634 See merge request gitlab-org/gitlab-ce!26713
| * | | | | Set gon.ee in Jestwinh-jest-gonWinnie Hellmann2019-03-281-0/+6
| | |/ / / | |/| | |
* | | | | Merge branch '10735-geo-gitlab-revision-can-return-not-consistent-results' ↵Sean McGivern2019-03-291-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | into 'master' Use a fixed git abbrev parameter when we fetch a git revision See merge request gitlab-org/gitlab-ce!26707
| * | | | | Use a fixed git abbrev parameter when we fetch a git revision10735-geo-gitlab-revision-can-return-not-consistent-resultsValery Sizov2019-03-281-1/+1
| |/ / / /
* | | | | Merge branch 'winh-jest-helpers' into 'master'Phil Hughes2019-03-2911-0/+235
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Copy missing helpers from Karma to Jest See merge request gitlab-org/gitlab-ce!26729
| * | | | | Copy missing helpers from Karma to JestWinnie Hellmann2019-03-2811-0/+235
| |/ / / / | | | | | | | | | | | | | | | Copy missing helpers from Karma to Jest
* | | | | Add requested resources to cluster health - ce portTristan Read2019-03-292-0/+9
| |_|/ / |/| | |
* | | | [CE] Reduce the diff with EE in spec/helpers/projects_helper_spec.rbRémy Coutable2019-03-281-0/+2
| | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | | | [CE] Reduce the diff with EE in spec/helpers/merge_requests_helper_spec.rbRémy Coutable2019-03-281-0/+2
| | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | | | [CE] Reduce the diff with EE in spec/helpers/issuables_helper_spec.rbRémy Coutable2019-03-281-2/+4
| | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | | | [CE] Reduce the diff with EE in spec/helpers/group_helper_spec.rbRémy Coutable2019-03-281-0/+2
| | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | | | [CE] Reduce the diff with EE in spec/helpers/auth_helper_spec.rbRémy Coutable2019-03-281-0/+2
| | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | | | [CE] Reduce the diff with EE in spec/helpers/appearances_helper_spec.rbRémy Coutable2019-03-281-5/+3
|/ / / | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
* | | Knative version bump 0.2.2 -> 0.3.0Chris Baumbauer2019-03-281-1/+1
| | |
* | | Merge branch ↵Phil Hughes2019-03-281-0/+24
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | '9957-move-ee-differences-for-app-assets-javascripts-monitoring-components-dashboard-vue-ce' into 'master' Remove EE differences for monitoring dashboard See merge request gitlab-org/gitlab-ce!26574
| * | | Remove EE differences for monitoring dashboardSimon Knox2019-03-271-0/+24
| | | |
* | | | Merge branch '54670-external-diffs-when-outdated' into 'master'Sean McGivern2019-03-285-3/+253
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow external diffs to be used conditionally Closes #54670 See merge request gitlab-org/gitlab-ce!25432
| * | | | Allow external diffs to be used conditionallyNick Thomas2019-03-275-3/+253
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since external diffs are likely to be a bit slower than in-database ones, add a mode that makes diffs external after they've been obsoleted by events. This should strike a balance between performance and disk space. A background cron drives the majority of migrations, since diffs become outdated through user actions.
* | | | | Merge branch 'fix-routes-n-plus-one-in-user-autocomplete' into 'master'Grzegorz Bizon2019-03-282-13/+56
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Remove N+1 queries from users autocomplete See merge request gitlab-org/gitlab-ce!26491
| * | | | | Remove N+1 queries from users autocompleteSean McGivern2019-03-252-13/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Both of these were related to groups: 1. We need to preload routes (using the `with_route` scope) if we're going to get the group's path. 2. We were counting each group's members separately. They're in the same commit because the spec for N+1 detection wouldn't pass with only one of these fixes.
* | | | | | Merge branch 'rubocop-handle-ee-migration-specs' into 'master'Rémy Coutable2019-03-281-0/+18
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Properly handle `ee` migration specs See merge request gitlab-org/gitlab-ce!26685
| * | | | | | Properly handle `ee` migration specsHeinrich Lee Yu2019-03-281-0/+18
| | | | | | |
* | | | | | | Merge branch 'ce-reduce-ee-diff-in-spec-policies' into 'master'Lin Jen-Shin2019-03-2810-447/+432
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [CE] Reduce diff with EE in `spec/policies` See merge request gitlab-org/gitlab-ce!26593
| * | | | | | | [CE] Reduce the diff with EE in spec/policies/group_policy_spec.rbRémy Coutable2019-03-272-49/+48
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
| * | | | | | | Factorize policy helpers into PolicyHelpersRémy Coutable2019-03-276-32/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>
| * | | | | | | [CE] Reduce the diff with EE in spec/policies/project_policy_spec.rbRémy Coutable2019-03-274-373/+379
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Rémy Coutable <remy@rymai.me>