summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Embed metrics undefined param fixTristan Read2019-08-201-0/+20
|
* Allow measurement for Sidekiq jobs taking > 2.5sAndrew Newdigate2019-08-201-1/+1
| | | | Fix for https://gitlab.com/gitlab-org/gitlab-ce/issues/66319.
* Move SAST reports logic for MR widget to backendrossfuhrman2019-08-201-86/+0
| | | | Update spec that is changed in corresponding EE MR
* Merge branch 'sh-fix-issues-api-gitaly-nplusone' into 'master'Sean McGivern2019-08-203-0/+13
|\ | | | | | | | | | | | | Fix Gitaly N+1 calls with listing issues/MRs via API Closes #66202 See merge request gitlab-org/gitlab-ce!31938
| * Fix Gitaly N+1 calls with listing issues/MRs via APIsh-fix-issues-api-gitaly-nplusoneStan Hu2019-08-173-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In GitLab 9.0, https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/9661 removed the `subscribed` flag from the API when the user requested a list of issues or merge requests since calculating this value triggers extensive Markdown processing. In GitLab 12.0 via a4fbf39e, we accidentally reintroduced this performance regression by changing `IssueBasic` to `Issue` in `entities.rb`. This showed up as a Gitaly N+1 issue since the Markdown processing would attempt to extract a commit if it detected a regex that matched a commit. We restore the prior behavior by once again removing the `subscribed` flag for the bulk list of issues and merge requests and add a test to ensure they aren't reintroduced. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66202
* | Use ActiveModel's type instead of virtusPeter Leitzen2019-08-201-6/+19
| | | | | | | | | | | | The virtus project has been discontinued: https://github.com/solnic/virtus/commit/a6f896984
* | Merge branch 'kp-add-vue-input-autofocus-directive' into 'master'Filipa Lacerda2019-08-201-0/+38
|\ \ | | | | | | | | | | | | Add `autofocusonshow` directive for input elements See merge request gitlab-org/gitlab-ce!31584
| * | Add `autofocus` directive for input elementskp-add-vue-input-autofocus-directiveKushal Pandya2019-08-191-0/+38
| | |
* | | Merge branch 'fe-fix-merge-url-params-with-plus' into 'master'Kushal Pandya2019-08-202-5/+31
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Fix `mergeUrlParams` handling of '+' Closes #66152 See merge request gitlab-org/gitlab-ce!31973
| * | | Add feature spec for search with spacefe-fix-merge-url-params-with-plusminghuan lei2019-08-191-5/+25
| | | |
| * | | Fix mergeUrlParams handling of `+`Paul Slaughter2019-08-191-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | **What was the issue?** If a param value had `+`, it would be encoded as a literal `+` instead of a space.
* | | | Add support for sentry_extra_data in exceptionsAlex Kalderimis2019-08-191-2/+27
| | | | | | | | | | | | | | | | | | | | This allows exceptions to advertise their support for sentry and provide structured data.
* | | | Merge branch 'mc/bug/nplusone-pipelines-show' into 'master'Stan Hu2019-08-191-7/+11
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Improve nplusone spec for PipelinesController#show See merge request gitlab-org/gitlab-ce!31976
| * | | | Improve nplusone spec for PipelinesController#showMatija Čupić2019-08-191-7/+11
| | | | |
* | | | | Merge branch 'da-fix-n-plus-1-query-on-starrers-list' into 'master'Stan Hu2019-08-191-0/+14
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Fix N+1s queries while loading users on the project starrers list See merge request gitlab-org/gitlab-ce!31984
| * | | | | Fix N+1s queries while loading usersDouglas Barbosa Alexandre2019-08-191-0/+14
| | | | | |
* | | | | | Merge branch '64251-branch-name-set-cache' into 'master'Robert Speicher2019-08-193-13/+119
|\ \ \ \ \ \ | |/ / / / / |/| | | | | | | | | | | | | | | | | Cache branch and tag names as Redis sets See merge request gitlab-org/gitlab-ce!30476
| * | | | | Cache branch and tag names as Redis setsNick Thomas2019-08-163-13/+119
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | This allows us to check inclusion for the *_exists? methods without downloading the full list of branch names, which is over 100KiB in size for gitlab-ce at the moment.
* | | | | Merge branch 'add-js-prevent-default-on-click' into 'master'Clement Ho2019-08-191-9/+9
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Replace inline scripts in links to prevent default See merge request gitlab-org/gitlab-ce!31838
| * | | | | Replace inline scripts in links to prevent defaultadd-js-prevent-default-on-clickHeinrich Lee Yu2019-08-191-9/+9
| | |_|_|/ | |/| | | | | | | | | | | | | Use buttons instead of links with javascript:void(0)
* | | | | Merge branch '64677-delete-directory-webide' into 'master'Paul Slaughter2019-08-191-0/+35
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixed deletion of directories in Web IDE Closes #64677 See merge request gitlab-org/gitlab-ce!31727
| * | | | | Fixed deletion of directories in Web IDE64677-delete-directory-webideDenys Mishunov2019-08-121-0/+35
| | | | | |
* | | | | | Merge branch '39-count-unique-users-for-more-accurate-smau-reporting' into ↵Nick Thomas2019-08-193-13/+33
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'master' Allow UsageData.count to use count_by: See merge request gitlab-org/gitlab-ce!30770
| * | | | | New GroupMember.of_ldap_type scope39-count-unique-users-for-more-accurate-smau-reportingAsh McKenzie2019-07-182-13/+27
| | | | | |
| * | | | | Allow UsageData.count to use count_by:Ash McKenzie2019-07-181-0/+6
| | | | | |
* | | | | | Clean Sidekiq metrics from multiproc dir on startAleksei Lipniagov2019-08-191-0/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After moving the multiproc dir cleanup into `config.ru`:`warmup`, we stopped cleaning Sidekiq metrics dir which is not correct. This MR intended to fix that. More details: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31668
* | | | | | Add warning when LE certificate can't be obtained64630-add-warning-to-pages-domains-that-obtaining-deploying-ssl-certificates-through-let-s-encrypt-can-take-some-timeVladimir Shushlin2019-08-192-4/+70
| |_|_|_|/ |/| | | | | | | | | | | | | | * Refactor some tests as well
* | | | | Move cycle analytics stages templates to vueEzekiel Kigbo2019-08-191-0/+177
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The existing stage list items are rendered in haml, migrating them to vuejs for future work. Fix alignment of median value Test for stage_nav_item.vue
* | | | | Fix pipelines not always being created after a pushsh-fix-pipelines-not-being-createdStan Hu2019-08-171-0/+16
| |_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31741 introduced a regression where not all the right parameters would be passed into `Ci::CreatePipelineService`. We fix this by breaking out the pipeline parameters and reusing a method from `Gitlab::DataBuilder::Push`. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66196
* | | | UI for disabling group/project email notificationBrett Walker2019-08-178-0/+137
| | | | | | | | | | | | | | | | | | | | | | | | - Adds UI to configure in group and project settings - Removes notification configuration for users when disabled at group or project level
* | | | Merge branch 'legacy-attachments-migrate-fix' into 'master'Michael Kozono2019-08-163-4/+360
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | Migrate legacy uploads rake tasks See merge request gitlab-org/gitlab-ce!29409
| * | | | Add rake tasks for migrating leacy uploadslegacy-attachments-migrate-fixJarka Košanová2019-08-163-4/+360
| | | | | | | | | | | | | | | | | | | | | | | | | - move uploads created by AttachmentUploader - handle also files created for legacy_diff_notes
* | | | | Merge branch '66023-starrers-count-do-not-match-after-searching' into 'master'Stan Hu2019-08-161-40/+112
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Fix starrers counts after searching See merge request gitlab-org/gitlab-ce!31823
| * | | | | Fix starrers counters after searchingDouglas Barbosa Alexandre2019-08-151-40/+112
| | | | | |
* | | | | | Merge branch 'dm-process-commit-worker-n+1' into 'master'Stan Hu2019-08-162-50/+60
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Look up upstream commits once before queuing ProcessCommitWorkers Closes #65464 See merge request gitlab-org/gitlab-ce!31871
| * | | | | | Look up upstream commits once before queuing ProcessCommitWorkersDouwe Maan2019-08-162-50/+60
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of checking if a commit already exists in the upstream project in its ProcessCommitWorker and bailing out if it does, we check the existence of all commits in bulk in Git::BranchHooksService, so that we can skip scheduling ProcessCommitWorker jobs for those commits that already exist upstream entirely.
* | | | | | | Expire project caches once per push instead of once per refStan Hu2019-08-165-12/+144
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously `ProjectCacheWorker` would be scheduled once per ref, which would generate unnecessary I/O and load on Sidekiq, especially if many tags or branches were pushed at once. `ProjectCacheWorker` would expire three items: 1. Repository size: This only needs to be updated once per push. 2. Commit count: This only needs to be updated if the default branch is updated. 3. Project method caches: This only needs to be updated if the default branch changes, but only if certain files change (e.g. README, CHANGELOG, etc.). Because the third item requires looking at the actual changes in the commit deltas, we schedule one `ProjectCacheWorker` to handle the first two cases, and schedule a separate `ProjectCacheWorker` for the third case if it is needed. As a result, this brings down the number of `ProjectCacheWorker` jobs from N to 2. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52046
* | | | | | | Remove Security Dashboard feature flagrossfuhrman2019-08-161-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes the group_overview_security_dashboard feature flag
* | | | | | | Add clipboard button to metric chart dropdownTristan Read2019-08-162-2/+86
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds a clipboard button to the metrics dashboard, that allows copying a link to an individual chart.
* | | | | | | Merge branch 'mc/feature/pipeline-tracking-config-ce' into 'master'Kamil Trzciński2019-08-165-7/+40
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add `needs:` CI config option CE Closes gitlab-ee#12334 See merge request gitlab-org/gitlab-ce!31346
| * | | | | | | Port changes from EEmc/feature/pipeline-tracking-config-ceMatija Čupić2019-08-045-7/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Ports changes from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/12343
* | | | | | | | Merge branch 'fix/commits-api-empty-refname' into 'master'Nick Thomas2019-08-161-0/+6
|\ \ \ \ \ \ \ \ | |_|_|_|_|_|_|/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fix handling of empty ref_name parameter string in commits api Closes #64745 See merge request gitlab-org/gitlab-ce!31687
| * | | | | | | remove encoding comment created by emacs ruby-modeArmin Hohenegger2019-08-131-1/+0
| | | | | | | |
| * | | | | | | add a test for empty ref_name to api commits specArmin Hohenegger2019-08-131-0/+7
| | | | | | | |
* | | | | | | | Merge branch '56130-deployment-date' into 'master'Grzegorz Bizon2019-08-162-0/+6
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Expose finished_at for the Deployment entity See merge request gitlab-org/gitlab-ce!31808
| * | | | | | | | Add finished_at to the internal API Deployment entity56130-deployment-dateKrasimir Angelov2019-08-152-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/56130.
* | | | | | | | | Merge branch ↵Grzegorz Bizon2019-08-165-29/+256
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '47003-user-onboarding-replace-current-email-confirmation-flow-with-a-soft-email-confirmation-flow' into 'master' Soft email confirmation flow Closes #47003 See merge request gitlab-org/gitlab-ce!31245
| * | | | | | | | | Fix invite specAlex Buijs2019-08-081-14/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The invitation flow changed a bit, because now there is no more need to sign in after confirming. When signing up with a different email address, the user will see the invitation page straight after signing up when redirected, without needing to sign in.
| * | | | | | | | | Add some feature specsAlex Buijs2019-08-081-0/+35
| | | | | | | | | |
| * | | | | | | | | Don't redirect to the Almost there pageAlex Buijs2019-08-082-15/+65
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't redirect to the Almost there page after registration and after resending confirmation instructions