summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Merge branch '41492-mr-comment-fix' into 'master'Sean McGivern2017-12-292-14/+66
| | | | | | | | | | | Fix links to old commits in merge request comments Closes #41492 See merge request gitlab-org/gitlab-ce!16152 (cherry picked from commit cdda83ebe9c5e85074d1bd2d718ab84afc672e17) c1ea4afa Fix links to old commits in merge requests
* Merge branch 'sh-handle-orphaned-deploy-keys' into 'master'Grzegorz Bizon2017-12-291-0/+10
| | | | | | | | | | | Gracefully handle orphaned write deploy keys in /internal/post_receive Closes #41466 See merge request gitlab-org/gitlab-ce!16127 (cherry picked from commit 228f42b58b8f23b53494d32ff964aca47e90ac2e) 36bdf3dc Gracefully handle orphaned write deploy keys in /internal/post_receive
* Merge branch 'sh-fix-mysql-migration-10-3' into 'master'Grzegorz Bizon2017-12-271-0/+25
| | | | | | | | | | | | | Fix migration for removing orphaned issues.moved_to_id values in MySQL and PostgreSQL Closes #41498 See merge request gitlab-org/gitlab-ce!16141 (cherry picked from commit ff3e9af6fdac37ae71ea526bbb9aaf4b7d2ce876) 5cacdc4e Fix migration for removing orphaned issues.moved_to_id values in MySQL dfdf22c7 Fix PostgreSQL implementation of migration e97671b8 Simplify implementation and allow for batch updates in MySQL
* Merge branch 'sh-handle-anonymous-clones-project-moved' into 'master'Grzegorz Bizon2017-12-261-0/+6
| | | | | | | | | | | | Fix Error 500s with anonymous clones for a project that has moved Closes #41457 See merge request gitlab-org/gitlab-ce!16128 (cherry picked from commit a5a0f3f725c4f5c6d11d33e18493d93e07e53183) a83c41f6 Fix Error 500s with anonymous clones for a project that has moved b6c711fd Disable redirect messages for anonymous clones
* Merge branch 'bvl-fix-unlinking-with-lfs-objects' into 'master'Douwe Maan2017-12-261-0/+20
| | | | | | | | | | | Don't link LFS-objects multiple times. Closes #41241 See merge request gitlab-org/gitlab-ce!16006 (cherry picked from commit 6e42fac3fb11c1c6143975dbe6c843a22cd4828f) ac862490 Don't link LFS-objects multiple times.
* Merge branch 'pawel/reduce_cardinality_of_prometheus_metrics' into 'master'Douwe Maan2017-12-262-8/+11
| | | | | | | | | | | | | | | | | Reduce cardinality of some of GitLab's Prometheus metrics and fix observed duration reporting. Closes #41045 See merge request gitlab-org/gitlab-ce!15881 (cherry picked from commit 92e15071c13f65cf7250315f1a138284880b0074) e391fe1d Reduce cardinality of gitlab_cache_operation_duration_seconds histogram b02db1f4 Fix gitaly_call_histogram to observe times in seconds correctly a8ebed60 Make `System.monotonic_time` retun seconds represented by float with microsecond precision 3c545133 Fix tests and formatting ed715b79 use in_milliseconds rails helper 040167f0 Use seconds where possible, and convert to milliseconds for Influxdb consumption 10af36f0 add missing word to pawel-reduce_cardinality_of_prometheus_metrics.yml
* Merge branch 'dm-issue-move-transaction-error' into 'master'Robert Speicher2017-12-261-0/+12
| | | | | | | | | | | Execute project hooks and services after commit when moving an issue Closes #41324 See merge request gitlab-org/gitlab-ce!16108 (cherry picked from commit 87dbf9846dcc870581ed753c730d768e671c51d4) 16b8297e Execute project hooks and services after commit when moving an issue
* Merge branch 'zj-empty-repo-importer' into 'master'Stan Hu2017-12-211-4/+4
| | | | | | | | | | | Migrate to Project#empty_repo? Closes #41326 See merge request gitlab-org/gitlab-ce!16054 (cherry picked from commit e0a27ee419b55509204ba2bfbdbfbab3c7c331bc) 338f1eaf Migrate to Project#empty_repo?
* Fall back to the `MergeRequestWidgetEntity`Bob Van Landuyt2017-12-212-2/+10
| | | | When no serializer was passed.
* Merge branch 'zj-memoization-mr-commits' into 'master'Sean McGivern2017-12-192-1/+15
| | | | | | Use memoization for commits on diffs See merge request gitlab-org/gitlab-ce!15857
* Merge branch 'commit-diff-discussion-in-mr-context-fix-links' into 'master'⛄️ Sean McGivern ⛄️2017-12-191-2/+12
| | | | | | | | | | fix the commit diff discussion sending the wrong url See merge request gitlab-org/gitlab-ce!15988 (cherry picked from commit f7a9ced235be7ef13f90b561d23ffe602e11e9a3) c77083a4 fix the commit diff discussion sending the wrong url a794b161 rework the merge_request_version_params to use Object#tap
* Merge branch 'osw-isolate-mr-widget-exposed-attributes' into 'master'Sean McGivern2017-12-195-73/+40
| | | | | | | | | Stop sending milestone and labels for Projects::MergeRequestsController#show.json requests See merge request gitlab-org/gitlab-ce!15847 (cherry picked from commit 3870a1bde276144a05a31185ede7a5032818d489) cba40a1f Stop sending milestone and labels data over the wire for MR widget
* Merge branch 'ignore-markdown-cache-when-stubbing-application-settings' into ↵Nick Thomas2017-12-192-4/+7
| | | | | | | | | | | | | 'master' Don't use Markdown cache for stubbed settings in specs Closes #41130 See merge request gitlab-org/gitlab-ce!15954 (cherry picked from commit dc17e7d7a9a6a246cd8c69a7d06ff1dcfefd8384) 10885edf Don't use Markdown cache for stubbed settings in specs
* Merge branch 'dm-ldap-email-readonly' into 'master'Sean McGivern2017-12-192-13/+52
| | | | | | | | | | | Make sure user email is read only when synced with LDAP Closes #41033 See merge request gitlab-org/gitlab-ce!15915 (cherry picked from commit d39d968ba4100be3e77e9d02af6ce10ff18ca508) 481b8a71 Make sure user email is read only when synced with LDAP
* Merge branch 'zj-mr-diff-memoization-bug' into 'master'Sean McGivern2017-12-192-13/+24
| | | | | | Clear caches before updating MR diffs See merge request gitlab-org/gitlab-ce!15916
* Merge branch 'dm-batchloader-project' into 'master'Sean McGivern2017-12-191-0/+5
| | | | | | | | | | | | Include project in BatchLoader key to prevent returning blobs for the wrong project Closes gitlab-ee#4325 See merge request gitlab-org/gitlab-ce!15936 (cherry picked from commit f51141878171c1162818f8fa0133125a5e92d3eb) 6c4f6d37 Include project in BatchLoader key to prevent returning blobs for the wrong project f871027e Clear BatchLoader after each spec to prevent holding onto records longer than necessary
* Merge branch 'pawel/cache_feature_check_for_5_minutes_for_method_call' into ↵Robert Speicher2017-12-191-0/+32
| | | | | | | | | | | | | | | | | | | | 'master' Cache feature check for 1 minute for MethodCall instrumentation toggle See merge request gitlab-org/gitlab-ce!15800 (cherry picked from commit 83998c0a33c70c786f48eef5ce723eb6dd76761f) 53dc9e83 Cache feature check for 5 minutes for MethodCall instrumentation toggle b503e6ff Implement simple in memory cache that expires after 5 minutes 6af84964 Set cache expire only once the cache is filled, 5904b033 Implemente measurement enabled cache using AtomicReference 408208bc Use AtomicFixNum to implement CAS isolated cache update. ca176a9b move call_measurement_enabled? method to the bottom of the file fd0a5168 use class variables instead of CONSTANTs da19ce62 Expire feature flag cache after 1minute 51668d3e Use class variable and add rubocop exception db9e5bf7 fix test case description
* Restore throttling of touchYorick Peterse2017-12-145-2/+30
|
* Merge branch ↵Kamil Trzciński2017-12-142-9/+7
| | | | | | | | | | | | | '41110-dependencies-validator-fails-when-depended-job-is-manual' into 'master' Dependencies Validator fails when depended job is `manual` Closes #41110 See merge request gitlab-org/gitlab-ce!15924 (cherry picked from commit 57175ecb5060dac145abc048b6e88642bc1aa82b) 1def948b Dependencies Validator fails when depended job is `manual`
* Merge branch 'issue_41021' into 'master'10-3-stable-prepare-rc1Sean McGivern2017-12-134-5/+35
| | | | | | | | Prevent worker that updates merge requests head pipeline from failing jobs Closes #41021 See merge request gitlab-org/gitlab-ce!15870
* Revert "Merge branch 'zj-memoization-mr-commits' into 'master'"Oswaldo Ferreira2017-12-132-15/+1
| | | | This reverts commit 54f008126d83af1869572565336e01d3953b2b91.
* Merge branch 'zj-memoization-mr-commits' into 'master'Sean McGivern2017-12-132-1/+15
| | | | | | Use memoization for commits on diffs See merge request gitlab-org/gitlab-ce!15857
* Merge branch 'mk-fix-leaky-spec' into 'master'Stan Hu2017-12-131-4/+13
| | | | | | | | | CE Backport - Fix order-dependent spec failure by avoiding monkeypatching See merge request gitlab-org/gitlab-ce!15893 (cherry picked from commit 31fa9313991881258b4697cb507cfc8ab205b7dc) acde0e3f Fix spec by avoiding monkeypatching
* Merge branch 'gitaly-mirroring-prep' into 'master'Robert Speicher2017-12-131-18/+3
| | | | | | | | | | | | Gitaly mirroring migration prep Closes gitaly#816 See merge request gitlab-org/gitlab-ce!15775 (cherry picked from commit 6930fa3102f0ba197e969f9996e86bf11346470c) 885a4da2 Add feature flag to use gitaly-ssh mirroring when cloning internal repos 95009cef Unify mirror addition operations to prepare for Gitaly migration
* Merge branch 'jprovazn-description' into 'master'Sean McGivern2017-12-133-0/+32
| | | | | | | | | | | Use message body for merge request description Closes #40968 See merge request gitlab-org/gitlab-ce!15839 (cherry picked from commit 52d9ee6299a55fc3362a47207e3d62fba1dfbdd1) b39b5524 Use message body for merge request description
* Merge branch ↵Kamil Trzciński2017-12-131-0/+13
| | | | | | | | | | | | | '41023-activerecord-staleobjecterror--attempted-to-update-a-stale-object--ci-build' into 'master' Job dropping by MissingDependenciesError should consider StaleObjectError Closes #41023 See merge request gitlab-org/gitlab-ce!15873 (cherry picked from commit 6fff0473e0cf13607fdd49f856821680298113d8) 3494cdfe ActiveRecord::StaleObjectError: Attempted to update a stale object: Ci::Build
* Merge branch 'fix-image-view-mode' into 'master'Filipa Lacerda2017-12-131-0/+12
| | | | | | | | | | | | Fix image view mode Closes #40945 See merge request gitlab-org/gitlab-ce!15803 (cherry picked from commit fb47f2a7459f4c413f3fe496bcdb1b40d81d73a4) e815e8eb Fix image view mode aa2031b6 Add spec
* Merge branch 'backport-epic-in-issue' into 'master'Jacob Schatz2017-12-132-24/+30
| | | | | | | | | Backport epic in issue See merge request gitlab-org/gitlab-ce!15799 (cherry picked from commit 9c6ce2e8c93dc8d75d00b67ec5628f542826e5b8) bd7218f2 Backport epic in issue
* Merge branch '35724-animate-sidebar' into 'master'Filipa Lacerda2017-12-131-2/+2
| | | | | | | | | | | | | | Animate contextual sidebar; change class names for easier readability Closes #35724 See merge request gitlab-org/gitlab-ce!15797 (cherry picked from commit 2d00ad4868c21aef068232a79495f85e8f50d59b) 37f0ee04 Animate contextual sidebar; change class names for easier readability a1d5d49a Add changelog ee85ca73 Fix mobile styles e0172564 Fix transitions
* Merge branch 'sh-remove-allocation-tracking-influxdb' into 'master'Yorick Peterse2017-12-132-46/+0
| | | | | | | | | | | | Remove allocation tracking code from InfluxDB sampler for performance Closes gitlab-com/infrastructure#3250 See merge request gitlab-org/gitlab-ce!15834 (cherry picked from commit 3daa7331397d0b565911d5bb67b2411b021136fa) e1a8e5a5 Remove allocation tracking code from InfluxDB sampler for performance 10f5446c Remove RubySampler#sample_objects for performance as well
* Merge branch 'mk-pick-10-2-4-security-fixes' into 'master'Winnie Hellmann2017-12-137-37/+188
| | | | | | | | | | | | | | | Pick 10.2.4 security fixes into master See merge request gitlab-org/gitlab-ce!15821 (cherry picked from commit 1eff1bd385a28ccde7d0dc3a991c499ada1a63bd) d332c8c7 Merge branch '36679-non-authorized-user-may-see-wikis-or-pipeline-page' into 'security-10-2' 8c0aa7d4 Merge branch 'bvl-10-2-email-disclosure' into 'security-10-2' 8f29d264 Merge branch 'rs-security-group-api' into 'security-10-2' c59ae547 Merge branch 'issue_30663' into 'security-10-2' f4fbe61a Merge branch 'note-preview' into 'security-10-2' 0f811675 Manually add 10.2.4 changelog entries f71e48a0 Resolve conflicts in app/models/user.rb
* Merge branch 'fix/gb/fix-pipeline-build-chain-tag-evaluation' into 'master'Douwe Maan2017-12-139-37/+275
| | | | | | | | | | | | | | | Fix invalid pipeline build chain tag evaluation Closes #40944 See merge request gitlab-org/gitlab-ce!15805 (cherry picked from commit 103269b9a6d92ff3d4d0f3b69e4653e3f0ef7744) b30e0e06 Fix invalid pipeline build chain tag evaluation ad3be46b Implement and use Gitlab::Ci::Pipeline::Chain::Command 865341ac Fix a bug of before_sha being inproperly evaluated to `checkout_sha` b5f6a5f9 Add Chain::Command specs 99101f94 Fix Rubocop
* Merge branch 'sh-fix-import-rake-task' into 'master'James Lopez2017-12-132-0/+24
| | | | | | | | | | | | | | | Fix gitlab:import:repos Rake task moving repositories into the wrong location Closes #40765 See merge request gitlab-org/gitlab-ce!15823 (cherry picked from commit 7694ae887885c66eb633d3f78eac3128a08dc978) 78f7c3c8 Fix gitlab:import:repos Rake task moving repositories into the wrong location e8cced80 Fix failing importer test case on MySQL due to missing trailing slash in root path 917a112e Simplify normalizing of paths 86661a3a Use build instead of create in importer spec f1eaab7b Remove the need for destroy and add a comment in the spec
* Merge branch '38032-deploy-markers-should-be-more-verbose' into 'master'Mike Greiling2017-12-133-3/+46
| | | | | | | | | | | | Resolve "Deploy markers should be more verbose" Closes #38032 See merge request gitlab-org/gitlab-ce!15641 (cherry picked from commit 8730054683c00f4c79cf452beef0df794c70bf6b) d377aa54 Changed the deploy markers on the prometheus dashboard to be more verbose 3642f6f0 Reduce the size of the deploy flag when there's no tag available
* Merge branch '35385-allow-git-pull-push-on-project-redirects' into 'master'Douwe Maan2017-12-138-31/+318
| | | | | | | | | | | | | | | | | | | | | | | | Allow git pull/push on project redirects Closes #35385 See merge request gitlab-org/gitlab-ce!15670 (cherry picked from commit 2a181d68c810e89ff5d2e49999775d8b58adb394) 37c99562 Allow git pull/push on project redirects 64811239 Allow group/username transfers: 4344bba4 Fixes wrong condition on git access b6bac528 Wrap ProjectMoved behavior into a class 70676e3b Fixes permanent migration 3328950e Moves allowed_path_validation up to Namespace 54900c4a Addreses ME review comments 740ed1e0 Add several improvements 6a0d9261 Add fixes based on MR suggestions 8a1a257b Ensures validations are only executed if RedirectRoute#permanent column exists 448f1c54 Fixes broken specs and suggestions on MR da789af6 Add fixes based on MR comments 2bd96f5f Bump GITLAB_SHELL_VERSION to 5.10.2 75981dc4 Ensure RedirectRoute column information is flushed
* Merge branch ↵Sean McGivern2017-12-134-5/+109
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | '29483-no-feedback-when-checking-on-checklist-if-potential-spam-was-detected' into 'master' Resolve "No feedback when checking on checklist if potential spam was detected" Closes #29483 See merge request gitlab-org/gitlab-ce!15408 (cherry picked from commit d32032de08585476c3b303803a307ff94d910ebd) efc86c26 Mock spam? 8e9a9030 Merge remote-tracking branch 'origin/master' into… 019db0fd TEMP mock askismet spam check 11e51be6 respond_to json with json version of verify view in recaptcha_check_with_fallback 18955cdc Differentiate between spam related error and other update errors 9dcf093c Start recaptcha modal and render partial instead 64b13133 Append and remove api script when reCAPTCHA is needed c9a67fab put-over-post the recaptcha form cb22ae66 remove comments 20517d64 remove comments e174d02e Review changes 7a7d4a2a Add spec 8f617b45 Added changelog db3f1a47 Review changes 4d0c78de Add to tasklist 36ea921b Remove duplicate TaskList 6bffe620 Add app_spec for spam d95350bc Finished specs cf951cba FOR REVIEWERS 6c50e850 FOR MERGE 25931f73 Allow script src to be mockable c3463e00 Merge remote-tracking branch 'origin/master' into… 2c170b8d fix eslint a318c757 Fix redirect 8a02fbd0 BE review changes dda03f4d Fix spec 910c7205 Fix spec fafbd7e5 remove duplicate destroy
* Revert "Merge branch 'throttle-touching-of-objects' into 'master'"Oswaldo Ferreira2017-12-125-30/+2
| | | | | This reverts commit 102b32325da3fc93a1c99d05b20c853fc681df35, reversing changes made to d87d1e7901f7a71c6f0541c709be26fce3db7e4b.
* Move the circuitbreaker check out in a separate processbvl-circuitbreaker-processBob Van Landuyt2017-12-0820-196/+460
| | | | | | | | | | | | | | | | | | | | | | | | | | Moving the check out of the general requests, makes sure we don't have any slowdown in the regular requests. To keep the process performing this checks small, the check is still performed inside a unicorn. But that is called from a process running on the same server. Because the checks are now done outside normal request, we can have a simpler failure strategy: The check is now performed in the background every `circuitbreaker_check_interval`. Failures are logged in redis. The failures are reset when the check succeeds. Per check we will try `circuitbreaker_access_retries` times within `circuitbreaker_storage_timeout` seconds. When the number of failures exceeds `circuitbreaker_failure_count_threshold`, we will block access to the storage. After `failure_reset_time` of no checks, we will clear the stored failures. This could happen when the process that performs the checks is not running.
* Merge branch '40754-fix-flash-usage-with-personal-access-token' into 'master'Grzegorz Bizon2017-12-081-0/+25
|\ | | | | | | | | | | | | Fix new personal access token showing up in a flash message Closes #40754 See merge request gitlab-org/gitlab-ce!15707
| * Fix new personal access token showing up in a flash message40754-fix-flash-usage-with-personal-access-tokenEric Eastwood2017-12-071-0/+25
| |
* | Merge branch 'jprovazn-testfix2' into 'master'Stan Hu2017-12-081-5/+5
|\ \ | | | | | | | | | | | | | | | | | | Clean test path between merge request handler tests Closes #40900 See merge request gitlab-org/gitlab-ce!15792
| * | Clean test path between merge request handler testsjprovazn-testfix2Jan Provaznik2017-12-071-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | create_merge_request_handler_spec needs a repository for some tests but this repository lasts on disk by default which causes failures of other tests. TestEnv.clean_test_path is used to get rid of the repository after each test. Closes #40900
* | | Merge branch '40825-use-relative-path-urls' into 'master'Robert Speicher2017-12-071-1/+1
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Use relative _path helper URLs in the GitLab UI Closes #40825 See merge request gitlab-org/gitlab-ce!15738
| * | | Use relative _path helper URLs in the GitLab UI40825-use-relative-path-urlsEric Eastwood2017-12-071-1/+1
| | | | | | | | | | | | | | | | Fix https://gitlab.com/gitlab-org/gitlab-ce/issues/40825
* | | | Merge branch 'acet-fix-branches-list-on-cherry-pick-modal-after-merge' into ↵Jacob Schatz2017-12-071-0/+12
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 'master' Fix loading branches list on cherry pick modal after merge. Closes #33894 See merge request gitlab-org/gitlab-ce!15306
| * | | | Fix loading branches list on cherry pick modal after merge.acet-fix-branches-list-on-cherry-pick-modal-after-mergeFatih Acet2017-12-041-0/+12
| | | | |
* | | | | Merge branch 'fix-transient-datefix-spec' into 'master'Jacob Schatz2017-12-071-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix transient error in pikadayToString Closes #40858 See merge request gitlab-org/gitlab-ce!15754
| * | | | | Fix transient error in pikadayToStringfix-transient-datefix-specClement Ho2017-12-051-1/+1
| | | | | |
* | | | | | Merge branch 'fix_39233' into 'master'Sean McGivern2017-12-071-0/+4
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fix #39233 - 500 in merge request Closes #39233 See merge request gitlab-org/gitlab-ce!15774
| * | | | | | fix #39233 - 500 in merge requestMartin Nowak2017-12-071-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - handle unchanged empty lines in inline diff
View Lorry Controller Status