summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Add deleted image specvueify-image-diffClement Ho2017-09-191-15/+27
|
* Fix spec nameClement Ho2017-09-191-1/+1
|
* Add test for view file linksClement Ho2017-09-181-0/+14
|
* DRY up constants and rename to viewTypesClement Ho2017-09-181-5/+5
|
* Use gl.TEST_HOST instead of host.invalid for consistencyClement Ho2017-09-181-3/+3
|
* Merge commit '9b13753302df7a3e8ef86c6af3f84066bde31a21' into vueify-image-diffClement Ho2017-09-1843-398/+1221
|\
| * Merge branch 'sh-optimize-discussion-json' into 'master'Yorick Peterse2017-09-181-0/+32
| |\ | | | | | | | | | | | | | | | | | | Eliminate N+1 queries in loading discussions.json endpoint Closes #37955 See merge request gitlab-org/gitlab-ce!14327
| | * Eliminate N+1 queries in loading discussions.json endpointsh-optimize-discussion-jsonStan Hu2017-09-181-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In #37955,we see that the profile had a number of N+1 queries from repeated access to `cross_reference_not_visible_for?`. This was optimized in previous versions of GitLab by rendering all notes at once, counting the number of visible references, and then using that number to check whether a system note should be fully redacted. There was also another N+1 query calling `ProjectTeam#member?`, which did not take advantage of an optimization in prepare_notes_for_rendering that would preload the maximum access level per project. Closes #37955
| * | Merge branch 'milestone-avatar-issuable-link' into 'master'Tim Zallmann2017-09-181-0/+19
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | Fixes milestone issuable assignee URL Closes #33124 See merge request gitlab-org/gitlab-ce!14292
| | * | Fixes milestone issuable assignee URLmilestone-avatar-issuable-linkPhil Hughes2017-09-151-0/+19
| | | | | | | | | | | | | | | | Closes #33124
| * | | Merge branch '37789-followup-for-read-registry-change' into 'master'Rémy Coutable2017-09-183-10/+8
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clean up read_registry scope changes Closes #37789 See merge request gitlab-org/gitlab-ce!14307
| | * | | Clean up read_registry scope changesRobin Bobbitt2017-09-183-10/+8
| | | | | | | | | | | | | | | | | | | | Closes #37789
| * | | | Merge branch 'update-user_uses_slash_commands_spec' into 'master'Rémy Coutable2017-09-181-4/+4
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | Minor update to address Sean McGivern's comment. See merge request gitlab-org/gitlab-ce!14311
| | * | | | Minor update to address Sean McGivern's comment.manolis2017-09-151-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | More details are available here https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13436/diffs#note_39115837
| * | | | | Merge branch 'replace_project_snippets.feature' into 'master'Rémy Coutable2017-09-184-0/+90
| |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace the 'project/snippets.feature' spinach test with an rspec analog See merge request gitlab-org/gitlab-ce!14326
| | * | | | | Replace the 'project/snippets.feature' spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-184-0/+90
| | | | | | |
| * | | | | | Merge branch 'operation-service-merge' into 'master'Rémy Coutable2017-09-184-32/+11
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prepare Repository#merge for migration to Gitaly Closes gitaly#559 See merge request gitlab-org/gitlab-ce!14154
| | * | | | | | Prepare Repository#merge for migration to Gitalyoperation-service-mergeJacob Vosmaer2017-09-154-32/+11
| | | | | | | |
| * | | | | | | Merge branch '24121_extract_yet_another_users_finder' into 'master'Grzegorz Bizon2017-09-181-0/+97
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Extract AutocompleteController#users into finder Closes #24121 See merge request gitlab-org/gitlab-ce!13778
| | * | | | | | | move `find_users` method into finder and add `load_group` methodMaxim Rydkin2017-09-101-4/+28
| | | | | | | | |
| | * | | | | | | rename yet_another_users_finder into autocomplete_users_finderMaxim Rydkin2017-09-101-1/+1
| | | | | | | | |
| | * | | | | | | fix rubocopMaxim Rydkin2017-09-101-8/+7
| | | | | | | | |
| | * | | | | | | finish spec/finders/yet_another_users_finder_spec.rbMaxim Rydkin2017-09-101-54/+42
| | | | | | | | |
| | * | | | | | | extract finder and add first testMaxim Rydkin2017-09-101-0/+86
| | | | | | | | |
| * | | | | | | | Merge branch 'replace_project_commits_revert.feature' into 'master'Rémy Coutable2017-09-181-0/+56
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace the 'project/commits/revert.feature' spinach test with an rspec analog See merge request gitlab-org/gitlab-ce!14325
| | * | | | | | | | Replace the 'project/commits/revert.feature' spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-181-0/+56
| | | |_|/ / / / / | | |/| | | | | |
| * | | | | | | | Merge branch 'replace_project_archived.feature' into 'master'Rémy Coutable2017-09-181-0/+43
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace the 'project/archived.feature' spinach test with an rspec analog See merge request gitlab-org/gitlab-ce!14322
| | * | | | | | | | Replace the 'project/archived.feature' spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-171-0/+43
| | |/ / / / / / /
| * | | | | | | | Merge branch 'improve_spec_features_profiles_specs' into 'master'Rémy Coutable2017-09-188-38/+39
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Improve 'spec/features/profiles/*' specs Closes #37855 et #37856 See merge request gitlab-org/gitlab-ce!14317
| | * | | | | | | | Improve 'spec/features/profiles/*' specsVitaliy @blackst0ne Klachkov2017-09-168-38/+39
| | | | | | | | | |
| * | | | | | | | | Merge branch 'replace_search.feature' into 'master'Rémy Coutable2017-09-1812-310/+559
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace the 'search.feature' spinach test with an rspec analog See merge request gitlab-org/gitlab-ce!14248
| | * | | | | | | | | Replace the 'search.feature' spinach test with an rspec analogVitaliy @blackst0ne Klachkov2017-09-1612-310/+559
| | |/ / / / / / / /
| * | | | | | | | | Merge branch 'mk-delete-conflicting-redirects-mysql' into 'master'Douwe Maan2017-09-183-0/+220
| |\ \ \ \ \ \ \ \ \ | | |_|/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clean up redirect routes that conflict with regular routes Closes #36229 See merge request gitlab-org/gitlab-ce!13783
| | * | | | | | | | Reduce batch sizemk-delete-conflicting-redirects-mysqlMichael Kozono2017-09-141-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | …to stay within our query timeout of 60s. Also reduce the job interval to keep the same overall migration time of ~3.3 days.
| | * | | | | | | | Spread out the work a littleMichael Kozono2017-09-142-6/+73
| | | | | | | | | |
| | * | | | | | | | Extract helper for queuing background jobsMichael Kozono2017-09-142-2/+64
| | | | | | | | | |
| | * | | | | | | | Add specs for deleting conflicting redirectsMichael Kozono2017-09-142-0/+91
| | | | | | | | | |
| * | | | | | | | | Fixed the new sidebars width when browser has scrollbarsPhil Hughes2017-09-161-1/+8
| | |_|_|_|_|_|_|/ | |/| | | | | | |
| * | | | | | | | Merge branch 'master' into 'issue_37640'issue_37640Felipe Artur2017-09-1587-1909/+2938
| |\ \ \ \ \ \ \ \ | | | |_|_|_|/ / / | | |/| | | | | | | | | | | | | | | # Conflicts: # db/schema.rb
| | * | | | | | | Merge branch 'fix-share-with-group-lock-update' into 'master'Robert Speicher2017-09-151-0/+15
| | |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix setting share_with_group_lock Closes #37916 See merge request gitlab-org/gitlab-ce!14300
| | | * | | | | | | Fix setting share_with_group_lockfix-share-with-group-lock-updateYorick Peterse2017-09-151-0/+15
| | | | |/ / / / / | | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior to this commit running Namespace#force_share_with_group_lock_on_descendants would result in updating _all_ namespaces in the namespaces table, not just the descendants. This is the result of ActiveRecord::Relation#update_all not taking into account the CTE. To work around this we use the CTE query as a sub-query instead of directly calling #update_all. To prevent this from happening the relations returned by Gitlab::GroupHierarchy are now marked as read-only, resulting in an error being raised when methods such as #update_all are used. Fortunately on GitLab.com our statement timeouts appear to have prevented this query from actually doing any damage other than causing a very large amount of dead tuples. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/37916
| * | | | | | | | Add data migrationFelipe Artur2017-09-151-1/+1
| | | | | | | | |
| * | | | | | | | Fix project feature being deleted when updating project with invalid ↵Felipe Artur2017-09-121-2/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | visibility level
* | | | | | | | | Add testsClement Ho2017-09-187-0/+328
| |/ / / / / / / |/| | | | | | |
* | | | | | | | created services for keyshaseeb2017-09-156-25/+54
| | | | | | | |
* | | | | | | | Merge branch 'projects-controller-show' into 'master'Rémy Coutable2017-09-152-0/+76
|\ \ \ \ \ \ \ \ | |_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | SQL performance improvements for ProjectsController#show See merge request gitlab-org/gitlab-ce!14226
| * | | | | | | Memoize the latest builds of a pipelineprojects-controller-showYorick Peterse2017-09-141-0/+20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This ensures that if a pipeline is present for the last commit on a project's homepage we only run 1 query to get the builds, instead of running 2 queries. See https://gitlab.com/gitlab-org/gitlab-ce/issues/36878#note_40073339 for more information.
| * | | | | | | Memoize pipelines for project download buttonsYorick Peterse2017-09-141-0/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds Project#latest_successful_pipeline_for and Project#latest_successful_pipeline_for_default_branch. The 2nd method memoizes the result (taking nil values into account) to ensure the underlying query isn't executed multiple times when viewing a project's homepage. See https://gitlab.com/gitlab-org/gitlab-ce/issues/36878#note_40073607 for more information.
* | | | | | | | Merge branch 'revert-sidebar-title-attribute' into 'master'Filipa Lacerda2017-09-151-1/+1
|\ \ \ \ \ \ \ \ | |_|_|_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | Remove title attribute from sidebar elements See merge request gitlab-org/gitlab-ce!14140
| * | | | | | | fixed merge request specrevert-sidebar-title-attributePhil Hughes2017-09-131-1/+1
| | | | | | | |
View Lorry Controller Status