| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
| |
When a spec fails relating to the cache, the job log can easily exceed
the maximum length and make it harder to see the actual issue
(e.g. https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/239803017).
|
|\
| |
| |
| |
| |
| |
| |
| |
| | |
'63177-follow-up-from-use-scoped-routes-for-labels-and-milestones' into 'master'
Resolve "Follow-up from "Use scoped routes for labels and milestones""
Closes #63177
See merge request gitlab-org/gitlab-ce!29983
|
| |
| |
| |
| | |
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | | |
'require-pipeline-when-enabling-only-allow-merge-if-pipeline-succeeds' into 'master'
Pipeline must be present if "Pipeline must succeed" is set
See merge request gitlab-org/gitlab-ce!29926
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When a user sets only_allow_merge_if_pipeline_succeeds, also named
as "Pipeline must succeed" project setting, we require the pipeline
to be present.
This solves race condition issues especially with external CI
providers when a build is triggered externally but no pipelines are
created in GitLab yet.
Document that a head pipeline is expected when using "Pipeline
must succeed" setting. Also explain limitations with the use of
only/except where there may not be any jobs created and the merge
request will not be allowed to be merged.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is largely a straight-forward copy of the Karma spec, with the
usual Karma->Jest necessary changes.
This also fixes a bug in the implementation that was causing the tests
to fail, when run on Jest/node, whereby actions that return rejected
promises would always fail the given test. This was due to those
rejections not being caught in the same call stack in which they were
created.
|
| | |
| | |
| | |
| | |
| | | |
The setup was wrong, and due to Gitaly being a bit more strict it had to
match up. The test is now accurate and passing again.
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Prevent EE backport migrations from running if CE is not migrated
Closes #63612
See merge request gitlab-org/gitlab-ce!30002
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
If a user upgraded to any GitLab 11.x EE version but switched
back to CE, it's possible the state of the EE tables are not
in the right state for the EE backport migration to work properly.
In particular, there were three tables that had trouble:
* epics
* geo_event_log
* vulnerability_feedback
The EE backport migration would fail while trying to add foreign key
constraints because a key didn't exist in the table. This happens
because any EE migration that add or removed columns between v11.0.0 and
v11.11.3 are not guaranteed to be applied in an CE installation. The EE
backport schema does not individually backport these migrations.
We now check if certain columns are present to determine whether
the backport migration is in the proper state. CE users are required
to upgrade to v11.11.3 EE if they ever installed EE previously before
they can go back to v12.x CE.
Tested via:
```
git checkout -f v11.0.0-ee
bundle exec rake db:reset
git checkout .; git checkout -f v11.11.3
bundle exec rake db:migrate
git checkout .; git checkout -f v12.0.0
bundle exec rake db:migrate
<failure happens>
```
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
When removing the last file from a folder in WebIDE, do not remove the
folder from the view. We keep those to give users possibility to
re-upload files to the same folders.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/60860
|
| | | |
| | | |
| | | |
| | | |
| | | | |
The `:` key will no longer exit out of the autocomplete dialog,
allowing auto-completion of labels with colons in them.
|
| |/ /
|/| |
| | |
| | |
| | | |
Also add ::Gitlab::LetsEncrypt.enabled? shortcut
and simplify it a lot
|
| | |
| | |
| | |
| | | |
Changes migration and all other places the attribute is used
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Refactor Deployment#cluster to #deployment_platform_cluster
See merge request gitlab-org/gitlab-ce!29961
|
| | | |
| | | |
| | | |
| | | |
| | | | |
We will introduce #cluster at a later stage.
Also deprecate this method
|
| |/ /
|/| | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add index for pages domain ssl auto renewal
Add PagesDomain.needs_ssl_renewal scope
Add cron worker for ssl renewal
Add worker for ssl renewal
Add pages ssl renewal worker queues settings
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Eliminate N+1 queries in Dashboard::TodosController
Closes #43042
See merge request gitlab-org/gitlab-ce!29954
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This appears to bring down the number of SQL queries on GitLab.com for
my Todos page from 672 to 100.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/43042
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Resolve "Runner tags search dropdown is empty"
Closes #63656
See merge request gitlab-org/gitlab-ce!29985
|
| | |_|/
| |/| |
| | | |
| | | | |
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
|
| |/ /
|/| |
| | |
| | | |
This reverts merge request !29832
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
Add column chart component to the monitoring bundle
See merge request gitlab-org/gitlab-ce!29293
|
| | | |
| | | |
| | | |
| | | |
| | | | |
This merge request just adds the column chart
component without integrating it to the dashboard
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Render branch divergence graph with Vue
See merge request gitlab-org/gitlab-ce!29743
|
| | |/ /
| |/| | |
|
|\ \ \ \
| | | | |
| | | | |
| | | | |
| | | | | |
Build correct basenames for title search results
See merge request gitlab-org/gitlab-ce!29898
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The "basename" here needs to be the full path without the trailing
extension, instead of stripping the leading path as well.
This was previously fixed in 2f36efa0871 inside the view, but the
problematic code was still present in FoundBlob, and the corresponding
spec didn't actually use a child wiki page to properly verify the fix.
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Resolve "Improved group lists UI"
Closes #52366
See merge request gitlab-org/gitlab-ce!26542
|
| | |/ / /
| |/| | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This updates the groups list UI to match the style of the project list:
- New layout
- Improve loading state when loading group children
- Larger, responsive text
- Icon and text colors changed to secondary
- Smaller button sizes
- Content list description colors were standardized to body text
|
|\ \ \ \ \
| |/ / / /
|/| | | |
| | | | |
| | | | | |
RSpec::Parameterized syntax for CI pipeline build seed specs
See merge request gitlab-org/gitlab-ce!29947
|
| | | | | |
|
|\ \ \ \ \
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Fix label serialisation in issue and note hooks
Closes #63473
See merge request gitlab-org/gitlab-ce!29850
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Based on review comment fetching labels hook_attrs is now
wrapped in an issue's model method.
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
We were not calling hook_attrs on the labels correctly. Specs were
passing because the issues under test did not have any labels!
|
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
https://gitlab.com/gitlab-org/gitlab-ce/issues/58583
|
|\ \ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
FIX: Scheduled pipelines scheduled to run at the same time as pipeline_schedule_worker gets pushed to the next run
Closes #63469
See merge request gitlab-org/gitlab-ce!29848
|
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
If pipeline schedule is to run at the exact same time with when cron
worker runs, the pipeline schedule will not be executed at the
ideal timing.
We fix this bug by comparing the exact matching of ideal and
cron worker's next run at.
|
|\ \ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
Automatically update MR merge-ref along merge status
See merge request gitlab-org/gitlab-ce!29569
|
| | | | | | | | |
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
When recheck flag is true, we make sure the merge-ref
is indeed outdated. If it is, we update it along
the merge status.
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
This couples the code that transitions the `MergeRequest#merge_status`
and refs/merge-requests/:iid/merge ref update.
In general, instead of directly telling `MergeToRefService` to update
the merge ref, we should rely on `MergeabilityCheckService` to keep
both the merge status and merge ref synced. Now, if the merge_status is
`can_be_merged` it means the merge-ref is also updated to the latest.
We've also updated the logic to be more systematic and less user-based.
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
A Noteable doesn't have a group directly, unless it's an epic - we need
to look for the project's group to find the right email address.
|
|\ \ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Remove deprecated call in BuildSuccessWorker
Closes #63622
See merge request gitlab-org/gitlab-ce!29958
|
| | |_|_|_|_|_|/
| |/| | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
We now create_deployment on Ci::Build create.
No need to call create_deployment again
|
|\ \ \ \ \ \ \ \
| |_|_|/ / / / /
|/| | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
'17690-Protect-TeamCity-builds-for-triggering-when-a-branch-is-deleted-And-add-MR-option' into 'master'
Skip TeamCity trigger on branch delete and support MR triggers
Closes #13871 and #17690
See merge request gitlab-org/gitlab-ce!29836
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
DroneCI and TeamCity shared the same validations methods
on the data received. These validations were extracted
into a concern
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
This is a take over from a community contribution:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20990
Skip TeamCity push event when related to branch delete
Support merge request events for TeamCity service.
Add checkbox for merge request triggers in the TeamCity
configuration page.
|