From be3399868cbcfdce85daa6fdf53a079bc163056a Mon Sep 17 00:00:00 2001
From: Zeger-Jan van de Weg <mail@zjvandeweg.nl>
Date: Mon, 2 Nov 2015 19:02:08 +0100
Subject: Minor refactoring on Gitlab::Git

---
 lib/gitlab/git.rb           | 7 ++++---
 spec/lib/gitlab/git_spec.rb | 9 +++++++++
 2 files changed, 13 insertions(+), 3 deletions(-)
 create mode 100644 spec/lib/gitlab/git_spec.rb

diff --git a/lib/gitlab/git.rb b/lib/gitlab/git.rb
index f065cc5e9e9..a33daeb119f 100644
--- a/lib/gitlab/git.rb
+++ b/lib/gitlab/git.rb
@@ -1,8 +1,9 @@
 module Gitlab
   module Git
-    BLANK_SHA = '0' * 40
-    TAG_REF_PREFIX = "refs/tags/"
-    BRANCH_REF_PREFIX = "refs/heads/"
+    # '0' * 40 -- this was easyer to freeze
+    BLANK_SHA = "0000000000000000000000000000000000000000".freeze
+    TAG_REF_PREFIX = "refs/tags/".freeze
+    BRANCH_REF_PREFIX = "refs/heads/".freeze
 
     class << self
       def ref_name(ref)
diff --git a/spec/lib/gitlab/git_spec.rb b/spec/lib/gitlab/git_spec.rb
new file mode 100644
index 00000000000..3b4052fa549
--- /dev/null
+++ b/spec/lib/gitlab/git_spec.rb
@@ -0,0 +1,9 @@
+require 'spec_helper'
+
+describe Gitlab::Git do
+  describe "BLANK_SHA" do
+    it "is a string of 40 zero's" do
+      expect(Gitlab::Git::BLANK_SHA).to eq('0' * 40)
+    end
+  end
+end
-- 
cgit v1.2.1


From 5ffec2c953478fbad35d7e7f4fc4b6eb119d7918 Mon Sep 17 00:00:00 2001
From: Zeger-Jan van de Weg <mail@zjvandeweg.nl>
Date: Tue, 3 Nov 2015 13:09:18 +0100
Subject: Freeze the expression instead of the literal

Also remove the spec for it
---
 lib/gitlab/git.rb           | 3 +--
 spec/lib/gitlab/git_spec.rb | 9 ---------
 2 files changed, 1 insertion(+), 11 deletions(-)
 delete mode 100644 spec/lib/gitlab/git_spec.rb

diff --git a/lib/gitlab/git.rb b/lib/gitlab/git.rb
index a33daeb119f..191bea86ac3 100644
--- a/lib/gitlab/git.rb
+++ b/lib/gitlab/git.rb
@@ -1,7 +1,6 @@
 module Gitlab
   module Git
-    # '0' * 40 -- this was easyer to freeze
-    BLANK_SHA = "0000000000000000000000000000000000000000".freeze
+    BLANK_SHA = ('0' * 40).freeze
     TAG_REF_PREFIX = "refs/tags/".freeze
     BRANCH_REF_PREFIX = "refs/heads/".freeze
 
diff --git a/spec/lib/gitlab/git_spec.rb b/spec/lib/gitlab/git_spec.rb
deleted file mode 100644
index 3b4052fa549..00000000000
--- a/spec/lib/gitlab/git_spec.rb
+++ /dev/null
@@ -1,9 +0,0 @@
-require 'spec_helper'
-
-describe Gitlab::Git do
-  describe "BLANK_SHA" do
-    it "is a string of 40 zero's" do
-      expect(Gitlab::Git::BLANK_SHA).to eq('0' * 40)
-    end
-  end
-end
-- 
cgit v1.2.1