From 0a2f93aa6a791714fb35557f60b20a1a92682684 Mon Sep 17 00:00:00 2001 From: Stan Hu Date: Mon, 18 Sep 2017 16:14:44 -0700 Subject: Eliminate N+1 queries referencing issues To load issue 1, we see that in #38033 that about 835 ms of the SQL queries were due to loading ProjectFeature. We should be able to cut this down by eagerly loading this information. Closes #38033 --- changelogs/unreleased/sh-project-feature-eager-load.yml | 5 +++++ lib/banzai/reference_parser/issue_parser.rb | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 changelogs/unreleased/sh-project-feature-eager-load.yml diff --git a/changelogs/unreleased/sh-project-feature-eager-load.yml b/changelogs/unreleased/sh-project-feature-eager-load.yml new file mode 100644 index 00000000000..406ef119a14 --- /dev/null +++ b/changelogs/unreleased/sh-project-feature-eager-load.yml @@ -0,0 +1,5 @@ +--- +title: Eliminate N+1 queries referencing issues +merge_request: +author: +type: fixed diff --git a/lib/banzai/reference_parser/issue_parser.rb b/lib/banzai/reference_parser/issue_parser.rb index a65bbe23958..e0a8ca653cb 100644 --- a/lib/banzai/reference_parser/issue_parser.rb +++ b/lib/banzai/reference_parser/issue_parser.rb @@ -34,7 +34,8 @@ module Banzai { namespace: :owner }, { group: [:owners, :group_members] }, :invited_groups, - :project_members + :project_members, + :project_feature ] } ), -- cgit v1.2.1