From 0c529b4a49fa469d6982e52fc6228036204bfbab Mon Sep 17 00:00:00 2001 From: Robert Speicher Date: Fri, 23 Jun 2017 13:20:07 -0500 Subject: Remove gitlab_sign_out_direct helper --- spec/features/projects/jobs_spec.rb | 2 +- spec/support/login_helpers.rb | 7 +------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/spec/features/projects/jobs_spec.rb b/spec/features/projects/jobs_spec.rb index 006a5011a2e..fbbdfcf982b 100644 --- a/spec/features/projects/jobs_spec.rb +++ b/spec/features/projects/jobs_spec.rb @@ -392,7 +392,7 @@ feature 'Jobs', :feature do job.cancel! project.update(visibility_level: Gitlab::VisibilityLevel::PUBLIC) - gitlab_sign_out_direct + sign_out(:user) sign_in(create(:user)) visit namespace_project_job_path(project.namespace, project, job) end diff --git a/spec/support/login_helpers.rb b/spec/support/login_helpers.rb index 4c88958264b..aa3b7c7bb84 100644 --- a/spec/support/login_helpers.rb +++ b/spec/support/login_helpers.rb @@ -35,13 +35,8 @@ module LoginHelpers def gitlab_sign_out find(".header-user-dropdown-toggle").click click_link "Sign out" - # check the sign_in button - expect(page).to have_button('Sign in') - end - # Logout without JavaScript driver - def gitlab_sign_out_direct - page.driver.submit :delete, '/users/sign_out', {} + expect(page).to have_button('Sign in') end private -- cgit v1.2.1