From 0cd71544acb2f41225f5b1dcc92ac01188df349d Mon Sep 17 00:00:00 2001 From: Phil Hughes Date: Tue, 17 Jul 2018 11:27:08 +0100 Subject: moved to a new component sidebar now toggles the preview sidebar icon is hidden when no package.json exits --- app/assets/javascripts/ide/components/ide.vue | 6 - .../javascripts/ide/components/panes/right.vue | 27 ++++- .../ide/components/preview/clientside.vue | 131 +++++++++++++++++++++ app/assets/javascripts/ide/constants.js | 1 + app/assets/javascripts/ide/services/index.js | 4 +- app/assets/javascripts/ide/stores/getters.js | 2 + app/assets/stylesheets/pages/repo.scss | 4 + 7 files changed, 165 insertions(+), 10 deletions(-) create mode 100644 app/assets/javascripts/ide/components/preview/clientside.vue diff --git a/app/assets/javascripts/ide/components/ide.vue b/app/assets/javascripts/ide/components/ide.vue index 2d2415354f9..257a7432c20 100644 --- a/app/assets/javascripts/ide/components/ide.vue +++ b/app/assets/javascripts/ide/components/ide.vue @@ -9,7 +9,6 @@ import RepoEditor from './repo_editor.vue'; import FindFile from './file_finder/index.vue'; import RightPane from './panes/right.vue'; import ErrorMessage from './error_message.vue'; -import Preview from './preview.vue'; const originalStopCallback = Mousetrap.stopCallback; @@ -23,7 +22,6 @@ export default { FindFile, RightPane, ErrorMessage, - Preview, }, computed: { ...mapState([ @@ -35,7 +33,6 @@ export default { 'emptyStateSvgPath', 'currentProjectId', 'errorMessage', - 'entries', ]), ...mapGetters(['activeFile', 'hasChanges']), }, @@ -137,9 +134,6 @@ export default { - diff --git a/app/assets/javascripts/ide/components/panes/right.vue b/app/assets/javascripts/ide/components/panes/right.vue index e4a5fcc67c4..1f291eb497f 100644 --- a/app/assets/javascripts/ide/components/panes/right.vue +++ b/app/assets/javascripts/ide/components/panes/right.vue @@ -1,5 +1,5 @@ + + + + diff --git a/app/assets/javascripts/ide/constants.js b/app/assets/javascripts/ide/constants.js index 45d36f6f42c..38f2877ec59 100644 --- a/app/assets/javascripts/ide/constants.js +++ b/app/assets/javascripts/ide/constants.js @@ -32,6 +32,7 @@ export const rightSidebarViews = { pipelines: 'pipelines-list', jobsDetail: 'jobs-detail', mergeRequestInfo: 'merge-request-info', + clientSidePreview: 'clientside', }; export const stageKeys = { diff --git a/app/assets/javascripts/ide/services/index.js b/app/assets/javascripts/ide/services/index.js index 49a481f25d5..d4501f6a8f2 100644 --- a/app/assets/javascripts/ide/services/index.js +++ b/app/assets/javascripts/ide/services/index.js @@ -18,7 +18,7 @@ export default { return axios .get(file.rawPath, { - params: { format: 'json' }, + transformResponse: [res => res], }) .then(({ data }) => data); }, @@ -33,7 +33,7 @@ export default { return axios .get(file.rawPath.replace(`/raw/${file.branchId}/${file.path}`, `/raw/${sha}/${file.path}`), { - params: { format: 'json' }, + transformResponse: [res => res], }) .then(({ data }) => data); }, diff --git a/app/assets/javascripts/ide/stores/getters.js b/app/assets/javascripts/ide/stores/getters.js index 5ce268b0d05..357ef449fdb 100644 --- a/app/assets/javascripts/ide/stores/getters.js +++ b/app/assets/javascripts/ide/stores/getters.js @@ -90,5 +90,7 @@ export const lastCommit = (state, getters) => { export const currentBranch = (state, getters) => getters.currentProject && getters.currentProject.branches[state.currentBranchId]; +export const packageJson = state => state.entries['package.json']; + // prevent babel-plugin-rewire from generating an invalid default during karma tests export default () => {}; diff --git a/app/assets/stylesheets/pages/repo.scss b/app/assets/stylesheets/pages/repo.scss index 2d76f0ce004..734b0f66396 100644 --- a/app/assets/stylesheets/pages/repo.scss +++ b/app/assets/stylesheets/pages/repo.scss @@ -1158,6 +1158,10 @@ background-color: $white-light; border-left: 1px solid $white-dark; } + + .ide-right-sidebar-clientside { + padding: 0; + } } .ide-pipeline { -- cgit v1.2.1