From ead9fbf47f0b1c5cfe567be1da3e28a43b663644 Mon Sep 17 00:00:00 2001 From: Nathan Friend Date: Mon, 11 Feb 2019 13:05:06 -0400 Subject: Flip checkJs to false, fix TS errors --- tsconfig.json | 2 +- vendor/assets/javascripts/u2f.js | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/tsconfig.json b/tsconfig.json index 70b03b4f012..ae163c47bf6 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -24,7 +24,7 @@ // Compile JS files "allowJs": true, // Check JS files - "checkJs": true, + "checkJs": false, // Emit no files, we are just using it as a type checker "noEmit": true, // False for now to reduce amount of errors diff --git a/vendor/assets/javascripts/u2f.js b/vendor/assets/javascripts/u2f.js index a33e5e0ade9..88ca5e315da 100644 --- a/vendor/assets/javascripts/u2f.js +++ b/vendor/assets/javascripts/u2f.js @@ -91,16 +91,11 @@ u2f.U2fResponse; /** * An error object for responses - * @typedef {{ - * errorCode: u2f.ErrorCodes, - * errorMessage: ?string - * }} */ u2f.Error; /** * Data object for a single sign request. - * @typedef {enum {BLUETOOTH_RADIO, BLUETOOTH_LOW_ENERGY, USB, NFC}} */ u2f.Transport; -- cgit v1.2.1 From 4086d1bfb81b6e2d0eefb3e66304d1a49952a990 Mon Sep 17 00:00:00 2001 From: Nathan Friend Date: Mon, 11 Feb 2019 13:28:42 -0400 Subject: Avoid running tsc twice The default output tsc is informative enough, in my opinion. --- scripts/type-check.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/type-check.sh b/scripts/type-check.sh index b3217fef11b..0658a5b6b34 100755 --- a/scripts/type-check.sh +++ b/scripts/type-check.sh @@ -1,5 +1,3 @@ #!/usr/bin/env bash yarn run tsc -p . -echo "Current errors are:" -yarn run tsc -p . | cut -d":" -f2 | grep 'error' | sort | uniq -c | sort -- cgit v1.2.1