From 9611a410be296a2ef2e8ae7df69830dce293199b Mon Sep 17 00:00:00 2001 From: Stan Hu Date: Mon, 18 Dec 2017 14:11:00 -0800 Subject: Fix missing WHERE clause in 20171106135924_issues_milestone_id_foreign_key migration If milestone_id is NULL, we shouldn't need to update it to be NULL again. This was causing us to touch almost all rows in the issues table for no good reason. Closes https://gitlab.com/gitlab-com/infrastructure/issues/3416 --- db/migrate/20171106135924_issues_milestone_id_foreign_key.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/db/migrate/20171106135924_issues_milestone_id_foreign_key.rb b/db/migrate/20171106135924_issues_milestone_id_foreign_key.rb index e6a780d0964..bfb3dcae511 100644 --- a/db/migrate/20171106135924_issues_milestone_id_foreign_key.rb +++ b/db/migrate/20171106135924_issues_milestone_id_foreign_key.rb @@ -16,6 +16,7 @@ class IssuesMilestoneIdForeignKey < ActiveRecord::Migration def self.with_orphaned_milestones where('NOT EXISTS (SELECT true FROM milestones WHERE milestones.id = issues.milestone_id)') + .where('milestone_id IS NOT NULL') end end -- cgit v1.2.1