From 016c79cad736df18b8777be53efd4e261341edb2 Mon Sep 17 00:00:00 2001 From: sarahghp Date: Thu, 23 May 2019 18:44:06 -0400 Subject: Add changes to match ee --- .../components/deployment.vue | 2 +- .../components/mr_widget_pipeline_container.vue | 2 +- public/visual-review-toolbar.js | 30 ++++++++++++---------- 3 files changed, 18 insertions(+), 16 deletions(-) diff --git a/app/assets/javascripts/vue_merge_request_widget/components/deployment.vue b/app/assets/javascripts/vue_merge_request_widget/components/deployment.vue index 8f4cae8ae58..ad0464a3a98 100644 --- a/app/assets/javascripts/vue_merge_request_widget/components/deployment.vue +++ b/app/assets/javascripts/vue_merge_request_widget/components/deployment.vue @@ -49,7 +49,7 @@ export default { required: false, default: () => ({ sourceProjectId: '', - issueId: '', + mergeRequestId: '', appUrl: '', }), }, diff --git a/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_pipeline_container.vue b/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_pipeline_container.vue index b9f5f602117..0686409a785 100644 --- a/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_pipeline_container.vue +++ b/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_pipeline_container.vue @@ -48,7 +48,7 @@ export default { visualReviewAppMeta() { return { appUrl: this.mr.appUrl, - issueId: this.mr.iid, + mergeRequestId: this.mr.iid, sourceProjectId: this.mr.sourceProjectId, }; }, diff --git a/public/visual-review-toolbar.js b/public/visual-review-toolbar.js index dc21197bda9..6a0fdb29cc2 100644 --- a/public/visual-review-toolbar.js +++ b/public/visual-review-toolbar.js @@ -374,12 +374,12 @@ function clearNote (inputId) { } } -function confirmAndClear (discussionId) { +function confirmAndClear (mergeRequestId) { const commentButton = document.getElementById('gitlab-comment-button'); const note = document.getElementById('gitlab-validation-note'); commentButton.innerText = 'Feedback sent'; - note.innerText = `Your comment was successfully posted to issue #${discussionId}`; + note.innerText = `Your comment was successfully posted to merge request #${mergeRequestId}`; setTimeout(resetCommentButton, 1000); } @@ -412,7 +412,7 @@ function getProjectDetails () { const browser = getBrowserId(userAgent); const scriptEl = document.getElementById('review-app-toolbar-script') - const { projectId, discussionId, mrUrl } = scriptEl.dataset; + const { projectId, mergeRequestId, mrUrl } = scriptEl.dataset; return { href, @@ -422,7 +422,7 @@ function getProjectDetails () { innerWidth, innerHeight, projectId, - discussionId, + mergeRequestId, mrUrl, }; } @@ -449,7 +449,7 @@ function postComment ({ innerWidth, innerHeight, projectId, - discussionId, + mergeRequestId, mrUrl, }) { // Clear any old errors @@ -466,18 +466,20 @@ function postComment ({ } const detailText = ` -
- Metadata - Posted from ${href} | ${platform} | ${browser} | ${innerWidth} x ${innerHeight}. -

- *User agent: ${userAgent}* -
+ \n +
+ Metadata + Posted from ${href} | ${platform} | ${browser} | ${innerWidth} x ${innerHeight}. +

+ User agent: ${userAgent} +
`; const url = ` - ${mrUrl}/api/v4/projects/${projectId}/issues/${discussionId}/discussions`; + ${mrUrl}/api/v4/projects/${projectId}/merge_requests/${mergeRequestId}/discussions`; - const body = `${commentText}${detailText}`; + + const body = `${commentText} ${detailText}`; fetch(url, { method: 'POST', @@ -489,7 +491,7 @@ function postComment ({ }) .then((response) => { if (response.ok) { - confirmAndClear(discussionId); + confirmAndClear(mergeRequestId); return; } -- cgit v1.2.1