From 20111b045d7df27223808b1e8eaa4861d4906863 Mon Sep 17 00:00:00 2001
From: dineshpanda <dineshpanda92@gmail.com>
Date: Sun, 1 Sep 2019 01:27:00 +0530
Subject: Avoid calling freeze on already frozen strings in app/models

---
 app/models/award_emoji.rb                             | 4 ++--
 app/models/blob_viewer/base.rb                        | 2 +-
 app/models/broadcast_message.rb                       | 2 +-
 app/models/ci/build.rb                                | 2 +-
 app/models/ci/build_runner_session.rb                 | 2 +-
 app/models/clusters/applications/ingress.rb           | 2 +-
 app/models/clusters/applications/jupyter.rb           | 2 +-
 app/models/clusters/applications/knative.rb           | 6 +++---
 app/models/clusters/applications/runner.rb            | 2 +-
 app/models/clusters/cluster.rb                        | 4 ++--
 app/models/concerns/cacheable_attributes.rb           | 2 +-
 app/models/concerns/has_status.rb                     | 2 +-
 app/models/concerns/protected_ref_access.rb           | 6 +++---
 app/models/concerns/taskable.rb                       | 4 ++--
 app/models/deploy_token.rb                            | 2 +-
 app/models/diff_viewer/base.rb                        | 2 +-
 app/models/gpg_key.rb                                 | 4 ++--
 app/models/instance_configuration.rb                  | 4 ++--
 app/models/members/group_member.rb                    | 2 +-
 app/models/members/project_member.rb                  | 2 +-
 app/models/namespace/aggregation_schedule.rb          | 2 +-
 app/models/notification_reason.rb                     | 6 +++---
 app/models/pages_domain.rb                            | 2 +-
 app/models/project.rb                                 | 4 ++--
 app/models/project_services/buildkite_service.rb      | 2 +-
 app/models/project_services/pivotaltracker_service.rb | 2 +-
 app/models/project_services/pushover_service.rb       | 2 +-
 app/models/repository.rb                              | 6 +++---
 app/models/user.rb                                    | 4 ++--
 app/models/user_status.rb                             | 2 +-
 30 files changed, 45 insertions(+), 45 deletions(-)

diff --git a/app/models/award_emoji.rb b/app/models/award_emoji.rb
index 0ab302a0f3e..24fcb97db6e 100644
--- a/app/models/award_emoji.rb
+++ b/app/models/award_emoji.rb
@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
 class AwardEmoji < ApplicationRecord
-  DOWNVOTE_NAME = "thumbsdown".freeze
-  UPVOTE_NAME   = "thumbsup".freeze
+  DOWNVOTE_NAME = "thumbsdown"
+  UPVOTE_NAME   = "thumbsup"
 
   include Participable
   include GhostUser
diff --git a/app/models/blob_viewer/base.rb b/app/models/blob_viewer/base.rb
index df6b9bb2f0b..1c3a6599f36 100644
--- a/app/models/blob_viewer/base.rb
+++ b/app/models/blob_viewer/base.rb
@@ -2,7 +2,7 @@
 
 module BlobViewer
   class Base
-    PARTIAL_PATH_PREFIX = 'projects/blob/viewers'.freeze
+    PARTIAL_PATH_PREFIX = 'projects/blob/viewers'
 
     class_attribute :partial_name, :loading_partial_name, :type, :extensions, :file_types, :load_async, :binary, :switcher_icon, :switcher_title, :collapse_limit, :size_limit
 
diff --git a/app/models/broadcast_message.rb b/app/models/broadcast_message.rb
index da4584228ce..1338a585c9e 100644
--- a/app/models/broadcast_message.rb
+++ b/app/models/broadcast_message.rb
@@ -16,7 +16,7 @@ class BroadcastMessage < ApplicationRecord
   default_value_for :color, '#E75E40'
   default_value_for :font,  '#FFFFFF'
 
-  CACHE_KEY = 'broadcast_message_current_json'.freeze
+  CACHE_KEY = 'broadcast_message_current_json'
 
   after_commit :flush_redis_cache
 
diff --git a/app/models/ci/build.rb b/app/models/ci/build.rb
index 79a2d5e6e9d..d558f66154e 100644
--- a/app/models/ci/build.rb
+++ b/app/models/ci/build.rb
@@ -445,7 +445,7 @@ module Ci
       end
     end
 
-    CI_REGISTRY_USER = 'gitlab-ci-token'.freeze
+    CI_REGISTRY_USER = 'gitlab-ci-token'
 
     def persisted_variables
       Gitlab::Ci::Variables::Collection.new.tap do |variables|
diff --git a/app/models/ci/build_runner_session.rb b/app/models/ci/build_runner_session.rb
index 997bf298025..8075c15bbaf 100644
--- a/app/models/ci/build_runner_session.rb
+++ b/app/models/ci/build_runner_session.rb
@@ -6,7 +6,7 @@ module Ci
   class BuildRunnerSession < ApplicationRecord
     extend Gitlab::Ci::Model
 
-    TERMINAL_SUBPROTOCOL = 'terminal.gitlab.com'.freeze
+    TERMINAL_SUBPROTOCOL = 'terminal.gitlab.com'
 
     self.table_name = 'ci_builds_runner_session'
 
diff --git a/app/models/clusters/applications/ingress.rb b/app/models/clusters/applications/ingress.rb
index 1430b82c2f2..50def3ba38c 100644
--- a/app/models/clusters/applications/ingress.rb
+++ b/app/models/clusters/applications/ingress.rb
@@ -3,7 +3,7 @@
 module Clusters
   module Applications
     class Ingress < ApplicationRecord
-      VERSION = '1.1.2'.freeze
+      VERSION = '1.1.2'
 
       self.table_name = 'clusters_applications_ingress'
 
diff --git a/app/models/clusters/applications/jupyter.rb b/app/models/clusters/applications/jupyter.rb
index 9ede0615fa3..fb74d96efe3 100644
--- a/app/models/clusters/applications/jupyter.rb
+++ b/app/models/clusters/applications/jupyter.rb
@@ -5,7 +5,7 @@ require 'securerandom'
 module Clusters
   module Applications
     class Jupyter < ApplicationRecord
-      VERSION = '0.9-174bbd5'.freeze
+      VERSION = '0.9-174bbd5'
 
       self.table_name = 'clusters_applications_jupyter'
 
diff --git a/app/models/clusters/applications/knative.rb b/app/models/clusters/applications/knative.rb
index 244fe738396..a9b9374622d 100644
--- a/app/models/clusters/applications/knative.rb
+++ b/app/models/clusters/applications/knative.rb
@@ -3,9 +3,9 @@
 module Clusters
   module Applications
     class Knative < ApplicationRecord
-      VERSION = '0.6.0'.freeze
-      REPOSITORY = 'https://storage.googleapis.com/triggermesh-charts'.freeze
-      METRICS_CONFIG = 'https://storage.googleapis.com/triggermesh-charts/istio-metrics.yaml'.freeze
+      VERSION = '0.6.0'
+      REPOSITORY = 'https://storage.googleapis.com/triggermesh-charts'
+      METRICS_CONFIG = 'https://storage.googleapis.com/triggermesh-charts/istio-metrics.yaml'
       FETCH_IP_ADDRESS_DELAY = 30.seconds
       API_RESOURCES_PATH = 'config/knative/api_resources.yml'
 
diff --git a/app/models/clusters/applications/runner.rb b/app/models/clusters/applications/runner.rb
index 329250255fd..2d6af8f4f0b 100644
--- a/app/models/clusters/applications/runner.rb
+++ b/app/models/clusters/applications/runner.rb
@@ -3,7 +3,7 @@
 module Clusters
   module Applications
     class Runner < ApplicationRecord
-      VERSION = '0.8.0'.freeze
+      VERSION = '0.8.0'
 
       self.table_name = 'clusters_applications_runners'
 
diff --git a/app/models/clusters/cluster.rb b/app/models/clusters/cluster.rb
index 97d39491b73..444e1a82c97 100644
--- a/app/models/clusters/cluster.rb
+++ b/app/models/clusters/cluster.rb
@@ -20,8 +20,8 @@ module Clusters
       Applications::Runner.application_name => Applications::Runner,
       Applications::Prometheus.application_name => Applications::Prometheus
     }.merge(PROJECT_ONLY_APPLICATIONS).freeze
-    DEFAULT_ENVIRONMENT = '*'.freeze
-    KUBE_INGRESS_BASE_DOMAIN = 'KUBE_INGRESS_BASE_DOMAIN'.freeze
+    DEFAULT_ENVIRONMENT = '*'
+    KUBE_INGRESS_BASE_DOMAIN = 'KUBE_INGRESS_BASE_DOMAIN'
 
     belongs_to :user
 
diff --git a/app/models/concerns/cacheable_attributes.rb b/app/models/concerns/cacheable_attributes.rb
index 0c800621a55..d459af23a2f 100644
--- a/app/models/concerns/cacheable_attributes.rb
+++ b/app/models/concerns/cacheable_attributes.rb
@@ -11,7 +11,7 @@ module CacheableAttributes
 
   class_methods do
     def cache_key
-      "#{name}:#{Gitlab::VERSION}:#{Rails.version}".freeze
+      "#{name}:#{Gitlab::VERSION}:#{Rails.version}"
     end
 
     # Can be overridden
diff --git a/app/models/concerns/has_status.rb b/app/models/concerns/has_status.rb
index 71ebb586c13..cf88076ac74 100644
--- a/app/models/concerns/has_status.rb
+++ b/app/models/concerns/has_status.rb
@@ -3,7 +3,7 @@
 module HasStatus
   extend ActiveSupport::Concern
 
-  DEFAULT_STATUS = 'created'.freeze
+  DEFAULT_STATUS = 'created'
   BLOCKED_STATUS = %w[manual scheduled].freeze
   AVAILABLE_STATUSES = %w[created preparing pending running success failed canceled skipped manual scheduled].freeze
   STARTED_STATUSES = %w[running success failed skipped manual scheduled].freeze
diff --git a/app/models/concerns/protected_ref_access.rb b/app/models/concerns/protected_ref_access.rb
index 583751ea6ac..208937f2aff 100644
--- a/app/models/concerns/protected_ref_access.rb
+++ b/app/models/concerns/protected_ref_access.rb
@@ -4,9 +4,9 @@ module ProtectedRefAccess
   extend ActiveSupport::Concern
 
   HUMAN_ACCESS_LEVELS = {
-    Gitlab::Access::MAINTAINER => "Maintainers".freeze,
-    Gitlab::Access::DEVELOPER => "Developers + Maintainers".freeze,
-    Gitlab::Access::NO_ACCESS => "No one".freeze
+    Gitlab::Access::MAINTAINER => "Maintainers",
+    Gitlab::Access::DEVELOPER => "Developers + Maintainers",
+    Gitlab::Access::NO_ACCESS => "No one"
   }.freeze
 
   class_methods do
diff --git a/app/models/concerns/taskable.rb b/app/models/concerns/taskable.rb
index 8b536a123fc..98842242eb6 100644
--- a/app/models/concerns/taskable.rb
+++ b/app/models/concerns/taskable.rb
@@ -9,8 +9,8 @@ require 'task_list/filter'
 #
 # Used by MergeRequest and Issue
 module Taskable
-  COMPLETED          = 'completed'.freeze
-  INCOMPLETE         = 'incomplete'.freeze
+  COMPLETED          = 'completed'
+  INCOMPLETE         = 'incomplete'
   COMPLETE_PATTERN   = /(\[[xX]\])/.freeze
   INCOMPLETE_PATTERN = /(\[[\s]\])/.freeze
   ITEM_PATTERN       = %r{
diff --git a/app/models/deploy_token.rb b/app/models/deploy_token.rb
index 85f5a2040c0..20e1d802178 100644
--- a/app/models/deploy_token.rb
+++ b/app/models/deploy_token.rb
@@ -8,7 +8,7 @@ class DeployToken < ApplicationRecord
   add_authentication_token_field :token, encrypted: :optional
 
   AVAILABLE_SCOPES = %i(read_repository read_registry).freeze
-  GITLAB_DEPLOY_TOKEN_NAME = 'gitlab-deploy-token'.freeze
+  GITLAB_DEPLOY_TOKEN_NAME = 'gitlab-deploy-token'
 
   default_value_for(:expires_at) { Forever.date }
 
diff --git a/app/models/diff_viewer/base.rb b/app/models/diff_viewer/base.rb
index 527ee33b83b..22c8fe73563 100644
--- a/app/models/diff_viewer/base.rb
+++ b/app/models/diff_viewer/base.rb
@@ -2,7 +2,7 @@
 
 module DiffViewer
   class Base
-    PARTIAL_PATH_PREFIX = 'projects/diffs/viewers'.freeze
+    PARTIAL_PATH_PREFIX = 'projects/diffs/viewers'
 
     class_attribute :partial_name, :type, :extensions, :file_types, :binary, :switcher_icon, :switcher_title
 
diff --git a/app/models/gpg_key.rb b/app/models/gpg_key.rb
index 116beac5c2a..995baf8565c 100644
--- a/app/models/gpg_key.rb
+++ b/app/models/gpg_key.rb
@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
 class GpgKey < ApplicationRecord
-  KEY_PREFIX = '-----BEGIN PGP PUBLIC KEY BLOCK-----'.freeze
-  KEY_SUFFIX = '-----END PGP PUBLIC KEY BLOCK-----'.freeze
+  KEY_PREFIX = '-----BEGIN PGP PUBLIC KEY BLOCK-----'
+  KEY_SUFFIX = '-----END PGP PUBLIC KEY BLOCK-----'
 
   include ShaAttribute
 
diff --git a/app/models/instance_configuration.rb b/app/models/instance_configuration.rb
index a9b1962f24c..f401c23e453 100644
--- a/app/models/instance_configuration.rb
+++ b/app/models/instance_configuration.rb
@@ -4,8 +4,8 @@ require 'resolv'
 
 class InstanceConfiguration
   SSH_ALGORITHMS = %w(DSA ECDSA ED25519 RSA).freeze
-  SSH_ALGORITHMS_PATH = '/etc/ssh/'.freeze
-  CACHE_KEY = 'instance_configuration'.freeze
+  SSH_ALGORITHMS_PATH = '/etc/ssh/'
+  CACHE_KEY = 'instance_configuration'
   EXPIRATION_TIME = 24.hours
 
   def settings
diff --git a/app/models/members/group_member.rb b/app/models/members/group_member.rb
index 3d6f397e599..ed5832ff989 100644
--- a/app/models/members/group_member.rb
+++ b/app/models/members/group_member.rb
@@ -3,7 +3,7 @@
 class GroupMember < Member
   include FromUnion
 
-  SOURCE_TYPE = 'Namespace'.freeze
+  SOURCE_TYPE = 'Namespace'
 
   belongs_to :group, foreign_key: 'source_id'
 
diff --git a/app/models/members/project_member.rb b/app/models/members/project_member.rb
index c64e2669b6a..2bb5806cd21 100644
--- a/app/models/members/project_member.rb
+++ b/app/models/members/project_member.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class ProjectMember < Member
-  SOURCE_TYPE = 'Project'.freeze
+  SOURCE_TYPE = 'Project'
 
   belongs_to :project, foreign_key: 'source_id'
 
diff --git a/app/models/namespace/aggregation_schedule.rb b/app/models/namespace/aggregation_schedule.rb
index 61a7eb4b576..ed61c807519 100644
--- a/app/models/namespace/aggregation_schedule.rb
+++ b/app/models/namespace/aggregation_schedule.rb
@@ -7,7 +7,7 @@ class Namespace::AggregationSchedule < ApplicationRecord
   self.primary_key = :namespace_id
 
   DEFAULT_LEASE_TIMEOUT = 1.5.hours.to_i
-  REDIS_SHARED_KEY = 'gitlab:update_namespace_statistics_delay'.freeze
+  REDIS_SHARED_KEY = 'gitlab:update_namespace_statistics_delay'
 
   belongs_to :namespace
 
diff --git a/app/models/notification_reason.rb b/app/models/notification_reason.rb
index 0a13487574f..6856d397413 100644
--- a/app/models/notification_reason.rb
+++ b/app/models/notification_reason.rb
@@ -3,9 +3,9 @@
 # Holds reasons for a notification to have been sent as well as a priority list to select which reason to use
 # above the rest
 class NotificationReason
-  OWN_ACTIVITY = 'own_activity'.freeze
-  ASSIGNED = 'assigned'.freeze
-  MENTIONED = 'mentioned'.freeze
+  OWN_ACTIVITY = 'own_activity'
+  ASSIGNED = 'assigned'
+  MENTIONED = 'mentioned'
 
   # Priority list for selecting which reason to return in the notification
   REASON_PRIORITY = [
diff --git a/app/models/pages_domain.rb b/app/models/pages_domain.rb
index 27c122d3559..12ce717efd7 100644
--- a/app/models/pages_domain.rb
+++ b/app/models/pages_domain.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class PagesDomain < ApplicationRecord
-  VERIFICATION_KEY = 'gitlab-pages-verification-code'.freeze
+  VERIFICATION_KEY = 'gitlab-pages-verification-code'
   VERIFICATION_THRESHOLD = 3.days.freeze
   SSL_RENEWAL_THRESHOLD = 30.days.freeze
 
diff --git a/app/models/project.rb b/app/models/project.rb
index a6d203f1e72..17b52d0578e 100644
--- a/app/models/project.rb
+++ b/app/models/project.rb
@@ -37,8 +37,8 @@ class Project < ApplicationRecord
 
   BoardLimitExceeded = Class.new(StandardError)
 
-  STATISTICS_ATTRIBUTE = 'repositories_count'.freeze
-  UNKNOWN_IMPORT_URL = 'http://unknown.git'.freeze
+  STATISTICS_ATTRIBUTE = 'repositories_count'
+  UNKNOWN_IMPORT_URL = 'http://unknown.git'
   # Hashed Storage versions handle rolling out new storage to project and dependents models:
   # nil: legacy
   # 1: repository
diff --git a/app/models/project_services/buildkite_service.rb b/app/models/project_services/buildkite_service.rb
index 43edfde851c..d058904dd9e 100644
--- a/app/models/project_services/buildkite_service.rb
+++ b/app/models/project_services/buildkite_service.rb
@@ -5,7 +5,7 @@ require "addressable/uri"
 class BuildkiteService < CiService
   include ReactiveService
 
-  ENDPOINT = "https://buildkite.com".freeze
+  ENDPOINT = "https://buildkite.com"
 
   prop_accessor :project_url, :token
   boolean_accessor :enable_ssl_verification
diff --git a/app/models/project_services/pivotaltracker_service.rb b/app/models/project_services/pivotaltracker_service.rb
index c15993bdc06..d3fff100964 100644
--- a/app/models/project_services/pivotaltracker_service.rb
+++ b/app/models/project_services/pivotaltracker_service.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class PivotaltrackerService < Service
-  API_ENDPOINT = 'https://www.pivotaltracker.com/services/v5/source_commits'.freeze
+  API_ENDPOINT = 'https://www.pivotaltracker.com/services/v5/source_commits'
 
   prop_accessor :token, :restrict_to_branch
   validates :token, presence: true, if: :activated?
diff --git a/app/models/project_services/pushover_service.rb b/app/models/project_services/pushover_service.rb
index 0d35bab7f80..7324890551c 100644
--- a/app/models/project_services/pushover_service.rb
+++ b/app/models/project_services/pushover_service.rb
@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class PushoverService < Service
-  BASE_URI = 'https://api.pushover.net/1'.freeze
+  BASE_URI = 'https://api.pushover.net/1'
 
   prop_accessor :api_key, :user_key, :device, :priority, :sound
   validates :api_key, :user_key, :priority, presence: true, if: :activated?
diff --git a/app/models/repository.rb b/app/models/repository.rb
index 6f63cd32da4..7882b2b3036 100644
--- a/app/models/repository.rb
+++ b/app/models/repository.rb
@@ -3,9 +3,9 @@
 require 'securerandom'
 
 class Repository
-  REF_MERGE_REQUEST = 'merge-requests'.freeze
-  REF_KEEP_AROUND = 'keep-around'.freeze
-  REF_ENVIRONMENTS = 'environments'.freeze
+  REF_MERGE_REQUEST = 'merge-requests'
+  REF_KEEP_AROUND = 'keep-around'
+  REF_ENVIRONMENTS = 'environments'
 
   ARCHIVE_CACHE_TIME = 60 # Cache archives referred to by a (mutable) ref for 1 minute
   ARCHIVE_CACHE_TIME_IMMUTABLE = 3600 # Cache archives referred to by an immutable reference for 1 hour
diff --git a/app/models/user.rb b/app/models/user.rb
index 3ca84ba612a..67d730e2fa3 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -59,7 +59,7 @@ class User < ApplicationRecord
          :validatable, :omniauthable, :confirmable, :registerable
 
   BLOCKED_MESSAGE = "Your account has been blocked. Please contact your GitLab " \
-                    "administrator if you think this is an error.".freeze
+                    "administrator if you think this is an error."
 
   # Override Devise::Models::Trackable#update_tracked_fields!
   # to limit database writes to at most once every hour
@@ -494,7 +494,7 @@ class User < ApplicationRecord
     def by_login(login)
       return unless login
 
-      if login.include?('@'.freeze)
+      if login.include?('@')
         unscoped.iwhere(email: login).take
       else
         unscoped.iwhere(username: login).take
diff --git a/app/models/user_status.rb b/app/models/user_status.rb
index 6ced4f56823..016b89bae81 100644
--- a/app/models/user_status.rb
+++ b/app/models/user_status.rb
@@ -5,7 +5,7 @@ class UserStatus < ApplicationRecord
 
   self.primary_key = :user_id
 
-  DEFAULT_EMOJI = 'speech_balloon'.freeze
+  DEFAULT_EMOJI = 'speech_balloon'
 
   belongs_to :user
 
-- 
cgit v1.2.1