From 32e22d138a87bb1c52df31d8455e9d324754cb67 Mon Sep 17 00:00:00 2001 From: Phil Hughes Date: Fri, 23 Jun 2017 17:41:38 +0100 Subject: mobile spacing improvements removed random colors left over from the original nav --- app/assets/javascripts/main.js | 2 +- app/assets/stylesheets/new_nav.scss | 64 +++++++++++++++++++++++++------------ 2 files changed, 45 insertions(+), 21 deletions(-) diff --git a/app/assets/javascripts/main.js b/app/assets/javascripts/main.js index ee48fcc2139..d27b4ec78c6 100644 --- a/app/assets/javascripts/main.js +++ b/app/assets/javascripts/main.js @@ -302,7 +302,7 @@ $(function () { $('.header-content .title, .header-content .navbar-sub-nav').toggle(); $('.header-content .header-logo').toggle(); $('.header-content .navbar-collapse').toggle(); - $('.js-navbar-toggle-left, .js-navbar-toggle-right').toggle(); + $('.js-navbar-toggle-left, .js-navbar-toggle-right, .title-container').toggle(); return $('.navbar-toggle').toggleClass('active'); }); // Show/hide comments on diff diff --git a/app/assets/stylesheets/new_nav.scss b/app/assets/stylesheets/new_nav.scss index 8f0e14538d5..441bfc479f6 100644 --- a/app/assets/stylesheets/new_nav.scss +++ b/app/assets/stylesheets/new_nav.scss @@ -3,7 +3,7 @@ @import "bootstrap/variables"; header.navbar-gitlab-new { - color: $gray-normal; + color: $white-light; background-color: $purple-900; border-bottom: 0; @@ -26,20 +26,22 @@ header.navbar-gitlab-new { align-items: center; height: 100%; padding-top: 3px; - padding-left: 9px; - padding-right: 9px; - margin-left: -9px; + padding-right: $gl-padding; + padding-left: $gl-padding; + margin-left: -$gl-padding; border-bottom: 3px solid transparent; @media (min-width: $screen-sm-min) { padding-right: $gl-padding; padding-left: $gl-padding; - margin-left: -16px; } svg { margin-top: -3px; - margin-right: 10px; + + @media (min-width: $screen-sm-min) { + margin-right: 10px; + } } &:hover, @@ -71,12 +73,17 @@ header.navbar-gitlab-new { .navbar-collapse { padding-left: 0; color: $white-light; + box-shadow: 0; @media (max-width: $screen-xs-max) { margin-left: -$gl-padding; margin-right: -10px; } + .dropdown-bold-header { + color: initial; + } + .nav { > li:not(.hidden-xs) a { @media (max-width: $screen-xs-max) { @@ -91,7 +98,7 @@ header.navbar-gitlab-new { .navbar-toggle { min-width: 45px; padding: 6px $gl-padding; - margin-right: -5px; + margin-right: -7px; font-size: 14px; text-align: center; color: currentColor; @@ -107,6 +114,7 @@ header.navbar-gitlab-new { .navbar-nav { @media (max-width: $screen-xs-max) { + display: flex; padding-right: 10px; } @@ -117,22 +125,37 @@ header.navbar-gitlab-new { } } - .nav > li > a { - opacity: .9; - will-change: opacity; - - &:hover, - &:focus { - color: $white-light; - opacity: 1; - - > svg { - fill: $white-light; + .nav > li { + &.header-user { + @media (max-width: $screen-xs-max) { + padding-left: 10px; } + } + + > a { + background: none; + opacity: .9; + will-change: opacity; &.header-user-dropdown-toggle { .header-user-avatar { - border: 0; + border-color: $white-light; + } + } + + &:hover, + &:focus { + color: $white-light; + opacity: 1; + + > svg { + fill: $white-light; + } + + &.header-user-dropdown-toggle { + .header-user-avatar { + border-color: $white-light; + } } } } @@ -219,7 +242,8 @@ header.navbar-gitlab-new { } .search-input-wrap { - .search-icon { + .search-icon, + .clear-icon { color: rgba($white-light, .6); } } -- cgit v1.2.1