From 3818ef49dffd19a7540193de14c3a4fc918ec751 Mon Sep 17 00:00:00 2001
From: Marius Bobin <mbobin@gitlab.com>
Date: Tue, 20 Aug 2019 12:34:00 +0300
Subject: Remove anonymous user as admin combination

Remove anonymous(nil) user as admin combination from the visibility
table because it is already covered in the is_admin=false entry.
We don't pass the user along in the request, so the fact that he is
or is not an admin is not relevant.
---
 spec/requests/api/pipelines_spec.rb | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/spec/requests/api/pipelines_spec.rb b/spec/requests/api/pipelines_spec.rb
index bfe5406c5d6..1c06fb2c01e 100644
--- a/spec/requests/api/pipelines_spec.rb
+++ b/spec/requests/api/pipelines_spec.rb
@@ -317,7 +317,6 @@ describe API::Pipelines do
       end
 
       where(:visibility_level, :builds_access_level, :public_builds, :is_admin, :user_role, :response_status) do
-        :private  | :enabled | true  | true  | nil         | 404
         :private  | :enabled | true  | true  | :non_member | 200
         :private  | :enabled | true  | true  | :guest      | 200
         :private  | :enabled | true  | true  | :reporter   | 200
@@ -331,7 +330,6 @@ describe API::Pipelines do
         :private  | :enabled | true  | false | :developer  | 200
         :private  | :enabled | true  | false | :maintainer | 200
 
-        :private  | :enabled | false | true  | nil         | 404
         :private  | :enabled | false | true  | :non_member | 200
         :private  | :enabled | false | true  | :guest      | 200
         :private  | :enabled | false | true  | :reporter   | 200
@@ -345,7 +343,6 @@ describe API::Pipelines do
         :private  | :enabled | false | false | :developer  | 200
         :private  | :enabled | false | false | :maintainer | 200
 
-        :private  | :private | true  | true  | nil         | 404
         :private  | :private | true  | true  | :non_member | 200
         :private  | :private | true  | true  | :guest      | 200
         :private  | :private | true  | true  | :reporter   | 200
@@ -359,7 +356,6 @@ describe API::Pipelines do
         :private  | :private | true  | false | :developer  | 200
         :private  | :private | true  | false | :maintainer | 200
 
-        :private  | :private | false | true  | nil         | 404
         :private  | :private | false | true  | :non_member | 200
         :private  | :private | false | true  | :guest      | 200
         :private  | :private | false | true  | :reporter   | 200
@@ -373,7 +369,6 @@ describe API::Pipelines do
         :private  | :private | false | false | :developer  | 200
         :private  | :private | false | false | :maintainer | 200
 
-        :internal | :enabled | true  | true  | nil         | 404
         :internal | :enabled | true  | true  | :non_member | 200
         :internal | :enabled | true  | true  | :guest      | 200
         :internal | :enabled | true  | true  | :reporter   | 200
@@ -387,7 +382,6 @@ describe API::Pipelines do
         :internal | :enabled | true  | false | :developer  | 200
         :internal | :enabled | true  | false | :maintainer | 200
 
-        :internal | :enabled | false | true  | nil         | 404
         :internal | :enabled | false | true  | :non_member | 200
         :internal | :enabled | false | true  | :guest      | 200
         :internal | :enabled | false | true  | :reporter   | 200
@@ -401,7 +395,6 @@ describe API::Pipelines do
         :internal | :enabled | false | false | :developer  | 200
         :internal | :enabled | false | false | :maintainer | 200
 
-        :internal | :private | true  | true  | nil         | 404
         :internal | :private | true  | true  | :non_member | 200
         :internal | :private | true  | true  | :guest      | 200
         :internal | :private | true  | true  | :reporter   | 200
@@ -415,7 +408,6 @@ describe API::Pipelines do
         :internal | :private | true  | false | :developer  | 200
         :internal | :private | true  | false | :maintainer | 200
 
-        :internal | :private | false | true  | nil         | 404
         :internal | :private | false | true  | :non_member | 200
         :internal | :private | false | true  | :guest      | 200
         :internal | :private | false | true  | :reporter   | 200
@@ -429,7 +421,6 @@ describe API::Pipelines do
         :internal | :private | false | false | :developer  | 200
         :internal | :private | false | false | :maintainer | 200
 
-        :public   | :enabled | true  | true  | nil         | 200
         :public   | :enabled | true  | true  | :non_member | 200
         :public   | :enabled | true  | true  | :guest      | 200
         :public   | :enabled | true  | true  | :reporter   | 200
@@ -443,7 +434,6 @@ describe API::Pipelines do
         :public   | :enabled | true  | false | :developer  | 200
         :public   | :enabled | true  | false | :maintainer | 200
 
-        :public   | :enabled | false | true  | nil         | 403
         :public   | :enabled | false | true  | :non_member | 200
         :public   | :enabled | false | true  | :guest      | 200
         :public   | :enabled | false | true  | :reporter   | 200
@@ -457,7 +447,6 @@ describe API::Pipelines do
         :public   | :enabled | false | false | :developer  | 200
         :public   | :enabled | false | false | :maintainer | 200
 
-        :public   | :private | true  | true  | nil         | 403
         :public   | :private | true  | true  | :non_member | 200
         :public   | :private | true  | true  | :guest      | 200
         :public   | :private | true  | true  | :reporter   | 200
@@ -471,7 +460,6 @@ describe API::Pipelines do
         :public   | :private | true  | false | :developer  | 200
         :public   | :private | true  | false | :maintainer | 200
 
-        :public   | :private | false | true  | nil         | 403
         :public   | :private | false | true  | :non_member | 200
         :public   | :private | false | true  | :guest      | 200
         :public   | :private | false | true  | :reporter   | 200
-- 
cgit v1.2.1