From 3b228db1c20ed582c911e3269551fcdfd9f1bde7 Mon Sep 17 00:00:00 2001 From: Alfredo Sumaran Date: Wed, 3 Aug 2016 19:28:05 -0500 Subject: Remove unnecesary classes to generate dropdowns Since there are only one dropdown of each type there are no need to create a class to initialize multiple elements with the same CSS class name. --- app/assets/javascripts/allowed_to_merge_dropdowns.js.es6 | 13 ------------- app/assets/javascripts/allowed_to_push_dropdowns.js.es6 | 13 ------------- app/assets/javascripts/protected_branch_create.js.es6 | 10 ++++++---- 3 files changed, 6 insertions(+), 30 deletions(-) delete mode 100644 app/assets/javascripts/allowed_to_merge_dropdowns.js.es6 delete mode 100644 app/assets/javascripts/allowed_to_push_dropdowns.js.es6 diff --git a/app/assets/javascripts/allowed_to_merge_dropdowns.js.es6 b/app/assets/javascripts/allowed_to_merge_dropdowns.js.es6 deleted file mode 100644 index 3f62ad26f0f..00000000000 --- a/app/assets/javascripts/allowed_to_merge_dropdowns.js.es6 +++ /dev/null @@ -1,13 +0,0 @@ -class AllowedToMergeDropdowns { - constructor (options) { - const { $dropdowns, onSelect } = options; - - $dropdowns.each((i, el) => { - new ProtectedBranchAccessDropdown({ - $dropdown: $(el), - data: gon.merge_access_levels, - onSelect: onSelect - }); - }); - } -} diff --git a/app/assets/javascripts/allowed_to_push_dropdowns.js.es6 b/app/assets/javascripts/allowed_to_push_dropdowns.js.es6 deleted file mode 100644 index 055be38ccdb..00000000000 --- a/app/assets/javascripts/allowed_to_push_dropdowns.js.es6 +++ /dev/null @@ -1,13 +0,0 @@ -class AllowedToPushDropdowns { - constructor (options) { - const { $dropdowns, onSelect } = options; - - $dropdowns.each((i, el) => { - new ProtectedBranchAccessDropdown({ - $dropdown: $(el), - data: gon.push_access_levels, - onSelect: onSelect - }); - }); - } -} \ No newline at end of file diff --git a/app/assets/javascripts/protected_branch_create.js.es6 b/app/assets/javascripts/protected_branch_create.js.es6 index efe91478b66..0b57964a0eb 100644 --- a/app/assets/javascripts/protected_branch_create.js.es6 +++ b/app/assets/javascripts/protected_branch_create.js.es6 @@ -6,14 +6,16 @@ class ProtectedBranchCreate { buildDropdowns() { // Allowed to Merge dropdowns - new AllowedToMergeDropdowns({ - $dropdowns: this.$wrap.find('.js-allowed-to-merge'), + new ProtectedBranchAccessDropdown({ + $dropdown: this.$wrap.find('.js-allowed-to-merge'), + data: gon.merge_access_levels, onSelect: this.onSelect.bind(this) }); // Allowed to Push dropdowns - new AllowedToPushDropdowns({ - $dropdowns: this.$wrap.find('.js-allowed-to-push'), + new ProtectedBranchAccessDropdown({ + $dropdown: this.$wrap.find('.js-allowed-to-push'), + data: gon.push_access_levels, onSelect: this.onSelect.bind(this) }); -- cgit v1.2.1