From 4392b57e227cb724f6623e9f9b9c2d4451d2774d Mon Sep 17 00:00:00 2001 From: Andrew Newdigate Date: Tue, 5 Mar 2019 14:47:23 +0200 Subject: Add more documentation around how polling works --- doc/development/polling.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/development/polling.md b/doc/development/polling.md index 76bb5ae7819..f6db6889ecc 100644 --- a/doc/development/polling.md +++ b/doc/development/polling.md @@ -1,5 +1,9 @@ # Polling with ETag caching +TODO: we should probably document the side-effect that sharing etags per path, not on the full URL means that invalidating the path will intentionally invalidate all query strings for that path. +TODO: Yes, and we should also note that the content itself will still be different - we only use the path for computing the ETag, not for the body (when there is a cache miss). +TODO: See https://gitlab.com/gitlab-org/gitlab-ce/issues/58500 + Polling for changes (repeatedly asking server if there are any new changes) introduces high load on a GitLab instance, because it usually requires executing at least a few SQL queries. This makes scaling large GitLab -- cgit v1.2.1