From 4720346c2e10e1ff62a20b39dfc9866eb88858e6 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Mon, 24 Apr 2023 12:08:36 +0000 Subject: Add latest changes from gitlab-org/gitlab@master --- .../dropdown_contents_labels_view.vue | 16 +- app/assets/stylesheets/page_bundles/import.scss | 12 +- .../mutations/ci/job_token_scope/add_project.rb | 16 +- .../mutations/ci/project_ci_cd_settings_update.rb | 8 + app/models/project.rb | 5 + .../ci/job_token_scope/add_project_service.rb | 2 +- .../development/ci_fix_max_includes.yml | 8 - .../frozen_outbound_job_token_scopes.yml | 8 + .../frozen_outbound_job_token_scopes_override.yml | 8 + .../record_issue_and_mr_assignee_events.yml | 2 +- ...mary_and_secondary_stores_for_rate_limiting.yml | 8 - ..._primary_store_as_default_for_rate_limiting.yml | 8 - ...58_i_container_registry_writes_user_monthly.yml | 32 ++ ...146_i_container_registry_writes_user_weekly.yml | 32 ++ doc/administration/logs/index.md | 5 + doc/administration/redis/troubleshooting.md | 2 +- doc/api/dora/metrics.md | 2 +- doc/api/graphql/reference/index.md | 6 +- doc/ci/interactive_web_terminal/index.md | 6 +- doc/development/features_inside_dot_gitlab.md | 1 - doc/development/i18n/proofreader.md | 2 +- doc/user/profile/preferences.md | 15 - .../project/members/share_project_with_groups.md | 6 +- .../project/remote_development/connect_machine.md | 4 +- doc/user/project/remote_development/index.md | 4 +- doc/user/project/repository/code_suggestions.md | 2 +- .../web_ide/img/admin_live_preview_v13_0.png | Bin 5508 -> 0 bytes .../project/web_ide/img/commit_changes_v13_11.png | Bin 116443 -> 0 bytes doc/user/project/web_ide/img/dark_theme_v13_0.png | Bin 99238 -> 0 bytes .../project/web_ide/img/fuzzy_finder_v15_7.png | Bin 0 -> 121069 bytes .../project/web_ide/img/live_preview_v13_0.png | Bin 29188 -> 0 bytes .../web_ide/img/solarized_dark_theme_v13_1.png | Bin 43014 -> 0 bytes doc/user/project/web_ide/img/terminal_status.png | Bin 3709 -> 0 bytes doc/user/project/web_ide/index.md | 504 +++++---------------- .../web_ide_beta/img/fuzzy_finder_v15_7.png | Bin 121069 -> 0 bytes doc/user/project/web_ide_beta/index.md | 140 +----- lib/api/api.rb | 1 + lib/api/entities/project_job_token_scope.rb | 14 + lib/api/project_job_token_scope.rb | 27 ++ lib/gitlab/ci/config/external/mapper/verifier.rb | 32 +- lib/gitlab/redis.rb | 1 - lib/gitlab/redis/cluster_rate_limiting.rb | 11 - lib/gitlab/redis/rate_limiting.rb | 9 - .../projects/clusters_controller_spec.rb | 2 +- .../environments/prometheus_api_controller_spec.rb | 2 +- .../projects/grafana_api_controller_spec.rb | 2 +- .../dashboards_controller_spec.rb | 4 +- .../projects/releases_controller_spec.rb | 6 +- spec/features/admin/admin_runners_spec.rb | 4 +- spec/features/explore/groups_spec.rb | 44 +- spec/features/groups/group_settings_spec.rb | 6 +- spec/features/groups/packages_spec.rb | 2 +- .../projects/files/user_browses_files_spec.rb | 7 +- .../settings/forked_project_settings_spec.rb | 2 +- .../settings/user_renames_a_project_spec.rb | 2 +- .../authentication/webauthn/authenticate_spec.js | 5 +- .../authentication/webauthn/register_spec.js | 5 +- .../dropdown_contents_labels_view_spec.js | 292 ++++++------ .../ci/job_token_scope/add_project_spec.rb | 52 ++- spec/helpers/application_helper_spec.rb | 6 +- spec/helpers/labels_helper_spec.rb | 10 +- spec/helpers/merge_requests_helper_spec.rb | 49 +- .../api/entities/project_job_token_scope_spec.rb | 38 ++ spec/lib/container_registry/path_spec.rb | 10 +- .../ci/config/external/mapper/verifier_spec.rb | 50 -- spec/lib/gitlab/consul/internal_spec.rb | 6 +- .../gitlab/email/message/repository_push_spec.rb | 2 +- .../import_export/project/export_task_spec.rb | 8 +- .../lib/gitlab/redis/cluster_rate_limiting_spec.rb | 7 - spec/mailers/emails/pages_domains_spec.rb | 10 +- spec/models/design_management/design_spec.rb | 12 +- .../chat_message/deployment_message_spec.rb | 2 +- spec/models/issue_spec.rb | 12 +- spec/models/merge_request_spec.rb | 8 +- spec/models/milestone_spec.rb | 4 +- spec/models/operations/feature_flag_spec.rb | 6 +- spec/models/project_spec.rb | 6 +- spec/models/service_desk_setting_spec.rb | 4 +- spec/models/snippet_spec.rb | 8 +- spec/presenters/project_hook_presenter_spec.rb | 4 +- spec/presenters/service_hook_presenter_spec.rb | 4 +- .../ci/job_token_scope/add_project_spec.rb | 19 +- .../ci/project_ci_cd_settings_update_spec.rb | 51 ++- spec/requests/api/internal/pages_spec.rb | 18 +- spec/requests/api/project_job_token_scope_spec.rb | 76 ++++ spec/requests/api/projects_spec.rb | 22 +- spec/requests/api/release/links_spec.rb | 4 +- .../cross_project_pipeline_spec.rb | 8 +- .../ci/job_token_scope/add_project_service_spec.rb | 4 +- .../create_or_update_namespace_service_spec.rb | 2 +- spec/services/groups/transfer_service_spec.rb | 6 +- spec/services/projects/fork_service_spec.rb | 6 +- .../glfm/example_snapshot_fixtures.rb | 2 +- .../mailers/notify_shared_examples.rb | 2 +- .../requests/user_activity_shared_examples.rb | 2 +- spec/uploaders/file_uploader_spec.rb | 8 +- 96 files changed, 832 insertions(+), 1060 deletions(-) delete mode 100644 config/feature_flags/development/ci_fix_max_includes.yml create mode 100644 config/feature_flags/development/frozen_outbound_job_token_scopes.yml create mode 100644 config/feature_flags/development/frozen_outbound_job_token_scopes_override.yml delete mode 100644 config/feature_flags/development/use_primary_and_secondary_stores_for_rate_limiting.yml delete mode 100644 config/feature_flags/development/use_primary_store_as_default_for_rate_limiting.yml create mode 100644 config/metrics/counts_28d/20230417064258_i_container_registry_writes_user_monthly.yml create mode 100644 config/metrics/counts_7d/20230417063146_i_container_registry_writes_user_weekly.yml delete mode 100644 doc/user/project/web_ide/img/admin_live_preview_v13_0.png delete mode 100644 doc/user/project/web_ide/img/commit_changes_v13_11.png delete mode 100644 doc/user/project/web_ide/img/dark_theme_v13_0.png create mode 100644 doc/user/project/web_ide/img/fuzzy_finder_v15_7.png delete mode 100644 doc/user/project/web_ide/img/live_preview_v13_0.png delete mode 100644 doc/user/project/web_ide/img/solarized_dark_theme_v13_1.png delete mode 100644 doc/user/project/web_ide/img/terminal_status.png delete mode 100644 doc/user/project/web_ide_beta/img/fuzzy_finder_v15_7.png create mode 100644 lib/api/entities/project_job_token_scope.rb create mode 100644 lib/api/project_job_token_scope.rb delete mode 100644 lib/gitlab/redis/cluster_rate_limiting.rb create mode 100644 spec/lib/api/entities/project_job_token_scope_spec.rb delete mode 100644 spec/lib/gitlab/redis/cluster_rate_limiting_spec.rb create mode 100644 spec/requests/api/project_job_token_scope_spec.rb diff --git a/app/assets/javascripts/sidebar/components/labels/labels_select_vue/dropdown_contents_labels_view.vue b/app/assets/javascripts/sidebar/components/labels/labels_select_vue/dropdown_contents_labels_view.vue index ee6b531c1ca..3db962c7fe8 100644 --- a/app/assets/javascripts/sidebar/components/labels/labels_select_vue/dropdown_contents_labels_view.vue +++ b/app/assets/javascripts/sidebar/components/labels/labels_select_vue/dropdown_contents_labels_view.vue @@ -80,9 +80,6 @@ export default { 'updateSelectedLabels', 'toggleDropdownContents', ]), - isLabelSelected(label) { - return this.selectedLabelsList.includes(label.id); - }, /** * This method scrolls item from dropdown into * the view if it is off the viewable area of the @@ -160,7 +157,11 @@ export default {