From 4ee706fcd1ffcb2926fd9258e9f296c260a3d06c Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 1 Dec 2022 12:09:35 +0000 Subject: Add latest changes from gitlab-org/gitlab@master --- .rubocop.yml | 16 -- .rubocop_todo/rails/http_status.yml | 9 - .../components/pages_pipeline_wizard.vue | 2 +- .../javascripts/groups/components/group_item.vue | 8 +- .../permissions/components/settings_panel.vue | 90 +++++++--- .../pipelines/components/graph/job_item.vue | 2 +- .../components/jobs_shared/job_name_component.vue | 2 +- .../components/pipeline_mini_graph/job_item.vue | 4 +- .../pipeline_mini_graph/pipeline_stage.vue | 2 +- .../javascripts/search/topbar/components/app.vue | 8 +- app/assets/javascripts/search/topbar/index.js | 20 ++- app/assets/stylesheets/framework/variables.scss | 1 - .../stylesheets/page_bundles/_pipeline_mixins.scss | 23 +-- app/assets/stylesheets/startup/startup-dark.scss | 194 +-------------------- app/assets/stylesheets/themes/_dark.scss | 135 -------------- .../stylesheets/themes/dark_mode_overrides.scss | 134 ++++++++++++++ .../concerns/invisible_captcha_on_signup.rb | 2 +- app/controllers/dashboard/snippets_controller.rb | 2 +- app/controllers/explore/snippets_controller.rb | 2 +- .../projects/autocomplete_sources_controller.rb | 2 +- .../projects/runner_projects_controller.rb | 2 +- .../projects/service_ping_controller.rb | 6 +- .../projects/snippets/application_controller.rb | 2 +- .../repositories/lfs_storage_controller.rb | 2 +- app/controllers/search_controller.rb | 7 +- app/controllers/snippets/application_controller.rb | 2 +- app/controllers/snippets/notes_controller.rb | 2 +- app/controllers/users_controller.rb | 3 +- app/models/user.rb | 28 +-- app/models/user_preference.rb | 69 +++++++- app/services/chat_names/find_user_service.rb | 7 + app/views/search/show.html.haml | 2 +- config/feature_categories.yml | 4 +- config/webpack.config.js | 1 + doc/api/product_analytics.md | 6 +- doc/operations/incident_management/alerts.md | 17 +- .../img/alert_detail_add_todo_v13_9.png | Bin 26763 -> 0 bytes doc/user/product_analytics/index.md | 24 +-- jest.config.base.js | 2 + lib/api/helpers/award_emoji.rb | 2 +- lib/api/helpers/discussions_helpers.rb | 2 +- lib/api/helpers/notes_helpers.rb | 2 +- lib/api/project_snippets.rb | 2 +- lib/api/snippets.rb | 2 +- lib/gitlab/memory/watchdog.rb | 51 ++---- lib/gitlab/memory/watchdog/configuration.rb | 6 +- lib/gitlab/memory/watchdog/configurator.rb | 3 +- lib/gitlab/memory/watchdog/event_reporter.rb | 73 ++++++++ locale/gitlab.pot | 24 ++- package.json | 2 +- rubocop/cop/rspec/timecop_freeze.rb | 41 ----- rubocop/cop/rspec/timecop_travel.rb | 41 ----- spec/features/dashboard/snippets_spec.rb | 2 +- .../projects/settings/packages_settings_spec.rb | 4 + spec/features/snippets/embedded_snippet_spec.rb | 2 +- spec/features/snippets/explore_spec.rb | 2 +- spec/features/snippets/internal_snippet_spec.rb | 2 +- .../snippets/notes_on_personal_snippets_spec.rb | 2 +- spec/features/snippets/private_snippets_spec.rb | 2 +- spec/features/snippets/public_snippets_spec.rb | 2 +- spec/features/snippets/search_snippets_spec.rb | 2 +- spec/features/snippets/show_spec.rb | 2 +- spec/features/snippets/spam_snippets_spec.rb | 2 +- .../features/snippets/user_creates_snippet_spec.rb | 2 +- .../features/snippets/user_deletes_snippet_spec.rb | 2 +- spec/features/snippets/user_edits_snippet_spec.rb | 2 +- spec/features/snippets/user_snippets_spec.rb | 2 +- .../permissions/components/settings_panel_spec.js | 74 ++++++-- spec/lib/api/every_api_endpoint_spec.rb | 15 +- .../gitlab/memory/watchdog/configuration_spec.rb | 8 +- .../gitlab/memory/watchdog/configurator_spec.rb | 12 +- .../gitlab/memory/watchdog/event_reporter_spec.rb | 118 +++++++++++++ spec/lib/gitlab/memory/watchdog_spec.rb | 97 +++-------- spec/models/user_preference_spec.rb | 157 ++++++++++++++++- spec/models/user_spec.rb | 64 ++++++- spec/rubocop/cop/rspec/timecop_freeze_spec.rb | 28 --- spec/rubocop/cop/rspec/timecop_travel_spec.rb | 28 --- spec/services/chat_names/find_user_service_spec.rb | 8 + workhorse/go.mod | 2 +- workhorse/go.sum | 3 +- yarn.lock | 8 +- 81 files changed, 961 insertions(+), 788 deletions(-) delete mode 100644 .rubocop_todo/rails/http_status.yml delete mode 100644 doc/operations/incident_management/img/alert_detail_add_todo_v13_9.png create mode 100644 lib/gitlab/memory/watchdog/event_reporter.rb delete mode 100644 rubocop/cop/rspec/timecop_freeze.rb delete mode 100644 rubocop/cop/rspec/timecop_travel.rb create mode 100644 spec/lib/gitlab/memory/watchdog/event_reporter_spec.rb delete mode 100644 spec/rubocop/cop/rspec/timecop_freeze_spec.rb delete mode 100644 spec/rubocop/cop/rspec/timecop_travel_spec.rb diff --git a/.rubocop.yml b/.rubocop.yml index 2367cef34b8..8113b7d6a7b 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -450,22 +450,6 @@ Cop/ActiveModelErrorsDirectManipulation: Gitlab/AvoidFeatureGet: Enabled: true -RSpec/TimecopFreeze: - Enabled: true - AutoCorrect: true - Include: - - 'spec/**/*.rb' - - 'ee/spec/**/*.rb' - - 'qa/spec/**/*.rb' - -RSpec/TimecopTravel: - Enabled: true - AutoCorrect: true - Include: - - 'spec/**/*.rb' - - 'ee/spec/**/*.rb' - - 'qa/spec/**/*.rb' - RSpec/WebMockEnable: Enabled: true Include: diff --git a/.rubocop_todo/rails/http_status.yml b/.rubocop_todo/rails/http_status.yml deleted file mode 100644 index b1f64f7aa18..00000000000 --- a/.rubocop_todo/rails/http_status.yml +++ /dev/null @@ -1,9 +0,0 @@ ---- -# Cop supports --autocorrect. -Rails/HttpStatus: - Exclude: - - 'app/controllers/concerns/invisible_captcha_on_signup.rb' - - 'app/controllers/projects/runner_projects_controller.rb' - - 'app/controllers/projects/service_ping_controller.rb' - - 'app/controllers/repositories/lfs_storage_controller.rb' - - 'ee/app/controllers/trials_controller.rb' diff --git a/app/assets/javascripts/gitlab_pages/components/pages_pipeline_wizard.vue b/app/assets/javascripts/gitlab_pages/components/pages_pipeline_wizard.vue index f17a05999b0..bf71f682048 100644 --- a/app/assets/javascripts/gitlab_pages/components/pages_pipeline_wizard.vue +++ b/app/assets/javascripts/gitlab_pages/components/pages_pipeline_wizard.vue @@ -2,7 +2,7 @@ import { GlLoadingIcon } from '@gitlab/ui'; import { captureException } from '@sentry/browser'; import PipelineWizard from '~/pipeline_wizard/pipeline_wizard.vue'; -import PagesWizardTemplate from '~/pipeline_wizard/templates/pages.yml'; +import PagesWizardTemplate from '~/pipeline_wizard/templates/pages.yml?raw'; import { logError } from '~/lib/logger'; import { s__ } from '~/locale'; import { redirectTo } from '~/lib/utils/url_utility'; diff --git a/app/assets/javascripts/groups/components/group_item.vue b/app/assets/javascripts/groups/components/group_item.vue index 3874d06da91..d9781ef9c84 100644 --- a/app/assets/javascripts/groups/components/group_item.vue +++ b/app/assets/javascripts/groups/components/group_item.vue @@ -200,11 +200,9 @@ export default { class="no-expand gl-mr-3 gl-text-gray-900!" :itemprop="microdata.nameItemprop" > - {{ - // ending bracket must be by closing tag to prevent - // link hover text-decoration from over-extending - group.name - }} + + + {{ group.name }} featureAccessLevel.NOT_ENABLED; + }, + packageRegistryApiForEveryoneEnabled() { + return this.packageRegistryAccessLevel === FEATURE_ACCESS_LEVEL_ANONYMOUS[0]; + }, + packageRegistryApiForEveryoneEnabledShown() { + return this.visibilityLevel !== VISIBILITY_LEVEL_PUBLIC_INTEGER; + }, splitOperationsEnabled() { return this.glFeatures.splitOperationsVisibilityPermissions; }, @@ -474,9 +481,8 @@ export default { this.packageRegistryAccessLevelEnabled && this.packageRegistryAccessLevel === featureAccessLevel.PROJECT_MEMBERS ) { - this.packageRegistryAccessLevel = Math.min( - ...this.packageRegistryFeatureAccessLevelOptions.map((option) => option[0]), - ); + this.packageRegistryAccessLevel = + PACKAGE_REGISTRY_ACCESS_LEVEL_DEFAULT_BY_PROJECT_VISIBILITY[value]; } if (this.buildsAccessLevel > featureAccessLevel.NOT_ENABLED) this.buildsAccessLevel = featureAccessLevel.EVERYONE; @@ -561,6 +567,22 @@ export default { visibilityAllowed(option) { return this.allowedVisibilityOptions.includes(option); }, + onPackageRegistryEnabledToggle(value) { + this.packageRegistryAccessLevel = value + ? this.packageRegistryAccessLevelDefault() + : featureAccessLevel.NOT_ENABLED; + }, + onPackageRegistryApiForEveryoneEnabledToggle(value) { + this.packageRegistryAccessLevel = value + ? FEATURE_ACCESS_LEVEL_ANONYMOUS[0] + : this.packageRegistryAccessLevelDefault(); + }, + packageRegistryAccessLevelDefault() { + return ( + PACKAGE_REGISTRY_ACCESS_LEVEL_DEFAULT_BY_PROJECT_VISIBILITY[this.visibilityLevel] ?? + featureAccessLevel.NOT_ENABLED + ); + }, }, }; @@ -897,10 +919,36 @@ export default { :help-text="$options.i18n.packageRegistryHelpText" data-testid="package-registry-access-level" > - +
+ + + +
+ @@ -927,7 +975,7 @@ export default { ref="monitor-settings" :label="$options.i18n.monitorLabel" :help-text=" - s__('ProjectSettings|Configure your project resources and monitor their health.') + s__('ProjectSettings|Monitor the health of your project and respond to incidents.') " > -
+
{{ job.name }}
diff --git a/app/assets/javascripts/pipelines/components/jobs_shared/job_name_component.vue b/app/assets/javascripts/pipelines/components/jobs_shared/job_name_component.vue index f4fc6893520..1c7f5a7476d 100644 --- a/app/assets/javascripts/pipelines/components/jobs_shared/job_name_component.vue +++ b/app/assets/javascripts/pipelines/components/jobs_shared/job_name_component.vue @@ -29,7 +29,7 @@ export default { };