From 50afa5fd3b4083e8e04c140f22ed95a34159dce6 Mon Sep 17 00:00:00 2001 From: Alfredo Sumaran Date: Thu, 17 Nov 2016 20:55:55 -0500 Subject: Combine components for better legibility --- .../components/item_build_component.js.es6 | 62 ---------------------- .../components/item_issue_component.js.es6 | 53 ------------------ .../components/item_merge_request_component.js.es6 | 53 ------------------ .../components/stage_code_component.js.es6 | 29 ++++++++-- .../components/stage_issue_component.js.es6 | 33 ++++++++++-- .../components/stage_plan_component.js.es6 | 30 +++++++++-- .../components/stage_production_component.js.es6 | 35 +++++++++--- .../components/stage_review_component.js.es6 | 41 ++++++++++++-- .../components/stage_staging_component.js.es6 | 37 ++++++++++--- .../components/stage_test_component.js.es6 | 41 ++++++++++++-- .../cycle_analytics/cycle_analytics_store.js.es6 | 2 +- app/assets/stylesheets/pages/cycle_analytics.scss | 11 ++++ 12 files changed, 220 insertions(+), 207 deletions(-) delete mode 100644 app/assets/javascripts/cycle_analytics/components/item_build_component.js.es6 delete mode 100644 app/assets/javascripts/cycle_analytics/components/item_issue_component.js.es6 delete mode 100644 app/assets/javascripts/cycle_analytics/components/item_merge_request_component.js.es6 diff --git a/app/assets/javascripts/cycle_analytics/components/item_build_component.js.es6 b/app/assets/javascripts/cycle_analytics/components/item_build_component.js.es6 deleted file mode 100644 index d56ab58670a..00000000000 --- a/app/assets/javascripts/cycle_analytics/components/item_build_component.js.es6 +++ /dev/null @@ -1,62 +0,0 @@ -((global) => { - global.cycleAnalytics = global.cycleAnalytics || {}; - - /* - `build` prop should have - - - Build name/title - - Build ID - - Build URL - - Build branch - - Build branch URL - - Build short SHA - - Build commit URL - - Build date - - Total time - */ - - global.cycleAnalytics.ItemBuildComponent = Vue.extend({ - props: { - build: Object, - }, - template: ` -
- -
- -
-
- `, - }); -}(window.gl || (window.gl = {}))); diff --git a/app/assets/javascripts/cycle_analytics/components/item_issue_component.js.es6 b/app/assets/javascripts/cycle_analytics/components/item_issue_component.js.es6 deleted file mode 100644 index 17a77cf4369..00000000000 --- a/app/assets/javascripts/cycle_analytics/components/item_issue_component.js.es6 +++ /dev/null @@ -1,53 +0,0 @@ -((global) => { - global.cycleAnalytics = global.cycleAnalytics || {}; - - /* - `issue` prop should have - - - Issue title - - Issue URL - - Issue ID - - Issue date created - - Issue author - - Issue author profile URL - - Issue author avatar URL - - Total time - */ - - global.cycleAnalytics.ItemIssueComponent = Vue.extend({ - props: { - issue: Object, - }, - template: ` -
- -
- -
-
- `, - }); -})(window.gl || (window.gl = {})); diff --git a/app/assets/javascripts/cycle_analytics/components/item_merge_request_component.js.es6 b/app/assets/javascripts/cycle_analytics/components/item_merge_request_component.js.es6 deleted file mode 100644 index 36da613cccf..00000000000 --- a/app/assets/javascripts/cycle_analytics/components/item_merge_request_component.js.es6 +++ /dev/null @@ -1,53 +0,0 @@ -((global) => { - global.cycleAnalytics = global.cycleAnalytics || {}; - - /* - `mergeRequest` prop should have - - - MR title - - MR URL - - MR ID - - MR date opened - - MR author - - MR author profile URL - - MR author avatar URL - - Total time - */ - - global.cycleAnalytics.ItemMergeRequestComponent = Vue.extend({ - props: { - mergeRequest: Object, - }, - template: ` -
- -
- -
-
- `, - }); -}(window.gl || (window.gl = {}))); diff --git a/app/assets/javascripts/cycle_analytics/components/stage_code_component.js.es6 b/app/assets/javascripts/cycle_analytics/components/stage_code_component.js.es6 index b070d22af8a..4949743c797 100644 --- a/app/assets/javascripts/cycle_analytics/components/stage_code_component.js.es6 +++ b/app/assets/javascripts/cycle_analytics/components/stage_code_component.js.es6 @@ -3,9 +3,6 @@ global.cycleAnalytics = global.cycleAnalytics || {}; global.cycleAnalytics.StageCodeComponent = Vue.extend({ - components: { - 'item-merge-request-component': gl.cycleAnalytics.ItemMergeRequestComponent, - }, props: { items: Array, stage: Object, @@ -16,8 +13,30 @@ {{ stage.description }} diff --git a/app/assets/javascripts/cycle_analytics/components/stage_issue_component.js.es6 b/app/assets/javascripts/cycle_analytics/components/stage_issue_component.js.es6 index 204f4d1b806..4552eddb1f6 100644 --- a/app/assets/javascripts/cycle_analytics/components/stage_issue_component.js.es6 +++ b/app/assets/javascripts/cycle_analytics/components/stage_issue_component.js.es6 @@ -3,9 +3,6 @@ global.cycleAnalytics = global.cycleAnalytics || {}; global.cycleAnalytics.StageIssueComponent = Vue.extend({ - components: { - 'item-issue-component': gl.cycleAnalytics.ItemIssueComponent, - }, props: { items: Array, stage: Object, @@ -16,8 +13,34 @@ {{ stage.description }} diff --git a/app/assets/javascripts/cycle_analytics/components/stage_plan_component.js.es6 b/app/assets/javascripts/cycle_analytics/components/stage_plan_component.js.es6 index 637f3877a2e..d6fa1244ef8 100644 --- a/app/assets/javascripts/cycle_analytics/components/stage_plan_component.js.es6 +++ b/app/assets/javascripts/cycle_analytics/components/stage_plan_component.js.es6 @@ -3,9 +3,6 @@ global.cycleAnalytics = global.cycleAnalytics || {}; global.cycleAnalytics.StagePlanComponent = Vue.extend({ - components: { - 'item-commit-component': gl.cycleAnalytics.ItemCommitComponent, - }, props: { items: Array, stage: Object, @@ -16,8 +13,31 @@ {{ stage.description }} diff --git a/app/assets/javascripts/cycle_analytics/components/stage_production_component.js.es6 b/app/assets/javascripts/cycle_analytics/components/stage_production_component.js.es6 index 8616316d69b..ee8b96a088a 100644 --- a/app/assets/javascripts/cycle_analytics/components/stage_production_component.js.es6 +++ b/app/assets/javascripts/cycle_analytics/components/stage_production_component.js.es6 @@ -3,9 +3,6 @@ global.cycleAnalytics = global.cycleAnalytics || {}; global.cycleAnalytics.StageProductionComponent = Vue.extend({ - components: { - 'item-issue-component': gl.cycleAnalytics.ItemIssueComponent, - }, props: { items: Array, stage: Object, @@ -15,9 +12,35 @@
{{ stage.description }}
-