From 601c24d5b6b4b10ea986223c7a38110435420dbe Mon Sep 17 00:00:00 2001 From: Michael Kozono Date: Thu, 11 Jan 2018 11:17:38 -0800 Subject: Add RedirectRoute factory --- spec/factories/redirect_routes.rb | 15 +++++++++++++++ spec/models/route_spec.rb | 6 +++--- 2 files changed, 18 insertions(+), 3 deletions(-) create mode 100644 spec/factories/redirect_routes.rb diff --git a/spec/factories/redirect_routes.rb b/spec/factories/redirect_routes.rb new file mode 100644 index 00000000000..c29c81c5df9 --- /dev/null +++ b/spec/factories/redirect_routes.rb @@ -0,0 +1,15 @@ +FactoryBot.define do + factory :redirect_route do + sequence(:path) { |n| "redirect#{n}" } + source factory: :group + permanent false + + trait :permanent do + permanent true + end + + trait :temporary do + permanent false + end + end +end diff --git a/spec/models/route_spec.rb b/spec/models/route_spec.rb index 1266e0ea602..8a3b1034f3c 100644 --- a/spec/models/route_spec.rb +++ b/spec/models/route_spec.rb @@ -23,7 +23,7 @@ describe Route do context 'when permanent conflicting redirects exist' do it 'is invalid' do - redirect = RedirectRoute.new(path: 'foo/bar/baz', source: create(:group), permanent: true) + redirect = build(:redirect_route, :permanent, path: 'foo/bar/baz') redirect.save!(validate: false) expect(new_route.valid?).to be_falsey @@ -45,7 +45,7 @@ describe Route do context 'when permanent conflicting redirects exist' do it 'is invalid' do - redirect = RedirectRoute.new(path: 'foo/bar/baz', source: create(:group), permanent: true) + redirect = build(:redirect_route, :permanent, path: 'foo/bar/baz') redirect.save!(validate: false) expect(route.valid?).to be_falsey @@ -63,7 +63,7 @@ describe Route do context 'when path has not changed' do context 'when permanent conflicting redirects exist' do it 'is valid' do - redirect = RedirectRoute.new(path: 'git_lab/foo/bar', source: create(:group), permanent: true) + redirect = build(:redirect_route, :permanent, path: 'git_lab/foo/bar') redirect.save!(validate: false) expect(route.valid?).to be_truthy -- cgit v1.2.1