From 60525148e7532934913b56586ccdd4c37b74a637 Mon Sep 17 00:00:00 2001 From: Sean McGivern Date: Tue, 30 Apr 2019 13:31:52 +0100 Subject: Fix reviewer roulette when no-one is in a category This would return `people.size` before, when it should return `nil`. --- danger/roulette/Dangerfile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/danger/roulette/Dangerfile b/danger/roulette/Dangerfile index 27763052192..62e5526c02b 100644 --- a/danger/roulette/Dangerfile +++ b/danger/roulette/Dangerfile @@ -57,10 +57,12 @@ def spin_for_person(people, random:) people.size.times do person = people.sample(random: random) - return person unless out_of_office?(person) + break person unless out_of_office?(person) people -= [person] end + + person end def out_of_office?(person) -- cgit v1.2.1