From 65f4c0624c924ec15a380b49ff4405e855795c79 Mon Sep 17 00:00:00 2001 From: Annabel Dunstone Gray Date: Thu, 2 Mar 2017 10:02:16 -0600 Subject: Change toggle to a tag to add focus style on tab but not on click --- app/views/projects/boards/components/sidebar/_notifications.html.haml | 2 +- app/views/shared/issuable/_sidebar.html.haml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/views/projects/boards/components/sidebar/_notifications.html.haml b/app/views/projects/boards/components/sidebar/_notifications.html.haml index 6de3873eb48..05fae35245e 100644 --- a/app/views/projects/boards/components/sidebar/_notifications.html.haml +++ b/app/views/projects/boards/components/sidebar/_notifications.html.haml @@ -2,6 +2,6 @@ .block.light.subscription{ ":data-url" => "'#{namespace_project_issues_path(@project.namespace, @project)}/' + issue.id + '/toggle_subscription'" } %span.toggle-text.hide-collapsed.pull-left Notifications - %button.btn.toggle-button.pull-right.js-subscribe-button.issuable-subscribe-button.hide-collapsed{ type: "button" } + %a.btn.toggle-button.pull-right.js-subscribe-button.issuable-subscribe-button.hide-collapsed{ type: "button", href: "#" } %span.subscription-label {{issue.subscribed ? 'Unsubscribe' : 'Subscribe'}} diff --git a/app/views/shared/issuable/_sidebar.html.haml b/app/views/shared/issuable/_sidebar.html.haml index 799e24bc55f..f089cd64c8e 100644 --- a/app/views/shared/issuable/_sidebar.html.haml +++ b/app/views/shared/issuable/_sidebar.html.haml @@ -123,7 +123,7 @@ = icon('rss', 'aria-hidden': 'true') %span.toggle-text.hide-collapsed.pull-left Notifications - %button.btn.toggle-button.pull-right.js-subscribe-button.issuable-subscribe-button.hide-collapsed{ type: "button" , class: (subscribed ? "subscribed" : "unsubscribed") } + %a.btn.toggle-button.pull-right.js-subscribe-button.issuable-subscribe-button.hide-collapsed{ type: "button" , href: "#", class: (subscribed ? "subscribed" : "unsubscribed") } %span.subscription-label= subscribed ? 'Unsubscribe' : 'Subscribe' - project_ref = cross_project_reference(@project, issuable) -- cgit v1.2.1