From 6efe1531bdad8f48bc24a0fa315d74132bd139b2 Mon Sep 17 00:00:00 2001 From: Alfredo Sumaran Date: Fri, 18 Nov 2016 15:18:49 -0500 Subject: Delete StageButton component --- .../cycle_analytics/components/stage_button.js.es6 | 26 ---------------------- .../cycle_analytics/cycle_analytics_bundle.js | 1 - app/views/projects/cycle_analytics/show.html.haml | 14 +++++------- 3 files changed, 5 insertions(+), 36 deletions(-) delete mode 100644 app/assets/javascripts/cycle_analytics/components/stage_button.js.es6 diff --git a/app/assets/javascripts/cycle_analytics/components/stage_button.js.es6 b/app/assets/javascripts/cycle_analytics/components/stage_button.js.es6 deleted file mode 100644 index f5594c1244d..00000000000 --- a/app/assets/javascripts/cycle_analytics/components/stage_button.js.es6 +++ /dev/null @@ -1,26 +0,0 @@ -((global) => { - - global.cycleAnalytics = global.cycleAnalytics || {}; - - global.cycleAnalytics.StageButton = Vue.extend({ - props: { - stage: Object, - onStageClick: Function - }, - computed: { - classObject() { - return { - 'active': this.stage.active - } - } - }, - methods: { - onClick(stage) { - this.onStageClick(stage); - } - } - }); - - -})(window.gl || (window.gl = {})); - diff --git a/app/assets/javascripts/cycle_analytics/cycle_analytics_bundle.js b/app/assets/javascripts/cycle_analytics/cycle_analytics_bundle.js index 6ca12cb7e78..9e5a40211ab 100644 --- a/app/assets/javascripts/cycle_analytics/cycle_analytics_bundle.js +++ b/app/assets/javascripts/cycle_analytics/cycle_analytics_bundle.js @@ -29,7 +29,6 @@ $(() => { }, }, components: { - 'stage-button': gl.cycleAnalytics.StageButton, 'stage-issue-component': gl.cycleAnalytics.StageIssueComponent, 'stage-plan-component': gl.cycleAnalytics.StagePlanComponent, 'stage-code-component': gl.cycleAnalytics.StageCodeComponent, diff --git a/app/views/projects/cycle_analytics/show.html.haml b/app/views/projects/cycle_analytics/show.html.haml index 010f64b3bb5..bebe2782bd7 100644 --- a/app/views/projects/cycle_analytics/show.html.haml +++ b/app/views/projects/cycle_analytics/show.html.haml @@ -69,15 +69,11 @@ .stage-panel-body %nav.stage-nav %ul - %stage-button{ "inline-template" => true, - "v-for" => "stage in state.stages", - ":stage" => "stage", - ":on-stage-click" => "selectStage" } - %li.stage-nav-item{ ":class" => "classObject", "@click" => "onClick(stage)" } - .stage-name - {{ stage.title }} - .stage-median - {{ stage.value }} + %li.stage-nav-item{ ':class' => '{active: stage.active}', '@click' => 'selectStage(stage)', "v-for" => "stage in state.stages" } + .stage-name + {{ stage.title }} + .stage-median + {{ stage.value }} .section.stage-events %template{ "v-if" => "isLoadingStage" } = icon("spinner spin", "v-show" => "isLoadingStage") -- cgit v1.2.1