From 807c4eae46f96ccd54ce1d8d13f4547eda017267 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 7 Mar 2023 15:10:50 +0000 Subject: Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo/layout/argument_alignment.yml | 1 - .rubocop_todo/layout/line_length.yml | 1 - .rubocop_todo/rspec/context_wording.yml | 2 - .rubocop_todo/style/percent_literal_delimiters.yml | 1 - GITALY_SERVER_VERSION | 2 +- .../artifacts/components/job_artifacts_table.vue | 8 +- .../components/notes/activity_filter.vue | 112 ++++----- .../work_items/components/notes/activity_sort.vue | 99 ++++++++ .../notes/work_item_history_only_filter_note.vue | 61 +++++ .../notes/work_item_notes_activity_header.vue | 67 ++++++ .../work_items/components/work_item_notes.vue | 73 ++++-- app/assets/javascripts/work_items/constants.js | 6 + app/controllers/ide_controller.rb | 12 +- app/helpers/ide_helper.rb | 23 +- app/helpers/issuables_helper.rb | 2 +- app/helpers/nav/new_dropdown_helper.rb | 4 +- app/mailers/previews/notify_preview.rb | 8 + app/models/ci/job_artifact.rb | 2 + .../bulk_delete_by_project_service.rb | 5 +- .../job_artifacts/destroy_all_expired_service.rb | 2 +- .../ci/job_artifacts/destroy_batch_service.rb | 10 +- app/services/releases/links/base_service.rb | 4 + app/services/releases/links/create_service.rb | 4 +- app/services/releases/links/destroy_service.rb | 6 +- app/services/releases/links/update_service.rb | 6 +- .../groups/_invite_members_top_nav_link.html.haml | 2 - app/views/ide/_show.html.haml | 7 +- app/views/layouts/group.html.haml | 3 + app/views/layouts/header/_new_dropdown.html.haml | 5 +- app/views/layouts/project.html.haml | 3 + .../_invite_members_top_nav_link.html.haml | 2 - app/views/projects/branch_rules/_show.html.haml | 1 + .../15-1-deprecate-maintainer_note.yml | 15 -- ..._on_expired_unlocked_non_trace_job_artifacts.rb | 17 ++ db/schema_migrations/20230301065107 | 1 + db/structure.sql | 2 + doc/administration/dedicated/index.md | 106 +++++++++ doc/administration/get_started.md | 4 +- .../package_information/supported_os.md | 8 + doc/update/deprecations.md | 15 -- lib/api/release/links.rb | 12 +- lib/gitlab/ci/config/external/file/component.rb | 2 +- lib/gitlab/database/migration_helpers.rb | 4 +- lib/gitlab/regex.rb | 2 +- locale/gitlab.pot | 15 ++ package.json | 2 +- spec/fast_spec_helper.rb | 1 + .../components/job_artifacts_table_spec.js | 16 +- .../components/notes/activity_filter_spec.js | 61 ++--- .../components/notes/activity_sort_spec.js | 69 ++++++ .../work_item_history_only_filter_note_spec.js | 44 ++++ .../notes/work_item_notes_activity_header_spec.js | 65 ++++++ .../work_items/components/work_item_notes_spec.js | 21 +- spec/helpers/ide_helper_spec.rb | 255 ++++++++------------- spec/helpers/nav/new_dropdown_helper_spec.rb | 48 +--- spec/lib/gitlab/regex_spec.rb | 6 +- spec/models/ci/job_artifact_spec.rb | 23 ++ spec/models/concerns/taskable_spec.rb | 16 ++ spec/requests/ide_controller_spec.rb | 130 ++--------- .../destroy_all_expired_service_spec.rb | 10 + .../destroy_associations_service_spec.rb | 29 ++- .../ci/job_artifacts/destroy_batch_service_spec.rb | 32 +-- .../services/releases/links/create_service_spec.rb | 2 + .../releases/links/destroy_service_spec.rb | 3 + .../services/releases/links/update_service_spec.rb | 2 + spec/support/rspec_order_todo.yml | 2 - spec/views/layouts/group.html.haml_spec.rb | 30 +++ .../layouts/header/_new_dropdown.haml_spec.rb | 2 - spec/views/layouts/project.html.haml_spec.rb | 29 +++ yarn.lock | 8 +- 70 files changed, 1065 insertions(+), 588 deletions(-) create mode 100644 app/assets/javascripts/work_items/components/notes/activity_sort.vue create mode 100644 app/assets/javascripts/work_items/components/notes/work_item_history_only_filter_note.vue create mode 100644 app/assets/javascripts/work_items/components/notes/work_item_notes_activity_header.vue delete mode 100644 data/deprecations/15-1-deprecate-maintainer_note.yml create mode 100644 db/post_migrate/20230301065107_add_index_on_expired_unlocked_non_trace_job_artifacts.rb create mode 100644 db/schema_migrations/20230301065107 create mode 100644 spec/frontend/work_items/components/notes/activity_sort_spec.js create mode 100644 spec/frontend/work_items/components/notes/work_item_history_only_filter_note_spec.js create mode 100644 spec/frontend/work_items/components/notes/work_item_notes_activity_header_spec.js create mode 100644 spec/views/layouts/group.html.haml_spec.rb create mode 100644 spec/views/layouts/project.html.haml_spec.rb diff --git a/.rubocop_todo/layout/argument_alignment.yml b/.rubocop_todo/layout/argument_alignment.yml index e442a2a8856..146522c5e76 100644 --- a/.rubocop_todo/layout/argument_alignment.yml +++ b/.rubocop_todo/layout/argument_alignment.yml @@ -2371,7 +2371,6 @@ Layout/ArgumentAlignment: - 'spec/helpers/avatars_helper_spec.rb' - 'spec/helpers/emoji_helper_spec.rb' - 'spec/helpers/feature_flags_helper_spec.rb' - - 'spec/helpers/ide_helper_spec.rb' - 'spec/helpers/namespaces_helper_spec.rb' - 'spec/helpers/notify_helper_spec.rb' - 'spec/helpers/page_layout_helper_spec.rb' diff --git a/.rubocop_todo/layout/line_length.yml b/.rubocop_todo/layout/line_length.yml index 5508542a599..0206346fa0a 100644 --- a/.rubocop_todo/layout/line_length.yml +++ b/.rubocop_todo/layout/line_length.yml @@ -4927,7 +4927,6 @@ Layout/LineLength: - 'spec/requests/groups/milestones_controller_spec.rb' - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' - 'spec/requests/groups_controller_spec.rb' - - 'spec/requests/ide_controller_spec.rb' - 'spec/requests/jwt_controller_spec.rb' - 'spec/requests/lfs_http_spec.rb' - 'spec/requests/oauth/tokens_controller_spec.rb' diff --git a/.rubocop_todo/rspec/context_wording.yml b/.rubocop_todo/rspec/context_wording.yml index 1ad85791e69..d57f93a1719 100644 --- a/.rubocop_todo/rspec/context_wording.yml +++ b/.rubocop_todo/rspec/context_wording.yml @@ -1494,7 +1494,6 @@ RSpec/ContextWording: - 'spec/helpers/gitlab_routing_helper_spec.rb' - 'spec/helpers/groups/group_members_helper_spec.rb' - 'spec/helpers/groups_helper_spec.rb' - - 'spec/helpers/ide_helper_spec.rb' - 'spec/helpers/integrations_helper_spec.rb' - 'spec/helpers/jira_connect_helper_spec.rb' - 'spec/helpers/labels_helper_spec.rb' @@ -2575,7 +2574,6 @@ RSpec/ContextWording: - 'spec/requests/groups/settings/access_tokens_controller_spec.rb' - 'spec/requests/groups_controller_spec.rb' - 'spec/requests/health_controller_spec.rb' - - 'spec/requests/ide_controller_spec.rb' - 'spec/requests/jira_connect/installations_controller_spec.rb' - 'spec/requests/jira_connect/oauth_application_ids_controller_spec.rb' - 'spec/requests/jira_routing_spec.rb' diff --git a/.rubocop_todo/style/percent_literal_delimiters.yml b/.rubocop_todo/style/percent_literal_delimiters.yml index 66de6a35092..bc3c41ae992 100644 --- a/.rubocop_todo/style/percent_literal_delimiters.yml +++ b/.rubocop_todo/style/percent_literal_delimiters.yml @@ -993,7 +993,6 @@ Style/PercentLiteralDelimiters: - 'spec/requests/api/unleash_spec.rb' - 'spec/requests/api/users_spec.rb' - 'spec/requests/api/wikis_spec.rb' - - 'spec/requests/ide_controller_spec.rb' - 'spec/requests/jwt_controller_spec.rb' - 'spec/requests/lfs_locks_api_spec.rb' - 'spec/requests/users_controller_spec.rb' diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index 0fd64bd648e..f60c9678b67 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -1739a8ca9a5786b4730620b742153f45e00cb094 +65769c7a58d3339fe94a809bf6fd34f2f300a700 diff --git a/app/assets/javascripts/artifacts/components/job_artifacts_table.vue b/app/assets/javascripts/artifacts/components/job_artifacts_table.vue index a7331cc1fd3..1b7782c6860 100644 --- a/app/assets/javascripts/artifacts/components/job_artifacts_table.vue +++ b/app/assets/javascripts/artifacts/components/job_artifacts_table.vue @@ -68,9 +68,8 @@ export default { variables() { return this.queryVariables; }, - update({ project: { jobs: { nodes = [], pageInfo = {}, count = 0 } = {} } }) { + update({ project: { jobs: { nodes = [], pageInfo = {} } = {} } }) { this.pageInfo = pageInfo; - this.count = count; return nodes .map(mapArchivesToJobNodes) .map(mapBooleansToJobNodes) @@ -93,7 +92,6 @@ export default { data() { return { jobArtifacts: [], - count: 0, pageInfo: {}, expandedJobs: [], pagination: INITIAL_PAGINATION_STATE, @@ -110,7 +108,9 @@ export default { }; }, showPagination() { - return this.count > JOBS_PER_PAGE; + const { hasNextPage, hasPreviousPage } = this.pageInfo; + + return hasNextPage || hasPreviousPage; }, prevPage() { return Number(this.pageInfo.hasPreviousPage); diff --git a/app/assets/javascripts/work_items/components/notes/activity_filter.vue b/app/assets/javascripts/work_items/components/notes/activity_filter.vue index 71784d3a807..6d5535797ef 100644 --- a/app/assets/javascripts/work_items/components/notes/activity_filter.vue +++ b/app/assets/javascripts/work_items/components/notes/activity_filter.vue @@ -1,18 +1,35 @@ diff --git a/app/assets/javascripts/work_items/components/notes/activity_sort.vue b/app/assets/javascripts/work_items/components/notes/activity_sort.vue new file mode 100644 index 00000000000..bfbb2b65346 --- /dev/null +++ b/app/assets/javascripts/work_items/components/notes/activity_sort.vue @@ -0,0 +1,99 @@ + + + diff --git a/app/assets/javascripts/work_items/components/notes/work_item_history_only_filter_note.vue b/app/assets/javascripts/work_items/components/notes/work_item_history_only_filter_note.vue new file mode 100644 index 00000000000..07e25312f87 --- /dev/null +++ b/app/assets/javascripts/work_items/components/notes/work_item_history_only_filter_note.vue @@ -0,0 +1,61 @@ + + + diff --git a/app/assets/javascripts/work_items/components/notes/work_item_notes_activity_header.vue b/app/assets/javascripts/work_items/components/notes/work_item_notes_activity_header.vue new file mode 100644 index 00000000000..e700d5353e2 --- /dev/null +++ b/app/assets/javascripts/work_items/components/notes/work_item_notes_activity_header.vue @@ -0,0 +1,67 @@ + + + diff --git a/app/assets/javascripts/work_items/components/work_item_notes.vue b/app/assets/javascripts/work_items/components/work_item_notes.vue index aa6dd9b5184..331d0b5e8d0 100644 --- a/app/assets/javascripts/work_items/components/work_item_notes.vue +++ b/app/assets/javascripts/work_items/components/work_item_notes.vue @@ -1,11 +1,17 @@