From 980f29716f86a261e28dbc69de157a53c3eadb42 Mon Sep 17 00:00:00 2001 From: Tim Zallmann Date: Tue, 31 Oct 2017 09:18:30 +0000 Subject: Resolve "Convert autosize.js library to be a Yarn managed library" --- app/assets/javascripts/behaviors/autosize.js | 6 +- app/assets/javascripts/notes.js | 4 +- .../notes/components/issue_comment_form.vue | 4 +- package.json | 1 + spec/javascripts/gl_form_spec.js | 4 +- spec/javascripts/merge_request_notes_spec.js | 2 +- .../notes/components/issue_comment_form_spec.js | 6 +- spec/javascripts/notes_spec.js | 2 +- vendor/assets/javascripts/autosize.js | 243 --------------------- yarn.lock | 4 + 10 files changed, 19 insertions(+), 257 deletions(-) delete mode 100644 vendor/assets/javascripts/autosize.js diff --git a/app/assets/javascripts/behaviors/autosize.js b/app/assets/javascripts/behaviors/autosize.js index e00af4b2fa8..add43b81f6d 100644 --- a/app/assets/javascripts/behaviors/autosize.js +++ b/app/assets/javascripts/behaviors/autosize.js @@ -1,8 +1,8 @@ -import autosize from 'vendor/autosize'; +import Autosize from 'autosize'; document.addEventListener('DOMContentLoaded', () => { const autosizeEls = document.querySelectorAll('.js-autosize'); - autosize(autosizeEls); - autosize.update(autosizeEls); + Autosize(autosizeEls); + Autosize.update(autosizeEls); }); diff --git a/app/assets/javascripts/notes.js b/app/assets/javascripts/notes.js index ab101a56db8..705bec23b53 100644 --- a/app/assets/javascripts/notes.js +++ b/app/assets/javascripts/notes.js @@ -12,7 +12,7 @@ newline-per-chained-call, no-useless-escape, class-methods-use-this */ import $ from 'jquery'; import _ from 'underscore'; import Cookies from 'js-cookie'; -import autosize from 'vendor/autosize'; +import Autosize from 'autosize'; import 'vendor/jquery.caret'; // required by jquery.atwho import 'vendor/jquery.atwho'; import AjaxCache from '~/lib/utils/ajax_cache'; @@ -25,7 +25,7 @@ import TaskList from './task_list'; import { ajaxPost, isInViewport, getPagePath, scrollToElement, isMetaKey } from './lib/utils/common_utils'; import imageDiffHelper from './image_diff/helpers/index'; -window.autosize = autosize; +window.autosize = Autosize; function normalizeNewlines(str) { return str.replace(/\r\n/g, '\n'); diff --git a/app/assets/javascripts/notes/components/issue_comment_form.vue b/app/assets/javascripts/notes/components/issue_comment_form.vue index ad384a1cc36..db8f85759b2 100644 --- a/app/assets/javascripts/notes/components/issue_comment_form.vue +++ b/app/assets/javascripts/notes/components/issue_comment_form.vue @@ -1,7 +1,7 @@