From 1f90df083481975b7ceb0693a5bbb1164c5d2e1d Mon Sep 17 00:00:00 2001 From: Phil Hughes Date: Tue, 28 Jun 2016 16:59:36 +0100 Subject: Changed collapsed assignee tooltip to users name Fixes tooltip when updating the assignee Closes #19280 #19281 --- app/assets/javascripts/users_select.js.coffee | 6 +++++- app/views/shared/issuable/_sidebar.html.haml | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/users_select.js.coffee b/app/assets/javascripts/users_select.js.coffee index 4e032ab1ff1..344be811e0d 100644 --- a/app/assets/javascripts/users_select.js.coffee +++ b/app/assets/javascripts/users_select.js.coffee @@ -56,6 +56,11 @@ class @UsersSelect username: '' avatar: '' $value.html(assigneeTemplate(user)) + + $collapsedSidebar + .attr('title', user.name) + .tooltip('fixTitle') + $collapsedSidebar.html(collapsedAssigneeTemplate(user)) @@ -63,7 +68,6 @@ class @UsersSelect '<% if( avatar ) { %> - Toni Boehm <% } else { %> diff --git a/app/views/shared/issuable/_sidebar.html.haml b/app/views/shared/issuable/_sidebar.html.haml index adfab1af53e..e020a7d4d00 100644 --- a/app/views/shared/issuable/_sidebar.html.haml +++ b/app/views/shared/issuable/_sidebar.html.haml @@ -19,7 +19,7 @@ = form_for [@project.namespace.becomes(Namespace), @project, issuable], remote: true, format: :json, html: {class: 'issuable-context-form inline-update js-issuable-update'} do |f| .block.assignee - .sidebar-collapsed-icon.sidebar-collapsed-user{data: {toggle: "tooltip", placement: "left", container: "body"}, title: (issuable.assignee.to_reference if issuable.assignee)} + .sidebar-collapsed-icon.sidebar-collapsed-user{data: {toggle: "tooltip", placement: "left", container: "body"}, title: (issuable.assignee.name if issuable.assignee)} - if issuable.assignee = link_to_member(@project, issuable.assignee, size: 24) - else -- cgit v1.2.1 From 0666515e1fe461ec1ddefffb4ffd2955b5a478e1 Mon Sep 17 00:00:00 2001 From: Phil Hughes Date: Tue, 28 Jun 2016 17:57:31 +0100 Subject: CHANGELOG --- CHANGELOG | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG b/CHANGELOG index b0d86e4acad..15d105731d6 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -30,6 +30,7 @@ v 8.10.0 (unreleased) - Fix pagination when sorting by columns with lots of ties (like priority) - The Markdown reference parsers now re-use query results to prevent running the same queries multiple times !5020 - Updated project header design + - Issuable collapsed assignee tooltip is now the users name - Exclude email check from the standard health check - Updated layout for Projects, Groups, Users on Admin area !4424 - Fix changing issue state columns in milestone view -- cgit v1.2.1 From d61bf3b977b303f838c243645b5003256622a77d Mon Sep 17 00:00:00 2001 From: Sean McGivern Date: Thu, 14 Jul 2016 11:04:03 +0100 Subject: Update permissons links to new page permissions/permissions just links to user/permissions since https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5210 --- app/helpers/search_helper.rb | 2 +- app/views/admin/groups/show.html.haml | 2 +- app/views/errors/access_denied.html.haml | 2 +- app/views/groups/group_members/_new_group_member.html.haml | 2 +- app/views/projects/project_members/_new_project_member.html.haml | 2 +- app/views/projects/protected_branches/index.html.haml | 4 ++-- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/app/helpers/search_helper.rb b/app/helpers/search_helper.rb index b165b569372..fcb2703e837 100644 --- a/app/helpers/search_helper.rb +++ b/app/helpers/search_helper.rb @@ -45,7 +45,7 @@ module SearchHelper [ { category: "Help", label: "API Help", url: help_page_path("api/README") }, { category: "Help", label: "Markdown Help", url: help_page_path("markdown/markdown") }, - { category: "Help", label: "Permissions Help", url: help_page_path("permissions/permissions") }, + { category: "Help", label: "Permissions Help", url: help_page_path("user/permissions") }, { category: "Help", label: "Public Access Help", url: help_page_path("public_access/public_access") }, { category: "Help", label: "Rake Tasks Help", url: help_page_path("raketasks/README") }, { category: "Help", label: "SSH Keys Help", url: help_page_path("ssh/README") }, diff --git a/app/views/admin/groups/show.html.haml b/app/views/admin/groups/show.html.haml index 40c8169ad9d..bb374694400 100644 --- a/app/views/admin/groups/show.html.haml +++ b/app/views/admin/groups/show.html.haml @@ -79,7 +79,7 @@ .panel-body.form-holder %p.light Read more about project permissions - %strong= link_to "here", help_page_path("permissions/permissions"), class: "vlink" + %strong= link_to "here", help_page_path("user/permissions"), class: "vlink" = form_tag members_update_admin_group_path(@group), id: "new_project_member", class: "bulk_import", method: :put do %div diff --git a/app/views/errors/access_denied.html.haml b/app/views/errors/access_denied.html.haml index 2febeef99d3..c034bbe430e 100644 --- a/app/views/errors/access_denied.html.haml +++ b/app/views/errors/access_denied.html.haml @@ -3,4 +3,4 @@ %h3 Access Denied %hr %p You are not allowed to access this page. -%p Read more about project permissions #{link_to "here", help_page_path("permissions/permissions"), class: "vlink"} +%p Read more about project permissions #{link_to "here", help_page_path("user/permissions"), class: "vlink"} diff --git a/app/views/groups/group_members/_new_group_member.html.haml b/app/views/groups/group_members/_new_group_member.html.haml index 13ded2bc455..9bb9f962177 100644 --- a/app/views/groups/group_members/_new_group_member.html.haml +++ b/app/views/groups/group_members/_new_group_member.html.haml @@ -12,7 +12,7 @@ = select_tag :access_level, options_for_select(GroupMember.access_level_roles, @group_member.access_level), class: "project-access-select select2" .help-block Read more about role permissions - %strong= link_to "here", help_page_path("permissions/permissions"), class: "vlink" + %strong= link_to "here", help_page_path("user/permissions"), class: "vlink" .form-actions = f.submit 'Add users to group', class: "btn btn-create" diff --git a/app/views/projects/project_members/_new_project_member.html.haml b/app/views/projects/project_members/_new_project_member.html.haml index ea3d82d858e..978c4dfc5ec 100644 --- a/app/views/projects/project_members/_new_project_member.html.haml +++ b/app/views/projects/project_members/_new_project_member.html.haml @@ -12,7 +12,7 @@ = select_tag :access_level, options_for_select(ProjectMember.access_level_roles, @project_member.access_level), class: "project-access-select select2" .help-block Read more about role permissions - %strong= link_to "here", help_page_path("permissions/permissions"), class: "vlink" + %strong= link_to "here", help_page_path("user/permissions"), class: "vlink" .form-actions = f.submit 'Add users to project', class: "btn btn-create" diff --git a/app/views/projects/protected_branches/index.html.haml b/app/views/projects/protected_branches/index.html.haml index 3fab95751e0..883d3e3af1e 100644 --- a/app/views/projects/protected_branches/index.html.haml +++ b/app/views/projects/protected_branches/index.html.haml @@ -8,10 +8,10 @@ %p.prepend-top-20 Protected branches are designed to: %ul - %li prevent pushes from everybody except #{link_to "masters", help_page_path("permissions/permissions"), class: "vlink"} + %li prevent pushes from everybody except #{link_to "masters", help_page_path("user/permissions"), class: "vlink"} %li prevent anyone from force pushing to the branch %li prevent anyone from deleting the branch - %p.append-bottom-0 Read more about #{link_to "project permissions", help_page_path("permissions/permissions"), class: "underlined-link"} + %p.append-bottom-0 Read more about #{link_to "project permissions", help_page_path("user/permissions"), class: "underlined-link"} .col-lg-9 %h5.prepend-top-0 Protect a branch -- cgit v1.2.1 From 905d60b42980832933bebed43d4df1d227e36f15 Mon Sep 17 00:00:00 2001 From: Sean McGivern Date: Thu, 14 Jul 2016 16:26:26 +0100 Subject: Reduce padding on collapsed diff message --- app/assets/stylesheets/framework/blocks.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/app/assets/stylesheets/framework/blocks.scss b/app/assets/stylesheets/framework/blocks.scss index 24b1ebab4b0..cf2417fdf63 100644 --- a/app/assets/stylesheets/framework/blocks.scss +++ b/app/assets/stylesheets/framework/blocks.scss @@ -17,6 +17,7 @@ font-size: 16px; line-height: 36px; &.diff-collapsed { + padding: 5px; cursor: pointer; } } -- cgit v1.2.1 From d3653f07227e73e3035c7895ab12a5e0345af744 Mon Sep 17 00:00:00 2001 From: Annabel Dunstone Date: Thu, 14 Jul 2016 10:53:48 -0500 Subject: Change bg color of collapsed diff to blue on hover --- app/assets/stylesheets/framework/blocks.scss | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/app/assets/stylesheets/framework/blocks.scss b/app/assets/stylesheets/framework/blocks.scss index cf2417fdf63..ad94e457cfd 100644 --- a/app/assets/stylesheets/framework/blocks.scss +++ b/app/assets/stylesheets/framework/blocks.scss @@ -16,9 +16,14 @@ font-weight: normal; font-size: 16px; line-height: 36px; + &.diff-collapsed { padding: 5px; cursor: pointer; + + &:hover { + background-color: $row-hover; + } } } -- cgit v1.2.1 From 42a1dc50414909fd1907b5bef57219ea9361c6b4 Mon Sep 17 00:00:00 2001 From: Alfredo Sumaran Date: Mon, 11 Jul 2016 12:58:32 -0500 Subject: Remove unnecesary CSS class --- app/views/admin/projects/index.html.haml | 2 +- app/views/admin/users/_user.html.haml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/views/admin/projects/index.html.haml b/app/views/admin/projects/index.html.haml index 7fbce25b2c4..1e755785d90 100644 --- a/app/views/admin/projects/index.html.haml +++ b/app/views/admin/projects/index.html.haml @@ -66,7 +66,7 @@ %ul.projects-list.content-list - @projects.each_with_index do |project| %li.project-row - .controls.pull-right + .controls - if project.archived %span.label.label-warning archived %span.label.label-gray diff --git a/app/views/admin/users/_user.html.haml b/app/views/admin/users/_user.html.haml index d3519f616f6..4bf1c9cde3c 100644 --- a/app/views/admin/users/_user.html.haml +++ b/app/views/admin/users/_user.html.haml @@ -14,7 +14,7 @@ %span It's you! .user-email = mail_to user.email, user.email - .controls.pull-right + .controls = link_to 'Edit', edit_admin_user_path(user), id: "edit_#{dom_id(user)}", class: 'btn' - unless user == current_user .dropdown.inline -- cgit v1.2.1 From 2ed52071522f3cafd12ee8d9cd15d53db4171e1b Mon Sep 17 00:00:00 2001 From: Alfredo Sumaran Date: Mon, 11 Jul 2016 12:59:01 -0500 Subject: Rename .group-controls to .controls --- app/assets/stylesheets/pages/groups.scss | 4 ++-- app/views/admin/groups/_group.html.haml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/assets/stylesheets/pages/groups.scss b/app/assets/stylesheets/pages/groups.scss index 701b9388454..a0b8bd2e28d 100644 --- a/app/assets/stylesheets/pages/groups.scss +++ b/app/assets/stylesheets/pages/groups.scss @@ -44,7 +44,7 @@ display: -ms-flexbox; display: flex; - .group-avatar, .group-details, .group-controls { + .group-avatar, .group-details, .controls { display: -webkit-flex; display: -ms-flexbox; display: flex; @@ -56,7 +56,7 @@ min-width: 0; } - .group-controls { + .controls { align-items: center; a { diff --git a/app/views/admin/groups/_group.html.haml b/app/views/admin/groups/_group.html.haml index 59fd6c3fea0..02b943141e4 100644 --- a/app/views/admin/groups/_group.html.haml +++ b/app/views/admin/groups/_group.html.haml @@ -15,6 +15,6 @@ - if group.description.present? .description = markdown(group.description, pipeline: :description) - .group-controls.hidden-xs + .controls.hidden-xs = link_to 'Edit', edit_admin_group_path(group), id: "edit_#{dom_id(group)}", class: 'btn' = link_to 'Delete', [:admin, group], data: { confirm: "Are you sure you want to remove #{group.name}?" }, method: :delete, class: 'btn btn-remove' -- cgit v1.2.1 From 75528e19302dfc86254eb4e9f5d2878f64bc80b1 Mon Sep 17 00:00:00 2001 From: Alfredo Sumaran Date: Mon, 11 Jul 2016 12:59:23 -0500 Subject: Make CSS consistent again --- app/assets/stylesheets/pages/admin.scss | 8 +------- app/assets/stylesheets/pages/groups.scss | 4 ---- app/assets/stylesheets/pages/projects.scss | 4 ++++ 3 files changed, 5 insertions(+), 11 deletions(-) diff --git a/app/assets/stylesheets/pages/admin.scss b/app/assets/stylesheets/pages/admin.scss index 1d34a7f79ae..5607239d92d 100644 --- a/app/assets/stylesheets/pages/admin.scss +++ b/app/assets/stylesheets/pages/admin.scss @@ -88,13 +88,7 @@ .user-name { display: inline-block; - font-weight: bold; - } - - .controls { - > .btn, > .dropdown { - margin-left: 5px; - } + font-weight: 600; } .dropdown { diff --git a/app/assets/stylesheets/pages/groups.scss b/app/assets/stylesheets/pages/groups.scss index a0b8bd2e28d..3682b886cb3 100644 --- a/app/assets/stylesheets/pages/groups.scss +++ b/app/assets/stylesheets/pages/groups.scss @@ -58,10 +58,6 @@ .controls { align-items: center; - - a { - margin-left: 5px; - } } } diff --git a/app/assets/stylesheets/pages/projects.scss b/app/assets/stylesheets/pages/projects.scss index 5be911dc562..fa4af0f9c8b 100644 --- a/app/assets/stylesheets/pages/projects.scss +++ b/app/assets/stylesheets/pages/projects.scss @@ -482,6 +482,10 @@ pre.light-well { a:hover { text-decoration: none; } + + > span { + margin-left: 10px; + } } } -- cgit v1.2.1 From 079d9c04404b37d7b15ff5da6a313d08ca599315 Mon Sep 17 00:00:00 2001 From: Alfredo Sumaran Date: Mon, 11 Jul 2016 15:02:52 -0500 Subject: Fix New Group button spacing on mobile --- app/assets/stylesheets/pages/search.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/stylesheets/pages/search.scss b/app/assets/stylesheets/pages/search.scss index 9e9b18fdbb8..c9d436d72ba 100644 --- a/app/assets/stylesheets/pages/search.scss +++ b/app/assets/stylesheets/pages/search.scss @@ -185,7 +185,7 @@ padding-right: $gl-padding + 15px; } - .btn-search { + .btn-search, .btn-new { width: 100%; margin-top: 5px; -- cgit v1.2.1 From 5fc690df6ec2350c81f02098edba271a1eba5e0b Mon Sep 17 00:00:00 2001 From: Alfredo Sumaran Date: Thu, 14 Jul 2016 17:13:38 -0500 Subject: Make admin/groups view consistent with dashboard/groups --- app/views/admin/groups/_group.html.haml | 37 ++++++++++++++++++--------------- 1 file changed, 20 insertions(+), 17 deletions(-) diff --git a/app/views/admin/groups/_group.html.haml b/app/views/admin/groups/_group.html.haml index 02b943141e4..f6c76302da5 100644 --- a/app/views/admin/groups/_group.html.haml +++ b/app/views/admin/groups/_group.html.haml @@ -1,20 +1,23 @@ -- css_class = '' unless local_assigns[:css_class] +- css_class = 'no-description' if group.description.blank? -%li.group-row.group-admin{ class: css_class } - .group-avatar - = image_tag group_icon(group), class: 'avatar hidden-xs' - .group-details - .title - = link_to [:admin, group], class: 'group-name' do - = group.name - .group-stats - %span>= pluralize(number_with_delimiter(group.projects.count), 'project') - , - %span= pluralize(number_with_delimiter(group.users.count), 'member') - - - if group.description.present? - .description - = markdown(group.description, pipeline: :description) - .controls.hidden-xs +%li.group-row{ class: css_class } + .controls = link_to 'Edit', edit_admin_group_path(group), id: "edit_#{dom_id(group)}", class: 'btn' = link_to 'Delete', [:admin, group], data: { confirm: "Are you sure you want to remove #{group.name}?" }, method: :delete, class: 'btn btn-remove' + .stats + %span + = icon('bookmark') + = number_with_delimiter(group.projects.count) + + %span + = icon('users') + = number_with_delimiter(group.users.count) + + = image_tag group_icon(group), class: "avatar s40 hidden-xs" + .title + = link_to [:admin, group], class: 'group-name' do + = group.name + + - if group.description.present? + .description + = markdown(group.description, pipeline: :description) -- cgit v1.2.1 From 7ab4f2ad3cc5b9bb394d578e3f6069cdff06f1ee Mon Sep 17 00:00:00 2001 From: Alfredo Sumaran Date: Thu, 14 Jul 2016 17:14:01 -0500 Subject: Remove previously introduced CSS that will not be used anymore --- app/assets/stylesheets/pages/groups.scss | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/app/assets/stylesheets/pages/groups.scss b/app/assets/stylesheets/pages/groups.scss index 3682b886cb3..2a3acc3eb4c 100644 --- a/app/assets/stylesheets/pages/groups.scss +++ b/app/assets/stylesheets/pages/groups.scss @@ -38,29 +38,6 @@ margin-right: 15px; } } - - &.group-admin { - display: -webkit-flex; - display: -ms-flexbox; - display: flex; - - .group-avatar, .group-details, .controls { - display: -webkit-flex; - display: -ms-flexbox; - display: flex; - } - - .group-details { - flex: 1 1 auto; - flex-direction: column; - min-width: 0; - } - - .controls { - align-items: center; - } - } - } .ldap-group-links { -- cgit v1.2.1 From 2231116ed72eb5c6ce6bc1c838724ed0ee199831 Mon Sep 17 00:00:00 2001 From: Alfredo Sumaran Date: Thu, 14 Jul 2016 18:02:50 -0500 Subject: Add visibility icon --- app/views/admin/groups/_group.html.haml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/views/admin/groups/_group.html.haml b/app/views/admin/groups/_group.html.haml index f6c76302da5..77a11e49e20 100644 --- a/app/views/admin/groups/_group.html.haml +++ b/app/views/admin/groups/_group.html.haml @@ -13,6 +13,9 @@ = icon('users') = number_with_delimiter(group.users.count) + %span.visibility-icon.has-tooltip{data: { container: 'body', placement: 'left' }, title: visibility_icon_description(group)} + = visibility_level_icon(group.visibility_level, fw: false) + = image_tag group_icon(group), class: "avatar s40 hidden-xs" .title = link_to [:admin, group], class: 'group-name' do -- cgit v1.2.1 From f435eb6f35ab755dae1fd45d9aa577f6896eae7b Mon Sep 17 00:00:00 2001 From: Lin Jen-Shin Date: Fri, 15 Jul 2016 16:53:22 +0800 Subject: navbar_icon was renamed to custom_icon in: https://gitlab.com/gitlab-org/gitlab-ce/commit/c57471ddb456c9640f6d77128e1fc56c7a5b35b2 navbar_icon was used in: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4909 --- app/views/dashboard/projects/_zero_authorized_projects.html.haml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/views/dashboard/projects/_zero_authorized_projects.html.haml b/app/views/dashboard/projects/_zero_authorized_projects.html.haml index 40c70fa3025..fdea834ff45 100644 --- a/app/views/dashboard/projects/_zero_authorized_projects.html.haml +++ b/app/views/dashboard/projects/_zero_authorized_projects.html.haml @@ -6,7 +6,7 @@ Code, test, and deploy together .blank-state .blank-state-icon - = navbar_icon("project", size: 50) + = custom_icon("project", size: 50) %h3.blank-state-title You don't have access to any projects right now %p.blank-state-text @@ -24,7 +24,7 @@ - if current_user.can_create_group? .blank-state .blank-state-icon - = navbar_icon("group", size: 50) + = custom_icon("group", size: 50) %h3.blank-state-title You can create a group for several dependent projects. %p.blank-state-text -- cgit v1.2.1