From a10d09ec655d37d22c4ec5cadadaa1bdb6cd2f32 Mon Sep 17 00:00:00 2001 From: Andreas Brandl Date: Tue, 20 Feb 2018 14:12:56 +0100 Subject: Fix N+1 query problem for users on members view. For each member being rendered on Projects::ProjectMembersController#index, there was a query to the users table to retrieve the corresponding user: ``` SELECT "users".* FROM "users" WHERE "users"."id" = ? LIMIT 1 ``` --- app/finders/members_finder.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/finders/members_finder.rb b/app/finders/members_finder.rb index 271d846b269..092c2b3b71e 100644 --- a/app/finders/members_finder.rb +++ b/app/finders/members_finder.rb @@ -19,7 +19,7 @@ class MembersFinder sql = distinct_on(union) - Member.from("(#{sql}) AS #{Member.table_name}") + Member.includes(:user).from("(#{sql}) AS #{Member.table_name}") else project_members end -- cgit v1.2.1