From b397ad8a6909ca21631dae5aae5e4a3373b5f2aa Mon Sep 17 00:00:00 2001 From: Stan Hu Date: Wed, 10 Apr 2019 12:04:30 -0700 Subject: Disable method instrumentation for diffs When there a large number of discussions on diffs, the instrumentation has a significant impact on performance since it's often run in a tight loop for line position calculation etc. We should disable this since there are other ways to benchmark performance. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/52898 --- changelogs/unreleased/sh-disable-diff-instrumentation.yml | 5 +++++ config/initializers/zz_metrics.rb | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) create mode 100644 changelogs/unreleased/sh-disable-diff-instrumentation.yml diff --git a/changelogs/unreleased/sh-disable-diff-instrumentation.yml b/changelogs/unreleased/sh-disable-diff-instrumentation.yml new file mode 100644 index 00000000000..55f4c2a8510 --- /dev/null +++ b/changelogs/unreleased/sh-disable-diff-instrumentation.yml @@ -0,0 +1,5 @@ +--- +title: Disable method instrumentation for diffs +merge_request: 27235 +author: +type: performance diff --git a/config/initializers/zz_metrics.rb b/config/initializers/zz_metrics.rb index 151cad3ef9a..5aa6f73c5c5 100644 --- a/config/initializers/zz_metrics.rb +++ b/config/initializers/zz_metrics.rb @@ -30,7 +30,6 @@ def instrument_classes(instrumentation) # are included. %w(app services [^concerns]**) => %w(app services), %w(lib gitlab conflicts) => ['lib'], - %w(lib gitlab diff) => ['lib'], %w(lib gitlab email message) => ['lib'], %w(lib gitlab checks) => ['lib'] } -- cgit v1.2.1