From d61c72a08de74e95005fcf875e134b927c7a616b Mon Sep 17 00:00:00 2001 From: Brandon Labuschagne Date: Tue, 7 May 2019 14:11:36 +0200 Subject: I18N of batch_comments directory This is one of many MRs opened in order to improve the overall internationalisation of the GitLab codebase. This commit only targets Vanilla JS files. i18n documentation https://docs.gitlab.com/ee/development/i18n/externalization.html --- app/assets/javascripts/batch_comments/mixins/resolved_status.js | 6 ++++-- locale/gitlab.pot | 6 ++++++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/batch_comments/mixins/resolved_status.js b/app/assets/javascripts/batch_comments/mixins/resolved_status.js index 96ee9f62ba4..3bbbaa86b51 100644 --- a/app/assets/javascripts/batch_comments/mixins/resolved_status.js +++ b/app/assets/javascripts/batch_comments/mixins/resolved_status.js @@ -1,10 +1,12 @@ +import { sprintf, __ } from '~/locale'; + export default { computed: { resolveButtonTitle() { - let title = 'Mark comment as resolved'; + let title = __('Mark comment as resolved'); if (this.resolvedBy) { - title = `Resolved by ${this.resolvedBy.name}`; + title = sprintf(__('Resolved by %{name}'), { name: this.resolvedBy.name }); } return title; diff --git a/locale/gitlab.pot b/locale/gitlab.pot index a4fb9ec927a..081e7c255d9 100644 --- a/locale/gitlab.pot +++ b/locale/gitlab.pot @@ -5773,6 +5773,9 @@ msgstr "" msgid "Mark as resolved" msgstr "" +msgid "Mark comment as resolved" +msgstr "" + msgid "Mark this issue as a duplicate of another issue" msgstr "" @@ -8167,6 +8170,9 @@ msgstr "" msgid "Resolved all discussions." msgstr "" +msgid "Resolved by %{name}" +msgstr "" + msgid "Resolved by %{resolvedByName}" msgstr "" -- cgit v1.2.1