From bf0f182788f5bb4e2adb46c9af97c7e238b7a9b8 Mon Sep 17 00:00:00 2001
From: Steve Azzopardi <steveazz@outlook.com>
Date: Fri, 8 Mar 2019 10:55:46 +0100
Subject: Fix `gitlab:ui:visual` to not run for docs

The ` gitlab:ui:visual` is using the anchor `*except-docs` to not run
the job when it's a docs change, but since we are redefining `expect` in
the job this is overrided, which results into the job running anyways
when it's a docs change. For example
https://gitlab.com/gitlab-org/gitlab-ce/pipelines/50890096
---
 .gitlab-ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 26087b2cc4d..7e6847fa209 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -684,7 +684,6 @@ gitlab:assets:compile:
     - gitlab-org
 
 gitlab:ui:visual:
-  <<: *except-docs
   tags:
     - gitlab-org
   before_script: []
@@ -706,6 +705,7 @@ gitlab:ui:visual:
   except:
     refs:
       - master
+      - /(^docs[\/-].*|.*-docs$)
     variables:
       - $CI_COMMIT_MESSAGE =~ /\[skip visual\]/i
   artifacts:
-- 
cgit v1.2.1